Setting Workbench as Render Engine blocks loading of icon previews #69001
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#69001
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 860M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86
Blender Version
Broken: version: 2.81 (sub 2), branch: master, commit date: 2019-08-17 21:40, hash:
e69fb44027
Short description of error
Setting Workbench as Render Engine blocks loading of icon previews, while setting it to EEVEE or Cycles does not.
Exact steps for others to reproduce the error
Change Render Engine to Workbench and use Run Script again (icon does not load).
workbench_x_icons.mp4
Added subscriber: @MikhailRachinskiy
blender/blender-addons#80110 was marked as duplicate of this issue
#76169 was marked as duplicate of this issue
#74405 was marked as duplicate of this issue
Added subscriber: @lichtwerk
Interesting, will have a quick look...
Afaict,
bpy_utils_previews_load
does its thing in three cases without something obvious going wrong, needs some further investigation still :(Added subscriber: @Andrew_D
Added subscribers: @Dervock, @BrendonMurphy
Added subscriber: @oswaldo.sndvl
So I was able to recreate the problem and a temporary solution. I made a video of it. HopsIcons.mp4
Added subscriber: @rjg
When the workbench engine is used, the
icon_preview_startjob
isn't called, which results in the missing icon.icon_preview_startjob
should've been called eventually onceicon_preview_startjob_all_sizes
is called (set as callback for window manager job byED_preview_icon_job
).Callstack when Eevee is used:
However, it doesn't when the render engine is set to Workbench because of the following check in
icon_preview_startjob_all_sizes
:This checks if the render engine type has the
RE_USE_PREVIEW
flag set, which is to indicate whether the engine is able to render previews. This appears entirely irrelevant for the previewing of image icons as the one in the task. The Workbench engine doesn't have the flag set, thusicon_preview_startjob_all_sizes
never callsother_id_types_preview_render
.I have to check if I've missed any edge case, but the following seems to do the job:
The
prv->tag & PRV_TAG_DEFERRED
is used to determine whether this preview is to be rendered or an image for which deferred loading is used. If it's the latter it shouldn't run into any unsupported cases inother_id_types_preview_render
,common_preview_startjob
oricon_preview_startjob
.This issue was referenced by
c0d2b10c59
Changed status from 'Confirmed' to: 'Resolved'