KeyingScreen Compositor node emits "black holes" #69079

Closed
opened 2019-08-23 10:46:08 +02:00 by Hauke Wintjen · 12 comments

The attacged folder shows a bug in the KeyingScreen compositor node.

In the Screenshot GreenPlateBug-Screenshot.png it can be seen in the above compositor window that some areas are filled with black
instead of grey / green.

That appeared after creating the "last" track marker (the selected / larger track marker in the below window).

If you remove that larger marker, the bug disappears.

To reproduce, open the attached blend file, close render window, disconnect / reconnect the viewer node to the keying screen node to
see in backdrop display.

The bug appeared in a different usage of the KeyingScreen node with much fewer track markers, but since the circumstances of
the bug to appear is unclear, i had to add a lot marker here.

Blender version 2.80 (snap Ubuntu version).
OS: Ubuntu 19.04 x86
Graphics Card: Prime Laptop (NVidia / Intel combination) Dell Inspirion 4500 Laptop in Intel mode

The attacged folder shows a bug in the KeyingScreen compositor node. In the Screenshot GreenPlateBug-Screenshot.png it can be seen in the above compositor window that some areas are filled with black instead of grey / green. That appeared after creating the "last" track marker (the selected / larger track marker in the below window). If you remove that larger marker, the bug disappears. To reproduce, open the attached blend file, close render window, disconnect / reconnect the viewer node to the keying screen node to see in backdrop display. The bug appeared in a different usage of the KeyingScreen node with much fewer track markers, but since the circumstances of the bug to appear is unclear, i had to add a lot marker here. Blender version 2.80 (snap Ubuntu version). OS: Ubuntu 19.04 x86 Graphics Card: Prime Laptop (NVidia / Intel combination) Dell Inspirion 4500 Laptop in Intel mode
Author

Added subscriber: @hcw70

Added subscriber: @hcw70
Author
[GreenPlateBug.zip](https://archive.blender.org/developer/F7692284/GreenPlateBug.zip)
Author

GreenPlateBug-Screenshot.png

![GreenPlateBug-Screenshot.png](https://archive.blender.org/developer/F7692289/GreenPlateBug-Screenshot.png)
Author

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker
Author

@Jeroen-Bakker Maybe you could have a look?

@Jeroen-Bakker Maybe you could have a look?
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Sorry this has been lying around for so long.
Can confirm for this particular case/marker.

Black holes also disappear if any of these two markers are removed:
image.png

Checking...

Sorry this has been lying around for so long. Can confirm for this particular case/marker. Black holes also disappear if any of these two markers are removed: ![image.png](https://archive.blender.org/developer/F8248186/image.png) Checking...
Member

Added subscriber: @Sergey

Added subscriber: @Sergey
Member

Some sort of failure of the voronoi magic;
For some very specific marker positions, we are running into the situation where some pixels just dont want to fit into any of the computed triangles, barycentric_inside_triangle_v2 is always false for them...
(or maybe there is something else going wrong in KeyingScreenOperation::buildVoronoiTriangulation?)

Here is an even simpler case (just those three culprit markers)
GreenPlateBug repro.blend

CC @Sergey

Some sort of failure of the voronoi magic; For some very specific marker positions, we are running into the situation where some pixels just dont want to fit into any of the computed triangles, `barycentric_inside_triangle_v2` is always false for them... (or maybe there is something else going wrong in KeyingScreenOperation::buildVoronoiTriangulation?) Here is an even simpler case (just those three culprit markers) [GreenPlateBug repro.blend](https://archive.blender.org/developer/F8248275/GreenPlateBug_repro.blend) CC @Sergey

The actual root of the problem is that voronoi calculation/triangulation does not generate triangles for those regions. This can be seen by dumping triangles and plotting them (I did t manually, so a bit hard to share anything easy-to-repro-to-see-the-problem).

The actual root of the problem is that voronoi calculation/triangulation does not generate triangles for those regions. This can be seen by dumping triangles and plotting them (I did t manually, so a bit hard to share anything easy-to-repro-to-see-the-problem).
Philipp Oeser removed the
Interest
VFX & Video
label 2023-02-10 09:32:06 +01:00
Member

This is fixed by the new Keying Screen node introduced in Blender 4.1.

This is fixed by the new Keying Screen node introduced in Blender 4.1.
Blender Bot added
Status
Archived
and removed
Status
Confirmed
labels 2024-03-11 09:57:03 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#69079
No description provided.