Some Integer button increment/decrement arrows are broken (e.g Color Ramp switch arrows don't work) #69305

New Issue

Vlad · 2019-08-29T17:00:49+02:00

Vlad commented

2019-08-29 17:00:49 +02:00

System Information
Operating system: Windows 10

Blender Version
Broken: 2.81 Alpha, 2019-08-29

Short description of error
Clicking the arrows to switch the color inputs in the Color Ramp does nothing, holding and dragging the index area does work though.

Exact steps for others to reproduce the error
Add a color ramp node to the shader editor and try to switch color inputs by clicking the arrow button.

**System Information** Operating system: Windows 10 **Blender Version** Broken: 2.81 Alpha, 2019-08-29 **Short description of error** Clicking the arrows to switch the color inputs in the Color Ramp does nothing, holding and dragging the index area does work though. **Exact steps for others to reproduce the error** Add a color ramp node to the shader editor and try to switch color inputs by clicking the arrow button. ![7dbT5burXe.gif](https://archive.blender.org/developer/F7709665/7dbT5burXe.gif)

Vlad commented

2019-08-29 17:00:49 +02:00

Added subscriber: @guro

Philipp Oeser commented

2019-08-30 10:07:07 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-08-30 10:07:07 +02:00

Confirmed checking....
Note: getting BLI_assert failed: /blender/source/blender/editors/interface/interface_handlers.c:4810, ui_do_but_NUM(), at 'value_step > 0' Aborted (core dumped)

Confirmed checking.... Note: getting `BLI_assert failed: /blender/source/blender/editors/interface/interface_handlers.c:4810, ui_do_but_NUM(), at 'value_step > 0' Aborted (core dumped)`

Philipp Oeser commented

2019-08-30 10:20:23 +02:00

Got a fix, just checking for a more general solution...

Philipp Oeser commented

2019-08-30 10:43:15 +02:00

Added subscribers: @JulianEisel, @ideasman42, @brecht

Philipp Oeser commented

2019-08-30 10:43:15 +02:00

Since 78b56fa7d9 many Integer arrow buttons are broken.
That is because many of them define a button with but->a1 = 0.
This was fine before above commit, but is not working anymore.

So we have two possibilities:

(1) we can be more forgiving in ui_do_but_NUM and still handle all buttons defining but->a1 = 0 here as having a step value of 1 (this was automatically the case before 78b56fa7d9)
(2) we need to go over all buttons UI_BTYPE_NUM and check how they define their step value, if it is 0, we should set it to 1.

I think (2) actually makes more sense, it is a bit more work, but is more readable and doesnt hide functionality in ui_do_but_NUM.
I can do both, just need feedback from @ideasman42, @brecht, @JulianEisel ...

Since 78b56fa7d9 many Integer arrow buttons are broken. That is because many of them define a button with `but->a1 = 0`. This was fine before above commit, but is not working anymore. So we have two possibilities: - (1) we can be more forgiving in `ui_do_but_NUM` and still handle all buttons defining `but->a1 = 0` here as having a step value of 1 (this was automatically the case before 78b56fa7d9) - (2) we need to go over all buttons `UI_BTYPE_NUM` and check how they define their step value, if it is `0`, we should set it to `1`. I think (2) actually makes more sense, it is a bit more work, but is more readable and doesnt hide functionality in `ui_do_but_NUM`. I can do both, just need feedback from @ideasman42, @brecht, @JulianEisel ...

Philipp Oeser changed title from ~~Color Ramp switch arrows don't work~~ to Most Integer button increment/decrement arrows are broken (e.g Color Ramp switch arrows don't work)

2019-08-30 10:45:02 +02:00

Philipp Oeser commented

2019-08-30 11:07:06 +02:00

Push back prio on this (it werent that many buttons actually...), went over them, diff incoming...

Philipp Oeser changed title from ~~Most Integer button increment/decrement arrows are broken (e.g Color Ramp switch arrows don't work)~~ to Some Integer button increment/decrement arrows are broken (e.g Color Ramp switch arrows don't work)

2019-08-30 11:07:19 +02:00

blender-admin commented

2019-08-30 11:11:23 +02:00

This issue was referenced by 44ace647a8

This issue was referenced by 44ace647a8ec0d112700afe0c394ec25257fc04f

Philipp Oeser commented

2019-08-30 12:47:52 +02:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2019-08-30 12:47:52 +02:00

Philipp Oeser self-assigned this 2019-08-30 12:47:52 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Some Integer button increment/decrement arrows are broken (e.g Color Ramp switch arrows don't work) #69305