Error popups spawned from new FileBrowser are "swallowed" (e.g. Addon import/export errors) #69581

New Issue

Philipp Oeser · 2019-09-06T11:41:53+02:00

Philipp Oeser commented

2019-09-06 11:41:53 +02:00

System Information
Operating system: Linux-5.2.8-200.fc30.x86_64-x86_64-with-fedora-30-Thirty 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.26

Blender Version
Broken: version: 2.81 (sub 8), d813cc706d
Worked: version: 2.81 (sub 8), 6fc6f2504d

Short description of error
Error popups spawned from new FileBrowser are "swallowed" (e.g. Addon import/export errors) and cannot be seen in the UI anymore.
They are still thrown to the console, but users will be unaware of these errors which will make bugreports a pain and is generally a bad user experience.

Exact steps for others to reproduce the error

force an error in an Addon, e.g. by doing
P1094: ForceAddonError



diff --git a/io_scene_obj/__init__.py b/io_scene_obj/__init__.py
index bddf758b..434a0cc9 100644
--- a/io_scene_obj/__init__.py
+++ b/io_scene_obj/__init__.py
@@ -446,7 +446,7 @@ class ExportOBJ(bpy.types.Operator, ExportHelper):
     def execute(self, context):
         from . import export_obj
 
-        from mathutils import Matrix
+        from mathutils import DecentralizedCommunication
         keywords = self.as_keywords(ignore=("axis_forward",
                                             "axis_up",
                                             "global_scale",

with the above, from the default scene, do File > Export > Wavefront (.obj)
you should get an error, but... nothing
error is still thrown to the console, but we need this in the UI as well!

Traceback (most recent call last):
File "/build_linux/bin/2.81/scripts/addons/io_scene_obj/__init__.py", line 449, in execute
    from mathutils import DecentralizedCommunication
ImportError: cannot import name 'DecentralizedCommunication' from 'mathutils' (unknown location)

Not quite sure why d813cc706d broke this, needs more checking...

**System Information** Operating system: Linux-5.2.8-200.fc30.x86_64-x86_64-with-fedora-30-Thirty 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.26 **Blender Version** Broken: version: 2.81 (sub 8), d813cc706d Worked: version: 2.81 (sub 8), 6fc6f2504d **Short description of error** Error popups spawned from new FileBrowser are "swallowed" (e.g. Addon import/export errors) and cannot be seen in the UI anymore. They are still thrown to the console, but users will be unaware of these errors which will make bugreports a pain and is generally a bad user experience. **Exact steps for others to reproduce the error** - force an error in an Addon, e.g. by doing [P1094: ForceAddonError](https://archive.blender.org/developer/P1094.txt) ``` diff --git a/io_scene_obj/__init__.py b/io_scene_obj/__init__.py index bddf758b..434a0cc9 100644 --- a/io_scene_obj/__init__.py +++ b/io_scene_obj/__init__.py @@ -446,7 +446,7 @@ class ExportOBJ(bpy.types.Operator, ExportHelper): def execute(self, context): from . import export_obj - from mathutils import Matrix + from mathutils import DecentralizedCommunication keywords = self.as_keywords(ignore=("axis_forward", "axis_up", "global_scale", ``` - with the above, from the default scene, do `File` > `Export` > `Wavefront (.obj)` - you should get an error, but... nothing - error is still thrown to the console, but we need this in the UI as well! ``` Traceback (most recent call last): File "/build_linux/bin/2.81/scripts/addons/io_scene_obj/__init__.py", line 449, in execute from mathutils import DecentralizedCommunication ImportError: cannot import name 'DecentralizedCommunication' from 'mathutils' (unknown location) ``` Not quite sure why d813cc706d broke this, needs more checking...

Philipp Oeser commented

2019-09-06 11:41:53 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-09-06 11:43:32 +02:00

Added subscribers: @WilliamReynish, @JulianEisel

Philipp Oeser commented

2019-09-06 11:43:32 +02:00

I dare setting this to High...

CC @WilliamReynish
CC @JulianEisel

I dare setting this to High... CC @WilliamReynish CC @JulianEisel

blender-admin commented

2019-09-06 12:48:23 +02:00

This issue was referenced by 4c20c53b89

This issue was referenced by 4c20c53b8980535fd0d62a5285a1e27bbe6e829d

Julian Eisel commented

2019-09-06 12:51:35 +02:00

Changed status from 'Open' to: 'Resolved'

Julian Eisel closed this issue

2019-09-06 12:51:35 +02:00

Julian Eisel self-assigned this 2019-09-06 12:51:35 +02:00

Philipp Oeser commented

2019-09-06 12:57:44 +02:00

Since 4c20c53b89 (thx @JulianEisel! ) only partially fixes, will reopen...

Since 4c20c53b89 (thx @JulianEisel! ) only **partially** fixes, will reopen...

Philipp Oeser commented

2019-09-06 12:57:52 +02:00

Changed status from 'Resolved' to: 'Open'

Philipp Oeser reopened this issue

2019-09-06 12:57:52 +02:00

Julian Eisel commented

2019-09-06 13:14:25 +02:00

Setting to medium though since the error is reported clearly now, it's just missing the additional popup report.
Got an appointment now, will check as soon as I'm back.

Setting to medium though since the error is reported clearly now, it's just missing the additional popup report. Got an appointment now, will check as soon as I'm back.

Julian Eisel commented

2019-09-06 16:58:41 +02:00

Changed status from 'Open' to: 'Resolved'

Julian Eisel closed this issue

2019-09-06 16:58:41 +02:00

Julian Eisel commented

2019-09-06 16:58:41 +02:00

Committed second part 83a7d98a32. Should be all fine now.

Committed second part 83a7d98a32. Should be all fine now.

Thomas Dinges added this to the 2.81 milestone 2023-02-08 16:46:59 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Error popups spawned from new FileBrowser are "swallowed" (e.g. Addon import/export errors) #69581