Outliner doesn't update text data-block list and crashes on unlinking text #69610

New Issue

Chris Tabron · 2019-09-07T09:43:07+02:00

Chris Tabron commented

2019-09-07 09:43:07 +02:00

Blender Version
Broken: version: 2.81 (sub 8), branch: master, commit date: 2019-09-06 22:44, hash: ed779333bb

Short description of error
After setting up my workspace layout for text editing, I set the outliner's display mode to "Blender File" and the filter ID type to "Text". And when I add an empty text data-block in the text editor, the list of text data-blocks in the outliner doesn't update instantly unless you hover anywhere on it's header. And when I tried to unlink the text data-block, it just crashes instantly.

Exact steps for others to reproduce the error
2019-09-07 02-51-52.flv

In the outliner, set the display mode to "Blender file".
Set the filter I.D. type to "Text".
Click on the "New" button in the header of the text editor to open an empty text block.
Hover over any part of the outliner's header.
Click on the "Unlink" button to unlink the empty text block. [on the Text Editor header]
Outliner text filter not updating list instantly and text file unlink crash.blend

**Blender Version** Broken: version: 2.81 (sub 8), branch: master, commit date: 2019-09-06 22:44, hash: `ed779333bb` **Short description of error** After setting up my workspace layout for text editing, I set the outliner's display mode to "Blender File" and the filter ID type to "Text". And when I add an empty text data-block in the text editor, the list of text data-blocks in the outliner doesn't update instantly unless you hover anywhere on it's header. And when I tried to unlink the text data-block, it just crashes instantly. **Exact steps for others to reproduce the error** [2019-09-07 02-51-52.flv](https://archive.blender.org/developer/F7721421/2019-09-07_02-51-52.flv) 1. In the outliner, set the display mode to "Blender file". 2. Set the filter I.D. type to "Text". 3. Click on the "New" button in the header of the text editor to open an empty text block. 4. Hover over any part of the outliner's header. 5. Click on the "Unlink" button to unlink the empty text block. [on the Text Editor header] [Outliner text filter not updating list instantly and text file unlink crash.blend](https://archive.blender.org/developer/F7721432/Outliner_text_filter_not_updating_list_instantly_and_text_file_unlink_crash.blend)

Chris Tabron commented

2019-09-07 09:43:07 +02:00

Added subscriber: @tetrapixel

Chris Tabron changed title from ~~Outliner list doesn't update text data-block list and crashes instantly after unlinking blank text data-block~~ to Outliner doesn't update text data-block list and crashes instantly after unlinking blank text data-block

2019-09-07 09:44:56 +02:00

Dalai Felinto commented

2019-09-18 02:21:03 +02:00

Added subscribers: @natecraddock, @dfelinto

Dalai Felinto commented

2019-09-18 02:21:03 +02:00

Confirmed. It should be a straightforward fix, and in a way it is the same solution for both:

A notifier/message when creating the text ID.
Tag outliner to redraw/free when deleting the text ID.

For the records the crash is:

//source/blender/editors/space_outliner/outliner_draw.c:3101
3101        if (ELEM(tselem->type, 0, TSE_LAYER_COLLECTION) && ID_IS_LINKED(tselem->id)) {

@Zachman can I interest you into looking at this?

Confirmed. It should be a straightforward fix, and in a way it is the same solution for both: * A notifier/message when creating the text ID. * Tag outliner to redraw/free when deleting the text ID. For the records the crash is: ``` //source/blender/editors/space_outliner/outliner_draw.c:3101 3101 if (ELEM(tselem->type, 0, TSE_LAYER_COLLECTION) && ID_IS_LINKED(tselem->id)) { ``` @Zachman can I interest you into looking at this?

Dalai Felinto changed title from ~~Outliner doesn't update text data-block list and crashes instantly after unlinking blank text data-block~~ to Outliner doesn't update text data-block list and crashes on unlinking text

2019-09-18 02:23:01 +02:00

Nathan Craddock self-assigned this 2019-09-18 02:45:55 +02:00

Nathan Craddock commented

2019-09-18 02:45:55 +02:00

Yes, I will take a look.

blender-admin commented

2019-09-19 16:47:39 +02:00

This issue was referenced by 2480c9236f

This issue was referenced by 2480c9236fd43907b81053616b23c155970a9cca

Nathan Craddock commented

2019-09-19 17:14:52 +02:00

Changed status from 'Open' to: 'Resolved'

Nathan Craddock closed this issue

2019-09-19 17:14:52 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Outliner doesn't update text data-block list and crashes on unlinking text #69610