Transformation Gizmo crash when using in Grease Pencil Edit mode #69782

New Issue

B-Lee · 2019-09-12T09:53:43+02:00

B-Lee commented

2019-09-12 09:53:43 +02:00

Operating system: Microsoft Windows 10 Pro (Version 1903 Build 18362.356)
Graphics card: NVIDIA GeForce GTX 1080 (GeForce Game Ready Driver Version 436.30)

blender 2.81 Alpha, Hash: 1e375ab5a104-windows64, Date: 2019-09-11

Short description of error
Blender crashes in Edit Mode when using tools on toolbar to edit a new added grease pencil stroke. (Tools are highlighted in the reference image.)

GPtools_Crash.mp4

GPtools_Crash.blend

Operating system: Microsoft Windows 10 Pro (Version 1903 Build 18362.356) Graphics card: NVIDIA GeForce GTX 1080 (GeForce Game Ready Driver Version 436.30) blender 2.81 Alpha, Hash: 1e375ab5a104-windows64, Date: 2019-09-11 **Short description of error** Blender crashes in Edit Mode when using tools on toolbar to edit a new added grease pencil stroke. (Tools are highlighted in the reference image.) ![GPtools_Crash.jpg](https://archive.blender.org/developer/F7738594/GPtools_Crash.jpg) [GPtools_Crash.mp4](https://archive.blender.org/developer/F7738598/GPtools_Crash.mp4) [GPtools_Crash.blend](https://archive.blender.org/developer/F7738599/GPtools_Crash.blend)

B-Lee commented

2019-09-12 09:53:43 +02:00

Added subscriber: @toki46-3

Antonio Vazquez commented

2019-09-12 10:32:29 +02:00

Added subscribers: @ideasman42, @antoniov

Campbell Barton was assigned by Antonio Vazquez

2019-09-12 10:32:29 +02:00

Antonio Vazquez commented

2019-09-12 10:32:29 +02:00

I can reproduce it. The problem is the transform_generics.c in function recalcData_objects is checking the 'obedit' object and this is NULL for GPencil.

@ideasman42 Assign to you because I think you know this area. I could fix it using an if to check if NULL or if OB_GPENCIL and use real object, but I prefer you take a look. Let me know if I can help you

I can reproduce it. The problem is the `transform_generics.c` in function `recalcData_objects` is checking the 'obedit' object and this is NULL for GPencil. ![image.png](https://archive.blender.org/developer/F7738691/image.png) @ideasman42 Assign to you because I think you know this area. I could fix it using an if to check if NULL or if OB_GPENCIL and use real object, but I prefer you take a look. Let me know if I can help you

Antonio Vazquez commented

2019-09-12 10:47:29 +02:00

Proposed Fix:

diff --git a/source/blender/editors/transform/transform_generics.c b/source/blender/editors/transform/transform_generics.c
index e4d3c9abceb..e0875fc0ddb 100644
--- a/source/blender/editors/transform/transform_generics.c
+++ b/source/blender/editors/transform/transform_generics.c
@@ -1008,7 +1008,9 @@ static void recalcData_objects(TransInfo *t)
       }
       FOREACH_TRANS_DATA_CONTAINER (t, tc) {
         if (tc->data_len) {
-          DEG_id_tag_update(tc->obedit->data, 0); /* sets recalc flags */
+          if (tc->obedit) {
+            DEG_id_tag_update(tc->obedit->data, 0); /* sets recalc flags */
+          }
         }
       }
     }

Proposed Fix: ``` diff --git a/source/blender/editors/transform/transform_generics.c b/source/blender/editors/transform/transform_generics.c index e4d3c9abceb..e0875fc0ddb 100644 --- a/source/blender/editors/transform/transform_generics.c +++ b/source/blender/editors/transform/transform_generics.c @@ -1008,7 +1008,9 @@ static void recalcData_objects(TransInfo *t) } FOREACH_TRANS_DATA_CONTAINER (t, tc) { if (tc->data_len) { - DEG_id_tag_update(tc->obedit->data, 0); /* sets recalc flags */ + if (tc->obedit) { + DEG_id_tag_update(tc->obedit->data, 0); /* sets recalc flags */ + } } } } ```

Antonio Vazquez changed title from ~~Grease Pencil: Crash in Edit Mode when using tools on toolbar~~ to Transformation Gizmo crash when using in Grease Pencil Edit mode

2019-09-12 10:48:43 +02:00

Brecht Van Lommel commented

2019-09-12 11:14:03 +02:00

Added subscriber: @brecht