Adaptive displacement off-screen culling/dicing and camera shift. #69911

New Issue

Paul R · 2019-09-15T19:45:53+02:00

Paul R commented

2019-09-15 19:45:53 +02:00

System Information
Operating system: Suse Linux 15.0
Graphics card: NVidia GTX 560ti (official drivers)

Blender Version
Broken: 2.81 e2df789c48

Short description of error
Adjusting the camera's Shift X/Y values gives unexpected off-screen culling results and high memory use.

Exact steps for others to reproduce the error

note: a separate camera (Camera.001) is used to control the dicing as it better shows the issue, but the same applies with a single camera setup.

adaptive_displacement_camera_shift.blend

Open adaptive_displacement_camera_shift.blend
Render and note that the dicing is centred on the plane as expected
If Camera.001 is moved along X direction, the culling position changes as expected
But if the Camera.001 Shift X value is set to 0.800 - instead of the subdivided area shifting to the right, it expands out along the X axis. Ram usage is also high.

Examples:

Camera.001 in original position (peak memory: 69.19M):
Camera.001 moved along X axis to 4m units (peak memory: 36.03M):
Camera.001 in original position but camera Shift X value set to 0.800 (peak memory: 137.00M):

Expected result for 3. would be for similar culling and memory usage as 2.

So it isn't currently possible to split a large render into smaller sections as a way to reduce RAM/VRAM usage, then stitch externally.

**System Information** Operating system: Suse Linux 15.0 Graphics card: NVidia GTX 560ti (official drivers) **Blender Version** Broken: 2.81 e2df789c4800 **Short description of error** Adjusting the camera's Shift X/Y values gives unexpected off-screen culling results and high memory use. **Exact steps for others to reproduce the error** note: a separate camera (Camera.001) is used to control the dicing as it better shows the issue, but the same applies with a single camera setup. [adaptive_displacement_camera_shift.blend](https://archive.blender.org/developer/F7748826/adaptive_displacement_camera_shift.blend) - Open adaptive_displacement_camera_shift.blend - Render and note that the dicing is centred on the plane as expected - If Camera.001 is moved along X direction, the culling position changes as expected - But if the Camera.001 Shift X value is set to 0.800 - instead of the subdivided area shifting to the right, it expands out along the X axis. Ram usage is also high. Examples: 1. Camera.001 in original position (peak memory: 69.19M): ![adaptive_displacement_offscreen_culling_expected_centre.jpg](https://archive.blender.org/developer/F7748829/adaptive_displacement_offscreen_culling_expected_centre.jpg) 2. Camera.001 moved along X axis to 4m units (peak memory: 36.03M): ![adaptive_displacement_offscreen_culling_move_x.jpg](https://archive.blender.org/developer/F7748831/adaptive_displacement_offscreen_culling_move_x.jpg) 3. Camera.001 in original position but camera Shift X value set to 0.800 (peak memory: 137.00M): ![adaptive_displacement_offscreen_culling_actual_shift_x.jpg](https://archive.blender.org/developer/F7748833/adaptive_displacement_offscreen_culling_actual_shift_x.jpg) Expected result for 3. would be for similar culling and memory usage as 2. So it isn't currently possible to split a large render into smaller sections as a way to reduce RAM/VRAM usage, then stitch externally.

Paul R commented

2019-09-15 19:45:53 +02:00

Added subscriber: @intracube

blender-admin commented

2019-09-15 19:45:53 +02:00

#82024 was marked as duplicate of this issue

Germano Cavalcante commented

2019-09-30 15:48:25 +02:00

Added subscribers: @MaiLavelle, @mano-wii

Germano Cavalcante commented

2019-09-30 15:48:25 +02:00

@MaiLavelle, I'm not sure if this involves adaptive render subdvision, but can you take a look?

Philipp Oeser commented

2020-01-09 15:33:18 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-01-09 15:33:18 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-01-09 15:33:18 +01:00

Did some digging, but spending too much time here.

This seems to be somewhat reversed, so Shift X is being used, it expands as @intracube , to add: if it is negative it shrinks...

I see it being used in QuadDice::eval_projected (rastertoworld takes shift X into account eventually), but not sure if this has to do with it
transform_perspective(&params.camera->rastertoworld, P);

Will confirm for now and have a look again later...

Did some digging, but spending too much time here. This seems to be somewhat reversed, so `Shift X` is being used, it expands as @intracube , to add: if it is negative it shrinks... I see it being used in `QuadDice::eval_projected` (rastertoworld takes shift X into account eventually), but not sure if this has to do with it `transform_perspective(&params.camera->rastertoworld, P);` Will confirm for now and have a look again later...

Paul R commented

2020-01-17 18:34:57 +01:00

Thanks for taking a look.

Similarly to the above; positive Shift Y values grow the subdivision region, negative areas shrink it.

A related issue;
Changing Output->Dimensions->Aspect also gives unexpected results. Setting Y to positive values causes the region to grow on both dimensions, but the expected result would be to only expand on the X dimension:

Thanks for taking a look. Similarly to the above; positive `Shift Y` values grow the subdivision region, negative areas shrink it. A related issue; `Changing Output->Dimensions->Aspect` also gives unexpected results. Setting `Y` to positive values causes the region to grow on both dimensions, but the expected result would be to only expand on the `X` dimension: ![dimensions_aspect_Y_1_2_expected.jpg](https://archive.blender.org/developer/F8283447/dimensions_aspect_Y_1_2_expected.jpg)

Philipp Oeser changed title from ~~Adaptive displacement off-screen culling and camera shift.~~ to Adaptive displacement off-screen culling/dicing and camera shift.

2020-10-24 15:05:38 +02:00

Philipp Oeser commented

2020-10-24 15:06:04 +02:00

Added subscriber: @unwave

Philipp Oeser self-assigned this 2020-10-24 17:03:55 +02:00

blender-admin commented

2020-10-26 12:49:37 +01:00

This issue was referenced by blender/cycles@886c82e790

This issue was referenced by blender/cycles@886c82e790d4d3a1e80fee5827862e8f7e043f82

blender-admin commented

2020-10-26 12:49:37 +01:00

This issue was referenced by f76f48c3d3

This issue was referenced by f76f48c3d3eb3ac518fed158a0f17c7507604ca8

Philipp Oeser commented

2020-10-26 13:06:28 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2020-10-26 13:06:28 +01:00

Paul R commented

2022-10-06 08:02:24 +02:00

Hi, I missed the notification for this two years ago and just saw that it was resolved.

Have just checked and it now seems to be working as expected. Thanks for the patch!

Hi, I missed the notification for this two years ago and just saw that it was resolved. Have just checked and it now seems to be working as expected. Thanks for the patch!

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Adaptive displacement off-screen culling/dicing and camera shift. #69911