Moving nodes in the node editor stops after hotkey is lifted #70504

New Issue

Matthew Wiebe · 2019-10-04T05:16:39+02:00

Matthew Wiebe commented

2019-10-04 05:16:39 +02:00

Blender Version
Broken: 540eb2dc1e
Worked: 540eb2dc1e^

Short description of error

The behavior in the node editors has changed. Whereas before you could move a node with G > Confirm, now the user has to hold down the G key to move. Releasing G causes the translate operator to stop.

More details

Any hotkey that results in nodes in the node editor (both shader editor and compositor) moving with the mouse now stops the movement as soon as the keyboard key is lifted, as opposed to continuing to move until mousebutton1 is pressed (which is/was the behaviour elsewhere in blender and in the node editor in the past iirc).

Examples are obviously G but also Shift+D (nodes created by duplication stop moving as soon as the D key is released)
strangely Shift+A does not have this problem, any new nodes that are added (but not made by duplicating) continue to move with the mouse as expected.

This makes the node editors almost unuseable for users accustomed to using hotkeys

**Blender Version** Broken: 540eb2dc1e Worked: 540eb2dc1e^ **Short description of error** The behavior in the node editors has changed. Whereas before you could move a node with G > Confirm, now the user has to hold down the G key to move. Releasing G causes the translate operator to stop. **More details** Any hotkey that results in nodes in the node editor (both shader editor and compositor) moving with the mouse now stops the movement as soon as the keyboard key is lifted, as opposed to continuing to move until mousebutton1 is pressed (which is/was the behaviour elsewhere in blender and in the node editor in the past iirc). Examples are obviously G but also Shift+D (nodes created by duplication stop moving as soon as the D key is released) strangely Shift+A does *not* have this problem, any new nodes that are added (but not made by duplicating) continue to move with the mouse as expected. This makes the node editors almost unuseable for users accustomed to using hotkeys

Matthew Wiebe commented

2019-10-04 05:16:39 +02:00

Added subscriber: @cerebral

blender-admin commented

2019-10-04 05:16:39 +02:00

#70533 was marked as duplicate of this issue

blender-admin commented

2019-10-04 05:16:39 +02:00

#70518 was marked as duplicate of this issue

Philipp Oeser commented

2019-10-04 12:42:37 +02:00

Added subscribers: @brecht, @lichtwerk

Philipp Oeser commented

2019-10-04 12:42:37 +02:00

Caused by 540eb2dc1e, @brecht: for mouse tweak this seemed fine, but not for keyboard
How about this instead?
P1126: #70504 snippet



diff --git a/source/blender/editors/space_node/node_ops.c b/source/blender/editors/space_node/node_ops.c
index 5874b6d1cc0..11933ef0811 100644
--- a/source/blender/editors/space_node/node_ops.c
+++ b/source/blender/editors/space_node/node_ops.c
@@ -143,7 +143,6 @@ void ED_operatormacros_node(void)
                                     "Move nodes and attach to frame",
                                     OPTYPE_UNDO | OPTYPE_REGISTER);
   mot = WM_operatortype_macro_define(ot, "TRANSFORM_OT_translate");
-  RNA_boolean_set(mot->ptr, "release_confirm", true);
   WM_operatortype_macro_define(ot, "NODE_OT_attach");
   WM_operatortype_macro_define(ot, "NODE_OT_insert_offset");
 
@@ -153,7 +152,6 @@ void ED_operatormacros_node(void)
                                     "Move nodes and attach to frame",
                                     OPTYPE_UNDO | OPTYPE_REGISTER);
   mot = WM_operatortype_macro_define(ot, "TRANSFORM_OT_translate");
-  RNA_boolean_set(mot->ptr, "release_confirm", true);
   RNA_boolean_set(mot->ptr, "remove_on_cancel", true);
   WM_operatortype_macro_define(ot, "NODE_OT_attach");
   WM_operatortype_macro_define(ot, "NODE_OT_insert_offset");
diff --git a/source/blender/editors/transform/transform_generics.c b/source/blender/editors/transform/transform_generics.c
index 083b5b94c48..2f77b0453a4 100644
--- a/source/blender/editors/transform/transform_generics.c
+++ b/source/blender/editors/transform/transform_generics.c
@@ -1707,7 +1707,7 @@ void initTransInfo(bContext *C, TransInfo *t, wmOperator *op, const wmEvent *eve
     }
   }
   else {
-    if (ISMOUSE(t->launch_event) && (U.flag & USER_RELEASECONFIRM)) {
+    if (ISMOUSE(t->launch_event) && ((U.flag & USER_RELEASECONFIRM) || (t->spacetype == SPACE_NODE))) {
       /* Global "release confirm" on mouse bindings */
       t->flag |= T_RELEASE_CONFIRM;
     }

Caused by 540eb2dc1e, @brecht: for mouse tweak this seemed fine, but not for keyboard How about this instead? [P1126: #70504 snippet](https://archive.blender.org/developer/P1126.txt) ``` diff --git a/source/blender/editors/space_node/node_ops.c b/source/blender/editors/space_node/node_ops.c index 5874b6d1cc0..11933ef0811 100644 --- a/source/blender/editors/space_node/node_ops.c +++ b/source/blender/editors/space_node/node_ops.c @@ -143,7 +143,6 @@ void ED_operatormacros_node(void) "Move nodes and attach to frame", OPTYPE_UNDO | OPTYPE_REGISTER); mot = WM_operatortype_macro_define(ot, "TRANSFORM_OT_translate"); - RNA_boolean_set(mot->ptr, "release_confirm", true); WM_operatortype_macro_define(ot, "NODE_OT_attach"); WM_operatortype_macro_define(ot, "NODE_OT_insert_offset"); @@ -153,7 +152,6 @@ void ED_operatormacros_node(void) "Move nodes and attach to frame", OPTYPE_UNDO | OPTYPE_REGISTER); mot = WM_operatortype_macro_define(ot, "TRANSFORM_OT_translate"); - RNA_boolean_set(mot->ptr, "release_confirm", true); RNA_boolean_set(mot->ptr, "remove_on_cancel", true); WM_operatortype_macro_define(ot, "NODE_OT_attach"); WM_operatortype_macro_define(ot, "NODE_OT_insert_offset"); diff --git a/source/blender/editors/transform/transform_generics.c b/source/blender/editors/transform/transform_generics.c index 083b5b94c48..2f77b0453a4 100644 --- a/source/blender/editors/transform/transform_generics.c +++ b/source/blender/editors/transform/transform_generics.c @@ -1707,7 +1707,7 @@ void initTransInfo(bContext *C, TransInfo *t, wmOperator *op, const wmEvent *eve } } else { - if (ISMOUSE(t->launch_event) && (U.flag & USER_RELEASECONFIRM)) { + if (ISMOUSE(t->launch_event) && ((U.flag & USER_RELEASECONFIRM) || (t->spacetype == SPACE_NODE))) { /* Global "release confirm" on mouse bindings */ t->flag |= T_RELEASE_CONFIRM; } ```

Philipp Oeser commented

2019-10-04 15:03:38 +02:00

Added subscribers: @JasonvanGumster, @dfelinto

Brecht Van Lommel was assigned by Dalai Felinto

2019-10-04 15:04:52 +02:00

Brecht Van Lommel commented

2019-10-04 15:16:31 +02:00

@lichtwerk you can commit that. I tried to see if there is a better solution but couldn't find a good one, macros really should have some way to pass along operator properties.