View -> Lock Time to Other Windows does not maintain scale when CTRL+TAB between two animation editor modes. #70889

New Issue

Jer Bot · 2019-10-17T08:17:51+02:00

Jer Bot commented

2019-10-17 08:17:51 +02:00

System Information
Operating system: Manjaro Linux
Graphics card: nVidia

Blender Version
Broken: (example: 2.80, edbf15d3c0, master, 2018-11-28, as found on the splash screen)
Worked: (optional)

Short description of error
View -> Lock Time to Other Windows does not maintain scale when CTRL+TAB between two animation editor modes.

Exact steps for others to reproduce the error
Expand open the Timeline editor, now adjust the horizontal scale of the view (squeeze or expand), then Ctrl+TAB to swith to Graph Editor mode. Notice the scale does not stay in sych as it does when they are separate windows.

**System Information** Operating system: Manjaro Linux Graphics card: nVidia **Blender Version** Broken: (example: 2.80, edbf15d3c044, master, 2018-11-28, as found on the splash screen) Worked: (optional) **Short description of error** View -> Lock Time to Other Windows does not maintain scale when CTRL+TAB between two animation editor modes. **Exact steps for others to reproduce the error** Expand open the Timeline editor, now adjust the horizontal scale of the view (squeeze or expand), then Ctrl+TAB to swith to Graph Editor mode. Notice the scale does not stay in sych as it does when they are separate windows.

Jer Bot commented

2019-10-17 08:17:51 +02:00

Added subscriber: @JerBot

Fin O'Riordan commented

2019-10-17 09:23:10 +02:00

Added subscriber: @FinbarrORiordan

Philipp Oeser commented

2020-01-14 15:16:49 +01:00

Added subscribers: @dr.sybren, @lichtwerk

Philipp Oeser commented

2020-01-14 15:16:49 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-01-14 15:16:49 +01:00

Can confirm the behavior.

This is on the edge of being a bug [ or a feature request / known limitation -- since that option doesnt promise to lock time to the same window, only others ;) ] however, but will confirm for now...

Quickly tried something stupid as:
P1211: T72732_snippet



diff --git a/source/blender/makesrna/intern/rna_screen.c b/source/blender/makesrna/intern/rna_screen.c
index 1637f8cfed5..22093c52752 100644
--- a/source/blender/makesrna/intern/rna_screen.c
+++ b/source/blender/makesrna/intern/rna_screen.c
@@ -145,6 +145,11 @@ static void rna_Area_type_set(PointerRNA *ptr, int value)
 
   ScrArea *sa = (ScrArea *)ptr->data;
   sa->butspacetype = value;
+
+  if (ELEM(sa->spacetype, SPACE_GRAPH, SPACE_ACTION)) {
+    ARegion *ar = BKE_area_find_region_type(sa, RGN_TYPE_WINDOW);
+    UI_view2d_sync(NULL, sa, &ar->v2d, V2D_LOCK_COPY);
+  }
 }
 
 static void rna_Area_type_update(bContext *C, PointerRNA *ptr)

but needs more work (or some completely different solution)

@dr.sybren: know limitation?

Can confirm the behavior. This is on the edge of being a bug [ or a feature request / known limitation -- since that option doesnt promise to lock time to the **same** window, only **others** ;) ] however, but will confirm for now... Quickly tried something stupid as: [P1211: T72732_snippet](https://archive.blender.org/developer/P1211.txt) ``` diff --git a/source/blender/makesrna/intern/rna_screen.c b/source/blender/makesrna/intern/rna_screen.c index 1637f8cfed5..22093c52752 100644 --- a/source/blender/makesrna/intern/rna_screen.c +++ b/source/blender/makesrna/intern/rna_screen.c @@ -145,6 +145,11 @@ static void rna_Area_type_set(PointerRNA *ptr, int value) ScrArea *sa = (ScrArea *)ptr->data; sa->butspacetype = value; + + if (ELEM(sa->spacetype, SPACE_GRAPH, SPACE_ACTION)) { + ARegion *ar = BKE_area_find_region_type(sa, RGN_TYPE_WINDOW); + UI_view2d_sync(NULL, sa, &ar->v2d, V2D_LOCK_COPY); + } } static void rna_Area_type_update(bContext *C, PointerRNA *ptr) ``` but needs more work (or some completely different solution) @dr.sybren: know limitation?

Sybren A. Stüvel commented

2020-01-14 15:41:48 +01:00

Changed status from 'Confirmed' to: 'Archived'

Sybren A. Stüvel closed this issue

2020-01-14 15:41:48 +01:00

Sybren A. Stüvel self-assigned this 2020-01-14 15:41:48 +01:00

Sybren A. Stüvel commented

2020-01-14 15:41:48 +01:00

Yeah, this is not a bug; it would be if the option was called "lock view range when toggling editors", but it isn't. You could argue that ctrl+tab should maintain the range of the editor, but that's just not implemented.

Richard Antalik commented

2020-01-14 21:29:18 +01:00

Added subscriber: @iss

Richard Antalik commented

2020-01-14 21:29:18 +01:00

Changed status from 'Archived' to: 'Confirmed'

Richard Antalik reopened this issue

2020-01-14 21:29:18 +01:00

Richard Antalik commented

2020-01-14 21:29:18 +01:00

Manual says:

Lock Time to Other Windows
It synchronizes the horizontal panning and scale of the current editor with the other editors (Graph, Dope Sheet, NLA) when this option is set. That way you always have these editors showing >an identical part of the time you work on.

https://docs.blender.org/manual/en/latest/editors/timeline.html#view-menu

Manual says: >Lock Time to Other Windows >It synchronizes the horizontal panning and scale of the current editor with the other editors (Graph, Dope Sheet, NLA) when this option is set. That way you always have these editors showing >an identical part of the time you work on. https://docs.blender.org/manual/en/latest/editors/timeline.html#view-menu

Jer Bot commented

2020-01-15 05:04:05 +01:00

Thank you all for looking into this. I see this as a powerful feature that is not present in other applications.

Sybren A. Stüvel removed their assignment 2020-01-17 14:36:48 +01:00

Jer Bot commented

2020-01-20 22:28:23 +01:00

Added subscribers: @richardangert1000, @mont29

Jer Bot commented

2020-01-20 22:28:23 +01:00

@dr.sybren @mont29 @richardangert1000 @lichtwerk
Finally getting to spend more time in code (python) lately. So if any related bits to this issue are exposed to python, point me in a direction and I'll look there. I have ideas for related tools, which I'm hoping I can handle in python (i.e. making graph editor / dope sheet timeline scale presets).

Thanks again for the attention to this feature. I do believe it will be a great efficiency gain, and worth having on "the list".

Hope i can help.

@dr.sybren @mont29 @richardangert1000 @lichtwerk Finally getting to spend more time in code (python) lately. So if any related bits to this issue are exposed to python, point me in a direction and I'll look there. I have ideas for related tools, which I'm hoping I can handle in python (i.e. making graph editor / dope sheet timeline scale presets). Thanks again for the attention to this feature. I do believe it will be a great efficiency gain, and worth having on "the list". Hope i can help.

Sybren A. Stüvel commented

2020-01-21 15:40:46 +01:00

I'm not too familiar with the UI code, but from @lichtwerk's patch it looks like the syncing is all done in C.

Christoph Lendenfeld commented

2020-10-14 20:02:30 +02:00

Added subscriber: @ChrisLend

Christoph Lendenfeld self-assigned this 2020-10-14 20:02:30 +02:00

Christoph Lendenfeld commented

2020-10-14 20:02:30 +02:00

I'll have a look into this.
The option has changed to Sync Visible Range now.
When you have it set in the dope sheet and the graph editor, it still doesn't sync when toggling.
This is especially confusing when you have the timeline synced as well which then jumps between the dope sheet and the graph editor range.

How it should work:
Assuming that the flag is set in both, dope sheet and graph editor,
It should stay synced when you switch editors.

I'll have a look into this. The option has changed to `Sync Visible Range` now. When you have it set in the dope sheet and the graph editor, it still doesn't sync when toggling. This is especially confusing when you have the timeline synced as well which then jumps between the dope sheet and the graph editor range. How it should work: Assuming that the flag is set in both, dope sheet and graph editor, It should stay synced when you switch editors.

Christoph Lendenfeld removed their assignment 2020-10-25 23:38:25 +01:00

Christoph Lendenfeld commented

2020-10-25 23:38:25 +01:00

This turned out to be more complicated than I thought.

Here's what I found:

Syncing is done by calling void UI_view2d_sync(bScreen *screen, ScrArea *area, View2D *v2dcur, int flag) in view2d.c. For our purposes, area can be NULL
The best place to call this would be on void UI_view2d_region_reinit(View2D *v2d, short type, int winx, int winy) I think.

The problem is that the reinit function only has a View2D and I don't know how to get the bScreen from that.
I am not sure if it would be better to have some sort of static (or global, not quite sure how that works in C) variable that can be shared among all View2D instances

This turned out to be more complicated than I thought. Here's what I found: * Syncing is done by calling `void UI_view2d_sync(bScreen *screen, ScrArea *area, View2D *v2dcur, int flag)` in `view2d.c`. For our purposes, `area` can be NULL * The best place to call this would be on `void UI_view2d_region_reinit(View2D *v2d, short type, int winx, int winy)` I think. The problem is that the reinit function only has a `View2D` and I don't know how to get the `bScreen` from that. I am not sure if it would be better to have some sort of static (or global, not quite sure how that works in C) variable that can be shared among all `View2D` instances

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

View -> Lock Time to Other Windows does not maintain scale when CTRL+TAB between two animation editor modes. #70889