ID user decrement error for Collections with ID properties in ViewLayer #71250

New Issue

Lukas Stockner · 2019-10-31T19:18:58+01:00

Lukas Stockner commented

2019-10-31 19:18:58 +01:00

System Information
Operating system: Arch Linux

Blender Version
Broken: Current master (eb95e28635)

Short description of error
When adding a CollectionProperty of Elements that each reference a Collection to ViewLayers, the ID user counter on the Collections will underflow.

This was discovered as part of D3607.

Exact steps for others to reproduce the error

Run the attached script in Blender:
collection_idp_bug.py
Go into the View Layer panel
Add two Elements in the new subpanel
Set each one to point to some Collection
Switch between the two elements in the list
Observe errors in the console and/or triggered asserts in Debug mode

**System Information** Operating system: Arch Linux **Blender Version** Broken: Current master (eb95e28635) **Short description of error** When adding a CollectionProperty of Elements that each reference a Collection to ViewLayers, the ID user counter on the Collections will underflow. This was discovered as part of [D3607](https://archive.blender.org/developer/D3607). **Exact steps for others to reproduce the error** * Run the attached script in Blender: [collection_idp_bug.py](https://archive.blender.org/developer/F7881424/collection_idp_bug.py) * Go into the View Layer panel * Add two Elements in the new subpanel * Set each one to point to some Collection * Switch between the two elements in the list * Observe errors in the console and/or triggered asserts in Debug mode

Lukas Stockner commented

2019-10-31 19:18:58 +01:00

Added subscriber: @LukasStockner

Juan Gea commented

2019-10-31 20:57:49 +01:00

Added subscribers: @scorpion81, @juang3d

Juan Gea commented

2019-10-31 20:57:49 +01:00

(I will repeat the message here, but it's also in the light groups patch)

In our build the problem is not present, I tried the patch and I get not errors, I don't know if @scorpion81 did actually do a full patch or a workaround, but the problem is not present in our build, I'll leave here the links to the commits that solved the problem, if they are not the actual fix they may be a clue on where the problem is :)

ecf4d166da

64caa97f56

e32d31fbc2

(I will repeat the message here, but it's also in the light groups patch) In our build the problem is not present, I tried the patch and I get not errors, I don't know if @scorpion81 did actually do a full patch or a workaround, but the problem is not present in our build, I'll leave here the links to the commits that solved the problem, if they are not the actual fix they may be a clue on where the problem is :) https://github.com/juangea/boneMaster/commit/ecf4d166dad1bde1bfe67d861e7e17c4af21ec04 https://github.com/juangea/boneMaster/commit/64caa97f563aaf362af8387c8b544c2e6682d338 https://github.com/juangea/boneMaster/commit/e32d31fbc2bb83eb9eea6fd91d22d36b3d3803bf

Lukas Stockner commented

2019-11-03 17:11:38 +01:00

I can confirm that the first patch fixes the bug.

@scorpion81, could you submit that fix as a patch (so that you get proper credit)?

I can confirm that the first patch fixes the bug. @scorpion81, could you submit that fix as a patch (so that you get proper credit)?

Martin Felke commented

2019-11-03 19:15:33 +01:00

@LukasStockner Hi, feel free to commit the patch :) I am busy with other work and a bit out of the loop atm.