Left click on empty space inside file browser resets scrolling #72288

New Issue

Kolloom · 2019-12-09T06:10:25+01:00

Kolloom commented

2019-12-09 06:10:25 +01:00

System Information
Operating system: Windows-8.1-6.3.9600 64 Bits
Graphics card: Intel(R) HD Graphics 4400 Intel 4.3.0 - Build 10.18.14.5067

Blender Version
Broken: version: 2.82 (sub 3), branch: master, commit date: 2019-12-02 18:02, hash: 1e480840a2
Also confirmed in 2.81

2019-12-08 23-06-45.mp4

**System Information** Operating system: Windows-8.1-6.3.9600 64 Bits Graphics card: Intel(R) HD Graphics 4400 Intel 4.3.0 - Build 10.18.14.5067 **Blender Version** Broken: version: 2.82 (sub 3), branch: master, commit date: 2019-12-02 18:02, hash: `1e480840a2` Also confirmed in 2.81 [2019-12-08 23-06-45.mp4](https://archive.blender.org/developer/F8200909/2019-12-08_23-06-45.mp4)

Kolloom commented

2019-12-09 06:10:25 +01:00

Added subscriber: @Kolloom

Germano Cavalcante commented

2019-12-12 17:07:06 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2019-12-12 17:07:07 +01:00

I can confirm.
Analyzing the code, this does not seem to be intentional.
This change would fix the problem:

diff --git a/source/blender/editors/space_file/file_ops.c b/source/blender/editors/space_file/file_ops.c
index 77e6266b830..61eb4db8300 100644
--- a/source/blender/editors/space_file/file_ops.c
+++ b/source/blender/editors/space_file/file_ops.c
@@ -322,7 +322,7 @@ static FileSelect file_select(
   if (select != FILE_SEL_ADD && !file_is_any_selected(sfile->files)) {
     sfile->params->active_file = -1;
   }
-  else {
+  else if (sel.last >= 0) {
     ARegion *ar = CTX_wm_region(C);
     const FileLayout *layout = ED_fileselect_get_layout(sfile, ar);

I can confirm. Analyzing the code, this does not seem to be intentional. This change would fix the problem: ``` diff --git a/source/blender/editors/space_file/file_ops.c b/source/blender/editors/space_file/file_ops.c index 77e6266b830..61eb4db8300 100644 --- a/source/blender/editors/space_file/file_ops.c +++ b/source/blender/editors/space_file/file_ops.c @@ -322,7 +322,7 @@ static FileSelect file_select( if (select != FILE_SEL_ADD && !file_is_any_selected(sfile->files)) { sfile->params->active_file = -1; } - else { + else if (sel.last >= 0) { ARegion *ar = CTX_wm_region(C); const FileLayout *layout = ED_fileselect_get_layout(sfile, ar); ```

blender-admin commented

2020-01-08 16:45:09 +01:00

This issue was referenced by f1516e007d

This issue was referenced by f1516e007d9c9f72218c3256eaa1b478a6c25052

Julian Eisel commented

2020-01-08 16:48:23 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2020-01-08 16:48:23 +01:00

Julian Eisel self-assigned this 2020-01-08 16:48:23 +01:00

Julian Eisel commented

2020-01-08 16:48:59 +01:00

Thanks @mano-wii, committed your fix.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Left click on empty space inside file browser resets scrolling #72288