Crash when drag & drop Color in the Image Editor #72440

New Issue

CobraA · 2019-12-14T06:20:24+01:00

CobraA commented

2019-12-14 06:20:24 +01:00

System Information
Windows 10 64 Bits.
Graphics card GeForce GTX 1080 Ti.

Blender Version
Broken: version: 2.82.5 hash:38ad1c4d339d
Worked: 2.81

Short description of error
Color Drop on the image leads to a crash.
Exact steps for others to reproduce the error

Create a new Image in the Editor.
Drag & Drop Color from the Color picker onto the Canvas like in the image below.

{F8218463 size = full}

**System Information** Windows 10 64 Bits. Graphics card GeForce GTX 1080 Ti. **Blender Version** Broken: version: 2.82.5 hash:38ad1c4d339d Worked: 2.81 **Short description of error** Color Drop on the image leads to a crash. **Exact steps for others to reproduce the error** - Create a new Image in the Editor. - Drag & Drop Color from the Color picker onto the Canvas like in the image below. {[F8218463](https://archive.blender.org/developer/F8218463/DD.jpg) size = full}

CobraA commented

2019-12-14 06:20:24 +01:00

Added subscriber: @CobraA

William Reynish commented

2019-12-14 10:32:52 +01:00

Added subscriber: @WilliamReynish

William Reynish commented

2019-12-14 10:32:52 +01:00

I cannot reproduce the issue here. Dropping the color appears to work normally.

Stanislav Blinov commented

2019-12-15 17:26:22 +01:00

Added subscriber: @Stan_Pancakes

Stanislav Blinov commented

2019-12-15 17:26:22 +01:00

I'm able to reproduce the crash with current master. In a debug build, assertion is triggered:

BLI_assert failed: source/blender/blenkernel/intern/undo_system.c:457, BKE_undosys_step_push_init_with_type(), at 'ustack->step_init == ((void *)0)'

I'm able to reproduce the crash with current master. In a debug build, assertion is triggered: ``` BLI_assert failed: source/blender/blenkernel/intern/undo_system.c:457, BKE_undosys_step_push_init_with_type(), at 'ustack->step_init == ((void *)0)' ```

Philipp Oeser commented

2019-12-16 09:41:45 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-12-16 09:41:45 +01:00

Can confirm, checking...

Philipp Oeser commented

2019-12-16 10:54:52 +01:00

Looks like this is also caused by c30d6571bb

paint_2d_bucket_fill is called with NULL ImagePaintState from ED_imapaint_bucket_fill...

1  paint_2d_transform_mouse  paint_image_2d.c  1565 0x3a099ad 
2  paint_2d_bucket_fill      paint_image_2d.c  1904 0x3a0aae0 
3  ED_imapaint_bucket_fill   paint_image.c     1315 0x3a03ef1 
4  drop_color_invoke         interface_ops.c   1754 0x3b67ae6 
5  wm_operator_invoke        wm_event_system.c 1441 0x2ffbd68 
6  wm_operator_call_internal wm_event_system.c 1688 0x2ffc66b 
7  wm_handlers_do_intern     wm_event_system.c 2773 0x2fff287 
8  wm_handlers_do            wm_event_system.c 2993 0x2fffdb1 
9  wm_event_do_handlers      wm_event_system.c 3480 0x3001405 
10 WM_main                   wm.c              417  0x2ff50c9 
11 main                      creator.c         496  0x2d22f56

Note there is another assert lurking around [which has been there for quite some time though and is more or less unrelated], namely:

BLI_assert failed: /blender/source/blender/blenkernel/intern/undo_system.c:457, BKE_undosys_step_push_init_with_type(), at 'ustack->step_init == ((void *)0)'

ustack->step_init is not NULL (already has Drop Color, wants to do for ED_imapaint_bucket_fill as well, so seems like two undo pushes where only one is allowed?)

1  raise                                                       0x7ffff1ae4e35 
2  abort                                                       0x7ffff1acf895 
3  BKE_undosys_step_push_init_with_type undo_system.c     457  0x3f9fdeb      
4  image_undo_push_begin                image_undo.c      1017 0x3e95f0f      
5  ED_image_undo_push_begin             image_undo.c      1026 0x3e95fa9      
6  ED_imapaint_bucket_fill              paint_image.c     1308 0x3b5edcf      
7  drop_color_invoke                    interface_ops.c   1700 0x3d67d3c      
8  wm_operator_invoke                   wm_event_system.c 1441 0x32e9559      
9  wm_operator_call_internal            wm_event_system.c 1688 0x32e9e5c      
10 wm_handlers_do_intern                wm_event_system.c 2773 0x32eca78      
11 wm_handlers_do                       wm_event_system.c 2993 0x32ed5a2      
12 wm_event_do_handlers                 wm_event_system.c 3480 0x32eebf6      
13 WM_main                              wm.c              417  0x32e1ba2      
14 main                                 creator.c         496  0x2d17ef6

Looks like this is also caused by c30d6571bb `paint_2d_bucket_fill` is called with NULL `ImagePaintState` from `ED_imapaint_bucket_fill`... ``` 1 paint_2d_transform_mouse paint_image_2d.c 1565 0x3a099ad 2 paint_2d_bucket_fill paint_image_2d.c 1904 0x3a0aae0 3 ED_imapaint_bucket_fill paint_image.c 1315 0x3a03ef1 4 drop_color_invoke interface_ops.c 1754 0x3b67ae6 5 wm_operator_invoke wm_event_system.c 1441 0x2ffbd68 6 wm_operator_call_internal wm_event_system.c 1688 0x2ffc66b 7 wm_handlers_do_intern wm_event_system.c 2773 0x2fff287 8 wm_handlers_do wm_event_system.c 2993 0x2fffdb1 9 wm_event_do_handlers wm_event_system.c 3480 0x3001405 10 WM_main wm.c 417 0x2ff50c9 11 main creator.c 496 0x2d22f56 ``` ---- ---- Note there is another assert lurking around [which has been there for quite some time though and is more or less unrelated], namely: `BLI_assert failed: /blender/source/blender/blenkernel/intern/undo_system.c:457, BKE_undosys_step_push_init_with_type(), at 'ustack->step_init == ((void *)0)'` `ustack->step_init` is not NULL (already has `Drop Color`, wants to do for `ED_imapaint_bucket_fill` as well, so seems like two undo pushes where only one is allowed?) ``` 1 raise 0x7ffff1ae4e35 2 abort 0x7ffff1acf895 3 BKE_undosys_step_push_init_with_type undo_system.c 457 0x3f9fdeb 4 image_undo_push_begin image_undo.c 1017 0x3e95f0f 5 ED_image_undo_push_begin image_undo.c 1026 0x3e95fa9 6 ED_imapaint_bucket_fill paint_image.c 1308 0x3b5edcf 7 drop_color_invoke interface_ops.c 1700 0x3d67d3c 8 wm_operator_invoke wm_event_system.c 1441 0x32e9559 9 wm_operator_call_internal wm_event_system.c 1688 0x32e9e5c 10 wm_handlers_do_intern wm_event_system.c 2773 0x32eca78 11 wm_handlers_do wm_event_system.c 2993 0x32ed5a2 12 wm_event_do_handlers wm_event_system.c 3480 0x32eebf6 13 WM_main wm.c 417 0x32e1ba2 14 main creator.c 496 0x2d17ef6 ```

Philipp Oeser commented

2019-12-16 11:03:40 +01:00

Added subscribers: @LukasStockner, @ideasman42