Wireframe overlay clipping issues #72547

New Issue

Julien Kaspar · 2019-12-18T15:33:18+01:00

Julien Kaspar commented

2019-12-18 15:33:18 +01:00

System Information
Operating system: Linux-4.15.0-72-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: Quadro GP100/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.50

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2019-12-18 12:31, hash: 409d3f4880
Worked: 2.81

Short description of error
The wireframe drawing as an overlay is not negatively influenced by the clip start in the viewport.
When in Orthographic view the clipping of the wireframes will stay consistent but may be not ideal.
In past versions of Blender the wireframe clipping stayed consistent no matter the clip end/start settings.

2019-12-18 15-25-37.mp4

**System Information** Operating system: Linux-4.15.0-72-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: Quadro GP100/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.50 **Blender Version** Broken: version: 2.82 (sub 6), branch: master, commit date: 2019-12-18 12:31, hash: `409d3f4880` Worked: 2.81 **Short description of error** The wireframe drawing as an overlay is not negatively influenced by the clip start in the viewport. When in Orthographic view the clipping of the wireframes will stay consistent but may be not ideal. In past versions of Blender the wireframe clipping stayed consistent no matter the clip end/start settings. [2019-12-18 15-25-37.mp4](https://archive.blender.org/developer/F8232184/2019-12-18_15-25-37.mp4)

Julien Kaspar commented

2019-12-18 15:33:18 +01:00

Added subscriber: @JulienKaspar

Jeroen Bakker was assigned by Julien Kaspar

2019-12-18 15:33:33 +01:00

Philipp Oeser commented

2019-12-19 10:40:11 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-12-19 10:40:11 +01:00

@Jeroen-Bakker: will you take care of this?

Jeroen Bakker commented

2019-12-20 14:30:56 +01:00

@lichtwerk, Yes I asked Julien to create this issue and assign it to me IRL.

Jose commented

2019-12-26 22:40:05 +01:00

Added subscriber: @Dogway

Jeroen Bakker commented

2019-12-30 12:49:14 +01:00

Added subscriber: @fclem

Jeroen Bakker commented

2019-12-30 12:49:14 +01:00

Seems like when in orthographic mode the gl_position.z is negative.
Perspective mode

Orthographic mode

Seems like the vertex shader is shifting the lines a bit to the camera. but in case for orthographic this shift moves the lines to the other side of the camera making render on top of other lines.
I suppose that the wireframe_vert.glsl needs to be adjusted for this.

P1198: #72547

diff --git a/source/blender/draw/engines/overlay/shaders/wireframe_vert.glsl b/source/blender/draw/engines/overlay/shaders/wireframe_vert.glsl
index 21f8bcf1791..a124721362c 100644
--- a/source/blender/draw/engines/overlay/shaders/wireframe_vert.glsl
+++ b/source/blender/draw/engines/overlay/shaders/wireframe_vert.glsl
@@ -120,7 +120,9 @@ void main()
   gl_Position.xy += wofs.xy * sizeViewportInv.xy * gl_Position.w;
 
   /* Push the vertex towards the camera. Helps a bit. */
-  gl_Position.z -= facing_ratio * curvature * 1e-4;
+  if (is_persp) {
+    gl_Position.z -= facing_ratio * curvature * 1e-4;
+  }
 
   /* Convert to screen position [0..sizeVp]. */
   edgeStart = ((gl_Position.xy / gl_Position.w) * 0.5 + 0.5) * sizeViewport.xy;

helps but we might want to do a better curvation. Assigning to @fclem if he has other ideas how to solve this?

Seems like when in orthographic mode the gl_position.z is negative. Perspective mode ![image.png](https://archive.blender.org/developer/F8251709/image.png) Orthographic mode ![image.png](https://archive.blender.org/developer/F8251707/image.png) Seems like the vertex shader is shifting the lines a bit to the camera. but in case for orthographic this shift moves the lines to the other side of the camera making render on top of other lines. I suppose that the `wireframe_vert.glsl` needs to be adjusted for this. [P1198: #72547](https://archive.blender.org/developer/P1198.txt) ```diff diff --git a/source/blender/draw/engines/overlay/shaders/wireframe_vert.glsl b/source/blender/draw/engines/overlay/shaders/wireframe_vert.glsl index 21f8bcf1791..a124721362c 100644 --- a/source/blender/draw/engines/overlay/shaders/wireframe_vert.glsl +++ b/source/blender/draw/engines/overlay/shaders/wireframe_vert.glsl @@ -120,7 +120,9 @@ void main() gl_Position.xy += wofs.xy * sizeViewportInv.xy * gl_Position.w; /* Push the vertex towards the camera. Helps a bit. */ - gl_Position.z -= facing_ratio * curvature * 1e-4; + if (is_persp) { + gl_Position.z -= facing_ratio * curvature * 1e-4; + } /* Convert to screen position [0..sizeVp]. */ edgeStart = ((gl_Position.xy / gl_Position.w) * 0.5 + 0.5) * sizeViewport.xy; ``` helps but we might want to do a better curvation. Assigning to @fclem if he has other ideas how to solve this?

Jeroen Bakker removed their assignment 2019-12-30 12:49:29 +01:00

Clément Foucault was assigned by Jeroen Bakker

2019-12-30 12:49:29 +01:00

Jeroen Bakker commented

2019-12-30 12:49:29 +01:00

Added subscriber: @Jeroen-Bakker

blender-admin commented

2020-01-14 13:07:39 +01:00

This issue was referenced by fca069a705

This issue was referenced by fca069a705318f58aece433318556fb06c99e842

Clément Foucault commented

2020-01-14 16:55:54 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Clément Foucault closed this issue

2020-01-14 16:55:54 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Wireframe overlay clipping issues #72547