Moving Animation Markers no longer allows snapping #72682

New Issue

Aaron Carlisle · 2019-12-25T03:12:45+01:00

Aaron Carlisle commented

2019-12-25 03:12:45 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.66

Blender Version
Broken: version: 2.82 (sub 5), branch: master, commit date: 2019-12-13 14:31, hash: 38ad1c4d33
Worked: 2.79

Short description of error
In 2.79b you can move markers in second increments by holding ctrl while moving, in Blender 2.8 it is no longer possible to do this.

This is described in the manual here: https://docs.blender.org/manual/en/latest/animation/markers.html#move-marker

Exact steps for others to reproduce the error

Select marker
hit G
hold control while moving
repeat this for both 2.79 and 2.82

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce RTX 2070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.66 **Blender Version** Broken: version: 2.82 (sub 5), branch: master, commit date: 2019-12-13 14:31, hash: `38ad1c4d33` Worked: 2.79 **Short description of error** In 2.79b you can move markers in second increments by holding ctrl while moving, in Blender 2.8 it is no longer possible to do this. This is described in the manual here: https://docs.blender.org/manual/en/latest/animation/markers.html#move-marker **Exact steps for others to reproduce the error** - Select marker - hit G - hold control while moving - repeat this for both 2.79 and 2.82

Aaron Carlisle commented

2019-12-25 03:12:45 +01:00

Added subscriber: @Blendify

Germano Cavalcante commented

2019-12-27 15:49:23 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2019-12-27 15:49:23 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2019-12-27 15:49:23 +01:00

I can confirm.
But it's strange, I looked at the code history and couldn't find any commits related to this change.

I can confirm. But it's strange, I looked at the code history and couldn't find any commits related to this change.

Jacques Lucke commented

2019-12-28 14:51:49 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-12-28 14:51:49 +01:00

This has been (accidentally?) removed in 5374865523.
See the third change in anim_markers.c in that commit.

Aren't markers only used in editors that have time on the x axis? Under that assumption we could just change
apply_keyb_grid(event->shift, event->ctrl, &fac, 0.0, 1.0, 0.1, 0 /*was: U.flag & USER_AUTOGRABGRID*/);
to
apply_keyb_grid(event->shift, event->ctrl, &fac, 0.0, FPS, 0.1 * FPS, 0);.

This has been (accidentally?) removed in 5374865523. See the third change in `anim_markers.c` in that commit. Aren't markers only used in editors that have time on the x axis? Under that assumption we could just change `apply_keyb_grid(event->shift, event->ctrl, &fac, 0.0, 1.0, 0.1, 0 /*was: U.flag & USER_AUTOGRABGRID*/);` to `apply_keyb_grid(event->shift, event->ctrl, &fac, 0.0, FPS, 0.1 * FPS, 0);`.

Aaron Carlisle commented

2019-12-28 16:52:05 +01:00

That sounds like the appropriate solution. Good eye

blender-admin commented

2020-01-05 15:55:54 +01:00

This issue was referenced by 8df339438a

This issue was referenced by 8df339438a051ffb31384fa700900c50d63f9275

Jacques Lucke commented

2020-01-05 15:57:25 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2020-01-05 15:57:25 +01:00

Jacques Lucke self-assigned this 2020-01-05 15:57:25 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Moving Animation Markers no longer allows snapping #72682