Viewport Render doesn't render Grease Pencil Overlays, Shading #72862

New Issue

Bun ny · 2020-01-03T02:20:20+01:00

Bun ny commented

2020-01-03 02:20:20 +01:00

System Information
Operating system: Windows 7 x64
Graphics card: NVIDIA GeForce GTX 580

Blender Version
Broken: 2.82 a854840e76

Short description of error
Rendering with the Viewport Render operator doesn't render Overlays and Shading settings pertaining to Grease Pencil objects. Regardless of the Fade Layers overlay setting or the Color Type setting, Grease Pencil objects render as if no Overlay settings are active and with the Material color type.

Exact steps for others to reproduce the error
Open attached .blend, confirm the Fade Layers Overlay setting and Random Color Type shading settings are active, call Viewport Render Image operator, resulting image differs from Viewport.
viewport_render_bug.blend

**System Information** Operating system: Windows 7 x64 Graphics card: NVIDIA GeForce GTX 580 **Blender Version** Broken: 2.82 a854840e76ae **Short description of error** Rendering with the Viewport Render operator doesn't render Overlays and Shading settings pertaining to Grease Pencil objects. Regardless of the Fade Layers overlay setting or the Color Type setting, Grease Pencil objects render as if no Overlay settings are active and with the Material color type. **Exact steps for others to reproduce the error** Open attached .blend, confirm the Fade Layers Overlay setting and Random Color Type shading settings are active, call Viewport Render Image operator, resulting image differs from Viewport. [viewport_render_bug.blend](https://archive.blender.org/developer/F8257224/viewport_render_bug.blend)

Bun ny commented

2020-01-03 02:20:20 +01:00

Added subscriber: @bunny

Philipp Oeser commented

2020-01-03 13:37:23 +01:00

Added subscribers: @Jeroen-Bakker, @lichtwerk

Philipp Oeser commented

2020-01-03 13:37:23 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2020-01-03 13:37:23 +01:00

Can confirm the behavior, but I am unsure about the state of the Viewport Render operators (bpy.ops.render.opengl).

@Jeroen-Bakker: it may very well be that this is just a known limitation about these operators. Wouldnt these be removed/obsolete at some point with the workbench render engine anyways?
(btw. the workbench renderengine F12 lso doesnt respect the Random Color Type for Greasepencil objects...)

Can confirm the behavior, but I am unsure about the state of the Viewport Render operators (`bpy.ops.render.opengl`). @Jeroen-Bakker: it may very well be that this is just a known limitation about these operators. Wouldnt these be removed/obsolete at some point with the workbench render engine anyways? (btw. the workbench renderengine F12 lso doesnt respect the `Random` Color Type for Greasepencil objects...)

Antonio Vazquez commented

2020-01-03 16:30:36 +01:00

Added subscribers: @fclem, @antoniov

Antonio Vazquez commented

2020-01-03 16:30:36 +01:00

Actually, the render doesn't display any overlay in Grease Pencil.

As @fclem is doing a refactor of the drawing engine, we must wait to see how this will be handle, because some of the current overlays in grease pencil engine it will be moved to overlay engine.

Actually, the render doesn't display any overlay in Grease Pencil. As @fclem is doing a refactor of the drawing engine, we must wait to see how this will be handle, because some of the current overlays in grease pencil engine it will be moved to overlay engine.

Campbell Barton commented

2020-01-14 11:15:17 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2020-01-14 11:15:17 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Campbell Barton commented

2020-01-14 11:15:17 +01:00

Checked on this and replacing DRW_state_is_image_render for DRW_state_is_scene_render seems to make this work as expected.

diff --git a/source/blender/draw/engines/gpencil/gpencil_engine.c b/source/blender/draw/engines/gpencil/gpencil_engine.c
index a1a1f7cc389..f4baf2c7837 100644
--- a/source/blender/draw/engines/gpencil/gpencil_engine.c
+++ b/source/blender/draw/engines/gpencil/gpencil_engine.c
@@ -439,7 +439,7 @@ void GPENCIL_cache_init(void *vedata)
       stl->storage->is_main_onion = false;
     }
     /* save render state */
-    stl->storage->is_render = DRW_state_is_image_render();
+    stl->storage->is_render = DRW_state_is_scene_render();
     stl->storage->is_mat_preview = (bool)stl->storage->is_render &&
                                    STREQ(scene->id.name + 2, "preview");

Checked on this and replacing DRW_state_is_image_render for DRW_state_is_scene_render seems to make this work as expected. ``` diff --git a/source/blender/draw/engines/gpencil/gpencil_engine.c b/source/blender/draw/engines/gpencil/gpencil_engine.c index a1a1f7cc389..f4baf2c7837 100644 --- a/source/blender/draw/engines/gpencil/gpencil_engine.c +++ b/source/blender/draw/engines/gpencil/gpencil_engine.c @@ -439,7 +439,7 @@ void GPENCIL_cache_init(void *vedata) stl->storage->is_main_onion = false; } /* save render state */ - stl->storage->is_render = DRW_state_is_image_render(); + stl->storage->is_render = DRW_state_is_scene_render(); stl->storage->is_mat_preview = (bool)stl->storage->is_render && STREQ(scene->id.name + 2, "preview"); ```

Clément Foucault commented

2020-01-14 12:10:46 +01:00

I think it's safe to include this fix for 2.82 as the whole implementation has been rewritten for 2.83