Move Channels operator moves Grease Pencil Layers, causing keymap conflict #72897

Closed
opened 2020-01-04 13:35:41 +01:00 by Bun ny · 7 comments

System Information
Operating system: Windows 7 x64
Graphics card: NVIDIA GeForce GTX 580

Blender Version
Broken: 2.82 a854840e76

Short description of error
The Move Channels operator moves Grease Pencil layers, in reverse order and without updating the Layers panel in the Properties Editor. The dedicated Move Grease Pencil Layer operator works as expected. Since there isn't a way to assign different shortcuts dependent on the editing context, there's currently no way to assign PgUp and PgDn to both operators. It seems that if Move Channels didn't affect Grease Pencil layers, there would be no conflict assigning the same keys to both operators.

Exact steps for others to reproduce the error
Create Grease Pencil object, add multiple layers, use the Move Channels operator (PgUp, PgDn)

**System Information** Operating system: Windows 7 x64 Graphics card: NVIDIA GeForce GTX 580 **Blender Version** Broken: 2.82 a854840e76ae **Short description of error** The Move Channels operator moves Grease Pencil layers, in reverse order and without updating the Layers panel in the Properties Editor. The dedicated Move Grease Pencil Layer operator works as expected. Since there isn't a way to assign different shortcuts dependent on the editing context, there's currently no way to assign PgUp and PgDn to both operators. It seems that if Move Channels didn't affect Grease Pencil layers, there would be no conflict assigning the same keys to both operators. **Exact steps for others to reproduce the error** Create Grease Pencil object, add multiple layers, use the Move Channels operator (PgUp, PgDn)
Author

Added subscriber: @bunny

Added subscriber: @bunny

Added subscriber: @antoniov

Added subscriber: @antoniov

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'

I'm not sure what you mean, but in the last version there are buttons in the Dopesheet header to move UP/DW the layer.

image.png

Can you explain more about your problem,

Note: Grease Pencil Layers are not "real" channels, so maybe the problem is this operator must be hidden in GP mode.

I'm not sure what you mean, but in the last version there are buttons in the Dopesheet header to move UP/DW the layer. ![image.png](https://archive.blender.org/developer/F8259567/image.png) Can you explain more about your problem, Note: Grease Pencil Layers are not "real" channels, so maybe the problem is this operator must be hidden in GP mode.
Author

There's two operators that both move gpencil layers: the newer bpy.ops.gpencil.layer_move, which works perfectly (only moves gpencil layers), and the older operator bpy.ops.anim.channels_move, which is meant for animation channels but still moves gpencil layers since the 2.7 series (moves both animation channels and gpencil layers).

User expects that anim.channels_move should move only animation channels, and not gpencil layers.

Or, that anim.channels_move would move gpencil layers and update the layers panel in the Properties Editor exactly the same way as gpencil.layer_move does. Currently anim.channels_move(direction='UP') moves gpencil layer down, since gpencil layer order is reversed, and user has to move mouse cursor over to the properties editor to force the layers panel to update.

There's two operators that both move gpencil layers: the newer bpy.ops.gpencil.layer_move, which works perfectly (only moves gpencil layers), and the older operator bpy.ops.anim.channels_move, which is meant for animation channels but still moves gpencil layers since the 2.7 series (moves both animation channels and gpencil layers). User expects that anim.channels_move should move only animation channels, and not gpencil layers. Or, that anim.channels_move would move gpencil layers and update the layers panel in the Properties Editor exactly the same way as gpencil.layer_move does. Currently anim.channels_move(direction='UP') moves gpencil layer down, since gpencil layer order is reversed, and user has to move mouse cursor over to the properties editor to force the layers panel to update.

This issue was referenced by 5c66739b78

This issue was referenced by 5c66739b782e991034c872c4f7175093e98c9982

Changed status from 'Needs User Info' to: 'Resolved'

Changed status from 'Needs User Info' to: 'Resolved'
Antonio Vazquez self-assigned this 2020-01-04 22:02:52 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#72897
No description provided.