Bone Envelope and Bone Size tools appear to have switched functions #72903

New Issue

Sam Brubaker · 2020-01-04T22:09:41+01:00

Sam Brubaker commented

2020-01-04 22:09:41 +01:00

Version: 2.82 alpha (Jan. 3rd, a854...) Linux 64 bit. Bug also occurs in current stable 2.81a

This bug requires no example file to reproduce.

How to reproduce:

Create an armature object with "Envelope" as its display type
Enter edit mode and open the toolbar
Use the "Bone Size" tool on a bone
Use the "Envelope Size" tool on a bone

The Bone Size tool edits the envelope size, and the Envelope Size tool affects the bone endpoint radius! That can't be right!

Version: 2.82 alpha (Jan. 3rd, a854...) Linux 64 bit. Bug also occurs in current stable 2.81a This bug requires no example file to reproduce. How to reproduce: - Create an armature object with "Envelope" as its display type - Enter edit mode and open the toolbar - Use the "Bone Size" tool on a bone - Use the "Envelope Size" tool on a bone The Bone Size tool edits the envelope size, and the Envelope Size tool affects the bone endpoint radius! That can't be right!

Sam Brubaker commented

2020-01-04 22:09:41 +01:00

Added subscriber: @rocketman

Philipp Oeser commented

2020-01-06 12:23:25 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-01-06 12:23:25 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-01-06 12:23:25 +01:00

I would confirm this, checking...

Philipp Oeser commented

2020-01-06 12:45:03 +01:00

Well, might have to backflip on this; from the code-side this looks like intended behavior:

we have:

TFM_BONE_SIZE
TFM_BONE_ENVELOPE
TFM_BONE_ENVELOPE_DIST
TFM_BONESIZE really goes to TFM_BONE_ENVELOPE_DIST in initTransform()
check createTransArmatureVerts for TFM_BONE_ENVELOPE & TFM_BONE_ENVELOPE_DIST (TFM_BONE_ENVELOPE does the radius head/tail related stuff...)

Bit confused atm., needs further investigation...

Well, might have to backflip on this; from the code-side this looks like intended behavior: we have: - `TFM_BONE_SIZE` - `TFM_BONE_ENVELOPE` - `TFM_BONE_ENVELOPE_DIST` - `TFM_BONESIZE` really goes to `TFM_BONE_ENVELOPE_DIST` in `initTransform()` - check `createTransArmatureVerts` for `TFM_BONE_ENVELOPE` & `TFM_BONE_ENVELOPE_DIST` (`TFM_BONE_ENVELOPE` does the radius head/tail related stuff...) Bit confused atm., needs further investigation...

Philipp Oeser commented

2020-01-06 12:45:24 +01:00

This comment was removed by @lichtwerk

*This comment was removed by @lichtwerk*

Philipp Oeser commented

2020-01-06 12:45:56 +01:00

Changed status from 'Confirmed' to: 'Needs Triage'

Philipp Oeser commented

2020-01-06 13:38:38 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2020-01-06 13:38:38 +01:00

Added subscribers: @WilliamReynish, @dr.sybren

Philipp Oeser commented

2020-01-06 13:38:38 +01:00

So thinking about this further, the naming is not even that misleading, the overall Bone Size tool [can only be changed on the whole bone, not individually for head/tail] might be understood as additional envelope distance, whereas the Bone Envelope tool itself can influence head/tail individually and also changes envelope of course [just not the additional distance].

Might be a bit confusing, both icons are unfortunate in my opinion:

the Bone Size tool is only relevant to BBones (which only uses its size for viewport display afaict) and Envelopes yet displays as octahedral?
the icon for the Bone Envelope tool seems to have an emphasis on the drawn envelope, almost suggesting it is only there for altering the additional distance whereas its main purpose is altering head/tail radii...

Not sure what to do with this report...

@WilliamReynish
@dr.sybren

So thinking about this further, the naming is not even that misleading, the overall `Bone Size` tool [can only be changed on the whole bone, not individually for head/tail] might be understood as additional envelope distance, whereas the `Bone Envelope` tool itself can influence head/tail individually and also changes envelope of course [just not the additional distance]. Might be a bit confusing, both icons are unfortunate in my opinion: - the Bone Size tool is only relevant to BBones (which only uses its size for viewport display afaict) and Envelopes yet displays as octahedral? - the icon for the Bone Envelope tool seems to have an emphasis on the drawn envelope, almost suggesting it is only there for altering the additional distance whereas its main purpose is altering head/tail radii... Not sure what to do with this report... @WilliamReynish @dr.sybren

Sam Brubaker commented

2020-01-06 20:24:43 +01:00

@lichtwerk please repeat the steps with the transform side panel visible (N). You will notice that the tool which is called "Bone Envelope" does not alter the bone's envelope distance value at all. It only effects the radius size of the bone's head and/or tail. Likewise, the tool which is called "Bone Size" affects only the envelope distance, and not the radius (size) of anything. It's backwards.

Sam Brubaker commented

2020-01-06 20:33:21 +01:00

Wait, I see now that you have not misunderstood anything. But I still don't think this is a matter of confusing names or icons. The tool's intended functions are quite clear already- they're just switched! One simply does what the other ought to do!

EDIT: Okay NOW I see what you mean about Bbones. In this display mode, the Bone Size tool stops affecting the evnelope size, and instead affects the viewport display size.

Seems like there are, in fact, THREE different functions, split between TWO available tools in ONE toolbar slot, and they're all wrong. Thank you so much for looking into this issue. I will now go stick my head the toilet

Wait, I see now that you have not misunderstood anything. But I still don't think this is a matter of confusing names or icons. The tool's intended functions are quite clear already- they're just switched! One simply does what the other ought to do! EDIT: Okay NOW I see what you mean about Bbones. In this display mode, the Bone Size tool stops affecting the evnelope size, and instead affects the viewport display size. Seems like there are, in fact, THREE different functions, split between TWO available tools in ONE toolbar slot, and they're all wrong. Thank you so much for looking into this issue. I will now go stick my head the toilet

William Reynish commented

2020-01-06 21:01:45 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Campbell Barton was assigned by William Reynish

2020-01-06 21:01:45 +01:00

William Reynish commented

2020-01-06 21:01:45 +01:00

Added subscriber: @ideasman42

William Reynish commented

2020-01-06 21:01:45 +01:00

This is clearly a bug. They indeed are swapped. I had a brief look in the keymap and the tool definition, but it seems to be set correct there, so the issue must be somewhere deeper.

Assigning to @ideasman42 (feel free to re-assign as you wish).

This is clearly a bug. They indeed are swapped. I had a brief look in the keymap and the tool definition, but it seems to be set correct there, so the issue must be somewhere deeper. Assigning to @ideasman42 (feel free to re-assign as you wish).

blender-admin commented

2020-02-27 22:28:34 +01:00

This issue was referenced by e66e21e58d

This issue was referenced by e66e21e58d29e3b62b8bad28d567948619b7a5ba

blender-admin commented

2020-02-27 22:28:34 +01:00

This issue was referenced by dd2cdd436f

This issue was referenced by dd2cdd436f8cdcf946c4e803a3cab89a3d17c841

Campbell Barton commented

2020-02-27 23:19:33 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2020-02-27 23:19:33 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Bone Envelope and Bone Size tools appear to have switched functions #72903