[Mantaflow] FLIP particles not visible #72971

New Issue

Pavel Blend · 2020-01-08T14:28:13+01:00

Pavel Blend commented

2020-01-08 14:28:13 +01:00

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: AMD Radeon HD 7560D ATI Technologies Inc. 4.5.13417 Core Profile Context 15.301.1901.0

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-01-06 20:54, hash: 3a35301fd1
Worked: (optional)

Short description of error
If you bake any liquid, after baking FLIP particles will not be visible in the 3D window. The checkmark Liquid is set. For the FLIP particles to appear, you need to click on the Liquid checkmark (the checkmark will not change its state). After these actions, particles will appear.

Exact steps for others to reproduce the error
Reproduced in any scene.

Default cube: Physics > Fluid > Type: Domain; Domain Type: Liquid
Observe that - [x] Liquid appears as checked
Observe that, under Particles, there is no "FLIP Particles" system
Observe that checking - [x] Liquid manually doesn't go to an "off" state but stays on a "on" state; it also triggers the creation of a particle system

**System Information** Operating system: Windows-7-6.1.7601-SP1 64 Bits Graphics card: AMD Radeon HD 7560D ATI Technologies Inc. 4.5.13417 Core Profile Context 15.301.1901.0 **Blender Version** Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-01-06 20:54, hash: `3a35301fd1` Worked: (optional) **Short description of error** If you bake any liquid, after baking FLIP particles will not be visible in the 3D window. The checkmark Liquid is set. For the FLIP particles to appear, you need to click on the Liquid checkmark (the checkmark will not change its state). After these actions, particles will appear. **Exact steps for others to reproduce the error** Reproduced in any scene. - Default cube: Physics > Fluid > Type: Domain; Domain Type: Liquid - Observe that `- [x] Liquid` appears as checked - Observe that, under Particles, there is no "FLIP Particles" system - Observe that checking `- [x] Liquid` manually doesn't go to an "off" state but stays on a "on" state; it also triggers the creation of a particle system

Pavel Blend commented

2020-01-08 14:28:13 +01:00

Added subscriber: @Pavel_Blend

blender-admin commented

2020-01-08 14:28:13 +01:00

#73009 was marked as duplicate of this issue

Emir Sinan Gürlek commented

2020-01-08 15:24:29 +01:00

Added subscriber: @filibis

Emir Sinan Gürlek commented

2020-01-08 15:24:29 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Emir Sinan Gürlek commented

2020-01-08 15:24:29 +01:00

I can't reproduce this. Baking domain works as intented and shows particles. Could you share a .blend file that is not working for you?

Pavel Blend commented

2020-01-08 16:07:12 +01:00

This error occurs in this scene:
mantaflow_bug_01.zip

Perhaps the problem is again in my old video card.

This error occurs in this scene: [mantaflow_bug_01.zip](https://archive.blender.org/developer/F8266026/mantaflow_bug_01.zip) Perhaps the problem is again in my old video card.

Emir Sinan Gürlek commented

2020-01-08 16:13:37 +01:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Emir Sinan Gürlek commented

2020-01-08 16:13:37 +01:00

Allright this happens for me as well for this file. Unchecking and checking Liquid checkbox make the particles data appear. Let's wait for a developer to reproduce the issue.

Sebastián Barschkis was assigned by Emir Sinan Gürlek

2020-01-08 16:16:47 +01:00

Germano Cavalcante commented

2020-01-10 12:22:06 +01:00

Added subscribers: @mano-wii, @juang3d, @bent, @NicolaSap

Nicola De Mitri commented

2020-01-10 12:33:50 +01:00

The problem boils down to the fact that, when an oject is assigned Domain Type = Fluid, the "Liquid" checkbox appears selected even if it's not.

A minimal way of reproducing the core error is:

Default cube: Physics > Fluid > Type: Domain; Domain Type: Liquid
Observe that - [x] Liquid appears as checked
Observe that, under Particles, there is no "FLIP Particles" system
Observe that checking - [x] Liquid manually doesn't go to an "off" state but stays on a "on" state; it also triggers the creation of a particle system

The problem boils down to the fact that, when an oject is assigned Domain Type = Fluid, the "Liquid" checkbox appears selected even if it's not. A minimal way of reproducing the core error is: - Default cube: Physics > Fluid > Type: Domain; Domain Type: Liquid - Observe that `- [x] Liquid` appears as checked - Observe that, under Particles, there is no "FLIP Particles" system - Observe that checking `- [x] Liquid` manually doesn't go to an "off" state but stays on a "on" state; it also triggers the creation of a particle system

Germano Cavalcante commented

2020-01-10 12:43:15 +01:00

Thank you @NicolaSap, I will update the description.

Germano Cavalcante commented

2020-01-10 12:44:47 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Nicola De Mitri commented

2020-01-13 13:35:27 +01:00

Unfortunately I'm not able to fix this myself, like I wanted to.

If it helps, it looks like adding something like

  RNA_def_property_update(prop, NC_OBJECT | ND_DRAW, "rna_Fluid_flip_parts_update");

to rna prop: "domain_type" would likely fix this (except this is not the right way, and for example it would break Quick Liquid, which instead works correctly right now because it calls for the update directly from Python).

I'd like to point out that this bug has a potentially very high impact on usability!

I'm worried that those who are testing 2.82 are not taking advantage of the FLIP particle visualization at all, because it doesn't work out of the box!

Unfortunately I'm not able to fix this myself, like I wanted to. If it helps, it looks like adding something like ``` RNA_def_property_update(prop, NC_OBJECT | ND_DRAW, "rna_Fluid_flip_parts_update"); ``` to rna prop: `"domain_type"` would likely fix this (except this is not the right way, and for example it would break Quick Liquid, which instead works correctly right now because it calls for the update directly from Python). I'd like to point out that this bug has a potentially very high impact on usability! I'm worried that those who are testing 2.82 are *not* taking advantage of the FLIP particle visualization at all, because it doesn't work out of the box!

blender-admin commented

2020-01-15 15:51:33 +01:00

This issue was referenced by cdd937c6dd

This issue was referenced by cdd937c6dd988feed1d9e5d023b8b7b8bec7665c

blender-admin commented

2020-01-15 15:51:33 +01:00

This issue was referenced by d571e9055a

This issue was referenced by d571e9055a0a81f4bd1fd9f574b81783d3f648fd

Sebastián Barschkis commented

2020-01-15 15:52:36 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Sebastián Barschkis closed this issue