Save ID-Properties for WorkSpaces #73446

New Issue

michal.wallace@gmail.com · 2020-01-28T03:04:18+01:00

2020-01-28 03:04:18 +01:00

System Information
Operating system: windows 10
Graphics card: nvidia geforce

Blender Version
Broken: v 2.81a

Short description of error

The python API docs claim that custom properties will be saved with the blend file, but this does not appear to be the case for custom properties defined on workspace objects.

https://docs.blender.org/api/blender_python_api_current/info_quickstart.html#custom-properties

Exact steps for others to reproduce the error

from default startup (new general file),
open the active tool and workspace settings panel (screwdriver and wrench icon)
open the workspaces sub-panel
add any custom property
save the file
close and re-open it.
(the custom property won't be there)

**System Information** Operating system: windows 10 Graphics card: nvidia geforce **Blender Version** Broken: v 2.81a **Short description of error** The python API docs claim that custom properties will be saved with the blend file, but this does not appear to be the case for custom properties defined on workspace objects. https://docs.blender.org/api/blender_python_api_current/info_quickstart.html#custom-properties **Exact steps for others to reproduce the error** from default startup (new general file), open the active tool and workspace settings panel (screwdriver and wrench icon) open the workspaces sub-panel add any custom property save the file close and re-open it. (the custom property won't be there)

michal.wallace@gmail.com commented

2020-01-28 03:04:18 +01:00

Added subscriber: @tangentstorm

michal.wallace@gmail.com commented

2020-01-28 03:11:14 +01:00

Added subscriber: @KaiJaegersen

michal.wallace@gmail.com commented

2020-01-28 03:11:14 +01:00

@KaiJaegersen mentioned on https://devtalk.blender.org/t/scene-per-tab-event-handler-for-tab-switching/11517/6 that workspace and window settings are runtime-only... If that's the case, then I suppose this is a documentation bug... But if that's the case, why even expose a UI for workspace custom properties?

Jacques Lucke commented

2020-01-28 09:52:18 +01:00

Added subscribers: @JulianEisel, @JacquesLucke

Jacques Lucke commented

2020-01-28 09:52:18 +01:00

I'm not sure how workspaces are implemented exactly. @JulianEisel might know more about workspaces are stored.

Campbell Barton changed title from ~~workspace custom properties are not saved~~ to Save ID-Properties for WorkSpaces

2020-01-28 10:56:09 +01:00

Campbell Barton commented

2020-01-28 11:03:03 +01:00

Added subscribers: @mont29, @ideasman42

Campbell Barton commented

2020-01-28 11:03:03 +01:00

As far as I can see this can be supported, as with other windowing data, undo doesn't track this so STRUCT_NO_DATABLOCK_IDPROPERTIES would need to be set.

As long as there aren't any complications think this is OK to add.
Pinging @mont29 for a second opinion.

As far as I can see this can be supported, as with other windowing data, undo doesn't track this so `STRUCT_NO_DATABLOCK_IDPROPERTIES` would need to be set. As long as there aren't any complications think this is OK to add. Pinging @mont29 for a second opinion.

Bastien Montagne commented

2020-01-29 15:59:10 +01:00

Am not sure why STRUCT_NO_DATABLOCK_IDPROPERTIES should be used? AFAIK this is used to actually forbid custom props on a structure that does have idprops storage? Screen ID does not have that at least…

In fact am not sure why customprops on WS are not saved, afaict only WM are explicitly excluded from that in write_iddata(). Screens and WorkSpaces should be written as any other ID (although indeed there would be no undo supported for those two).

Am not sure why `STRUCT_NO_DATABLOCK_IDPROPERTIES` should be used? AFAIK this is used to actually forbid custom props on a structure that does have idprops storage? `Screen` ID does not have that at least… In fact am not sure why customprops on WS are not saved, afaict only WM are explicitly excluded from that in `write_iddata()`. Screens and WorkSpaces should be written as any other ID (although indeed there would be no undo supported for those two).

dupoxy commented

2020-01-29 17:35:51 +01:00

Added subscriber: @dupoxy

blender-admin commented

2020-02-12 08:19:14 +01:00

This issue was referenced by cc6defa244

This issue was referenced by cc6defa24456783c90cd4fea65111ff95aaec666

Campbell Barton commented

2020-02-12 08:20:02 +01:00

Changed status from 'Needs Triage' to: 'Resolved'

Campbell Barton closed this issue

2020-02-12 08:20:02 +01:00

Campbell Barton self-assigned this 2020-02-12 08:20:02 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Save ID-Properties for WorkSpaces #73446