Greasepencil parent to armature with envelope weights assigns wrong weights #73660

New Issue

Philipp Oeser · 2020-02-07T16:57:49+01:00

Philipp Oeser commented

2020-02-07 16:57:49 +01:00

System Information
Operating system: Linux-5.4.13-201.fc31.x86_64-x86_64-with-fedora-31-Thirty_One 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.44

Blender Version
Broken: version: 2.83 (sub 2), branch: master, commit date: 2020-02-07 11:18, hash: d809853513

Short description of error
Greasepencil parent to armature with envelope weights assigns wrong weights

Exact steps for others to reproduce the error
greasepencil_armature_parent_envelope_weights.blend

Open file
parent the greasepencil monkey to the armature {key Ctrl P} (using With Envelope Weights option)
vertex groups are created, but the weights dont take the bones envelope distance into account

This is reporting the second issue of #60789 (Grease Pencil Armature Deform fails with Envelope Deform) separately, keeping it isolated.

Note:

In #60789#605191, @antoniov wrote:
Currently, when you use Ctrl+P with envelopes does the same that vertex group.

**System Information** Operating system: Linux-5.4.13-201.fc31.x86_64-x86_64-with-fedora-31-Thirty_One 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.44 **Blender Version** Broken: version: 2.83 (sub 2), branch: master, commit date: 2020-02-07 11:18, hash: `d809853513` **Short description of error** Greasepencil parent to armature with envelope weights assigns wrong weights **Exact steps for others to reproduce the error** [greasepencil_armature_parent_envelope_weights.blend](https://archive.blender.org/developer/F8327755/greasepencil_armature_parent_envelope_weights.blend) - Open file - parent the greasepencil monkey to the armature {key Ctrl P} (using With Envelope Weights option) - vertex groups are created, but the weights dont take the bones envelope distance into account This is reporting the second issue of #60789 (Grease Pencil Armature Deform fails with Envelope Deform) separately, keeping it isolated. Note: > In #60789#605191, @antoniov wrote: > Currently, when you use Ctrl+P with envelopes does the same that vertex group.

Philipp Oeser commented

2020-02-07 16:57:49 +01:00

Added subscribers: @antoniov, @lichtwerk

Philipp Oeser commented

2020-02-07 16:58:20 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Antonio Vazquez commented

2020-02-07 17:01:48 +01:00

Actually, this is a non supported feature.

Philipp Oeser commented

2020-02-07 17:22:05 +01:00

Added subscriber: @WilliamReynish

Philipp Oeser commented

2020-02-07 17:22:05 +01:00

In #73660#867576, @antoniov wrote:
Actually, this is a non supported feature.

I see that gpencil_object_vgroup_calc_from_armature only supports one mode (GP_PAR_ARMATURE_AUTO), and this is used for both PAR_ARMATURE_AUTO and PAR_ARMATURE_ENVELOPE.

Just saying: if you are not planning to implement this, it might be better to remove this option entirely from parent_set_invoke_menu (in case of greasepencil).
Having this option there, but having it do something entirely different from what it advertises, seems wrong to me...

> In #73660#867576, @antoniov wrote: > Actually, this is a non supported feature. I see that `gpencil_object_vgroup_calc_from_armature` only supports one mode (`GP_PAR_ARMATURE_AUTO`), and this is used for both `PAR_ARMATURE_AUTO` and `PAR_ARMATURE_ENVELOPE`. Just saying: if you are not planning to implement this, it might be better to remove this option entirely from `parent_set_invoke_menu` (in case of greasepencil). Having this option there, but having it do something entirely different from what it advertises, seems wrong to me...

Antonio Vazquez self-assigned this 2020-02-07 17:42:28 +01:00

blender-admin commented

2020-02-07 17:46:29 +01:00

This issue was referenced by 47d13fecfb

This issue was referenced by 47d13fecfbb7f2111ccd71b5376c8c3094ca1558

Antonio Vazquez commented

2020-02-07 17:47:40 +01:00

Proposed fix: D6777

Proposed fix: [D6777](https://archive.blender.org/developer/D6777)

Antonio Vazquez commented

2020-02-07 17:59:15 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Antonio Vazquez closed this issue

2020-02-07 17:59:15 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Greasepencil parent to armature with envelope weights assigns wrong weights #73660