Eevee volume render test memory leak in Mantaflow #73921
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#73921
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Linux-4.15.0-76-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: Quadro RTX 5000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21
Blender Version
Broken: version: 2.83 (sub 4),
5b22713Exact steps for others to reproduce the error
Running this command will hang, some problem with the Python GIL.
Backtrace:
P1260: (An Untitled Masterwork)
Added subscriber: @brecht
Alternatively you can enable
WITH_OPENGL_RENDER_TESTSand runctest -R eevee.Changed status from 'Needs Triage' to: 'Confirmed'
I fixed the hang which was caused by not properly releasing the GIL when a Python error happens.
But that Python error is what really needs to be fixed to solve this.
Eevee volume render test hang in Mantaflowto Eevee volume render test crash in Mantaflow93ac4709ebfixes the crash that was happening when light baking was still enabled in the script. However, when light baking is enabled in the script, there is still a memory leak that needs to be fixed.Once that is out of the way, the temporary workaround
f3a33a9298can be removed too.Eevee volume render test crash in Mantaflowto Eevee volume render test memory leak in MantaflowThis issue was referenced by
5260aaf3b1Changed status from 'Confirmed' to: 'Resolved'
Changed status from 'Resolved' to: 'Confirmed'
This is still crashing for me when doing multiple renders in one command (as the tests do). Example:
Interesting, on my OSX machine and with latest master (
8cb463f4ff) I don't get a crash with the example command. Does the crash exit with the same log?It hits this assert always in debug mode for me, also rendering a single image. Crashing without the assert seems to happenly mostly with multiple renders, but is a bit random.
The new call to
EEVEE_volumes_free_smoke_textures()at the end of light cache baking seems to be the problem. Maybe it's freeing textures that are still being referenced somewhere? I also find it strange that is called at the endeevee_lightbake_delete_resources, after all the code to dispose or disable the OpenGL context. I tried moving it higher up but it didn't seem to help.Overall though it's not clear to me what the lifetime of these smoke textures is supposed to be. Image textures have their own garbage collection. For meshes and other geometry there is the batch cache. These smoke textures seems to be freed by workbench and eevee which is yet another way of doing things.
It would make more sense to me if these were somehow part of the batch cache the way it's done for the new volume object.
Ah, now I am also seeing the crash. Before looking for the reason, are we sure that the
.blendfiles are doing what they're supposed to do?I am only having problems with
lib/test/render/volume/smoke.blendandlib/test/render/volume/smoke_fire.blend.Testing with
smoke_color.blendmultiple times seems to be fine:I think
smoke.blendandsmoke_fire.blendmight need to be remodeled. Aren't their setups supposed to look likesmoke_color.blend- just having a different flow types?Mantaflow (fluid simulator) has no active developer at the moment. Moving those bugs as known issues so at least other users can find their issues already reported.