GPencil – Fills are Flickering #74663

New Issue

ronsn · 2020-03-11T20:48:33+01:00

ronsn commented

2020-03-11 20:48:33 +01:00

System Information
Operating system: Linux-5.3.0-40-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 1660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21

Blender Version
Broken: version: 2.83 (sub 8), branch: master, commit date: 2020-03-11 16:35, hash: 19b46b2fca
Worked: (optional)

Short description of error
While scrolling or hovering over the Viewport Gizmos the Fills starting to flicker. In some cases these artifacts will also be rendered. See screencast (At second 24, I discovered that hovering over the Gizmo made it worse^^):

grease_pencil_fill_flickering_2.mp4

Exact steps for others to reproduce the error

gp_fills_flickering.blend

Open the attached blend file and hover over the Viewport Gizmo, or

Open Blender with 2D Animation workspace
Draw a closed shape
Fill the shape with a fill color
Press Tab twice to change into Object Mode (this step is not necessary but in Object Mode it seems to be where the problem is most acute)
Zoom in and out and hover over the Gizmo.

––––––––––––––––––––––––––

I don't have any silly jokes for you today.^^

**System Information** Operating system: Linux-5.3.0-40-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GTX 1660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21 **Blender Version** Broken: version: 2.83 (sub 8), branch: master, commit date: 2020-03-11 16:35, hash: `19b46b2fca` Worked: (optional) **Short description of error** While scrolling or hovering over the *Viewport Gizmos* the Fills starting to flicker. In some cases these artifacts will also be rendered. See screencast (At second 24, I discovered that hovering over the Gizmo made it worse^^): [grease_pencil_fill_flickering_2.mp4](https://archive.blender.org/developer/F8401119/grease_pencil_fill_flickering_2.mp4) **Exact steps for others to reproduce the error** [gp_fills_flickering.blend](https://archive.blender.org/developer/F8401131/gp_fills_flickering.blend) Open the attached blend file and hover over the *Viewport Gizmo*, or 1. Open Blender with *2D Animation* workspace 2. Draw a closed shape 3. Fill the shape with a fill color 4. Press `Tab` twice to change into *Object Mode* (this step is not necessary but in *Object Mode* it seems to be where the problem is most acute) 5. Zoom in and out and hover over the Gizmo. –––––––––––––––––––––––––– I don't have any silly jokes for you today.^^

ronsn commented

2020-03-11 20:48:33 +01:00

Added subscriber: @ronsn

blender-admin commented

2020-03-11 20:48:33 +01:00

#74705 was marked as duplicate of this issue

blender-admin commented

2020-03-11 20:48:33 +01:00

#74736 was marked as duplicate of this issue

blender-admin commented

2020-03-11 20:48:33 +01:00

#74702 was marked as duplicate of this issue

blender-admin commented

2020-03-11 20:48:33 +01:00

#74606 was marked as duplicate of this issue

Antonio Vazquez commented

2020-03-12 10:26:33 +01:00

Added subscribers: @fclem, @antoniov

Antonio Vazquez commented

2020-03-12 10:26:33 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Antonio Vazquez commented

2020-03-12 10:26:33 +01:00

With the file you provide as example, I cannot reproduce any flickering in my system.

@fclem Do you any idea? can you reproduce it?

With the file you provide as example, I cannot reproduce any flickering in my system. @fclem Do you any idea? can you reproduce it?

Clément Foucault commented

2020-03-12 14:10:55 +01:00

I cannot reproduce either. We had an issue with drivers older than 440. Try udpating your drivers to see if it helps.

Richard Antalik commented

2020-03-12 17:12:53 +01:00

Added subscribers: @(Deleted), @iss, @ankitm

(Deleted) commented

2020-03-12 20:12:38 +01:00

(Migrated from localhost:3001)

@ronsn Fun Fact: This also happens when you click in and out of text boxes .
...Also, I had no idea this was happening to you, too. Thank you, Richard Antalik, for leading me straight to this.

@ronsn Fun Fact: This also happens when you [click in and out of text boxes ](https://www.youtube.com/watch?v=EWoDQ_MUJzg). ...Also, I had no idea this was happening to you, *too*. Thank you, Richard Antalik, for leading me straight to this.

ronsn commented

2020-03-12 21:26:52 +01:00

@fclem I had to enable the developer mode for my system, to be able to install the driver (440.59).

I tested it also on another laptop, where it hasn't this issue.

I used the attached blend file above and the following Blender version for both.

And this are the results:

Blender Version
2.83 (sub 8), branch: master, commit date: 2020-03-12 00:33, hash: 8751af6d19

DOES NOT WORK ON THIS SYSTEM:

System Information
Operating system: Linux-5.3.0-40-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 1660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.59

WORKS ON THIS SYSTEM:

System Information
Operating system: Linux-4.15.0-88-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: Mesa DRI Intel(R) HD Graphics 520 (Skylake GT2) Intel Open Source Technology Center 4.5 (Core Profile) Mesa 19.2.8

––––––––––––––––––––––––––––––

Anything else I can do? University is closed because of Corona, so I have a little bit more time^^

@fclem I had to enable the developer mode for my system, to be able to install the driver (440.59). I tested it also on another laptop, where it hasn't this issue. I used the attached blend file above and the following Blender version for both. And this are the results: **Blender Version** 2.83 (sub 8), branch: master, commit date: 2020-03-12 00:33, hash: `8751af6d19` ***DOES NOT WORK ON THIS SYSTEM*:** **System Information** Operating system: Linux-5.3.0-40-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GTX 1660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.59 ***WORKS ON THIS SYSTEM*:** **System Information** Operating system: Linux-4.15.0-88-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: Mesa DRI Intel(R) HD Graphics 520 (Skylake GT2) Intel Open Source Technology Center 4.5 (Core Profile) Mesa 19.2.8 –––––––––––––––––––––––––––––– Anything else I can do? University is closed because of Corona, so I have a little bit more time^^

ronsn commented

2020-03-12 21:50:01 +01:00

Btw. the issue occurs not only in the attached blend file above, but also with Suzanne in the General workspace:

Btw. the issue occurs not only in the attached blend file above, but also with *Suzanne* in the *General* workspace: ![Bildschirmfoto von 2020-03-12 21-46-14.png](https://archive.blender.org/developer/F8402797/Bildschirmfoto_von_2020-03-12_21-46-14.png)

Richard Antalik commented

2020-03-13 13:55:39 +01:00

Added subscriber: @Znio.G

Clément Foucault commented

2020-03-14 01:12:06 +01:00

Added subscriber: @ignietferro-1

Antonio Vazquez commented

2020-03-14 17:40:57 +01:00

I have bisected th error and it looks the flickering was introduced in commit c971e812d5

I have bisected th error and it looks the flickering was introduced in commit c971e812d5e2

ronsn commented

2020-03-14 23:17:48 +01:00

@antoniov That would mean, that the parent commit bf1b323b154433ab4701a7ab455cdecaa3867819 does not have this issue? I compiled that version and the issue is there as well: grease_pencil_fill_flickering_4.mp4
Or did I misunderstand something?

@antoniov That would mean, that the parent commit `bf1b323b154433ab4701a7ab455cdecaa3867819` does not have this issue? I compiled that version and the issue is there as well: [grease_pencil_fill_flickering_4.mp4](https://archive.blender.org/developer/F8406663/grease_pencil_fill_flickering_4.mp4) Or did I misunderstand something?

ronsn commented

2020-03-15 01:58:27 +01:00

Puhh, I was able to make a bisect too without running into compiling errors all the time.

I choose my borders like this:

git bisect start
git bisect good 94335f798997f6b5bbde685fb3d2ef2315fac34c
git bisect bad ad8ec8d8283c6bd8e811db8f1f44a21280b3a0a0

Which I tested pretty hard and long. The flickering occurs sometimes a little bit less and sometimes a little bit more and sometimes less often. Which is why I had to test it a little bit longer. And this are my results:

.
.
.
117fc08e51926cdd425aec23c6491cd33ee1de58 is (gp-branch) bad

8b6ecdb77f697a4897be2bfd0d5aef8730df3ebc is (gp-branch; 11.02. 15:18) bad => first bad commit

8f3e4c8625fbd67d2162b180dd9f6e4dd16940b0 is (gp-branch; 11.02. 11:58) good
.
.
.

So it seems, that 8b6ecdb77f is the one commit, which introduced the issue.

If you want me to make a recording between those two versions where one is good and the next is bad, I'll make it, but now it's a little bit late here, so I have to leave you for now. :)

Addendum: Even if this was the first bad commit, doesn't mean that there are no other newer commits, which repeated and/or increased the issue.

Puhh, I was able to make a bisect too without running into compiling errors all the time. I choose my borders like this: ``` git bisect start git bisect good 94335f798997f6b5bbde685fb3d2ef2315fac34c git bisect bad ad8ec8d8283c6bd8e811db8f1f44a21280b3a0a0 ``` Which I tested pretty hard and long. The flickering occurs sometimes a little bit less and sometimes a little bit more and sometimes less often. Which is why I had to test it a little bit longer. And this are my results: ``` . . . 117fc08e51926cdd425aec23c6491cd33ee1de58 is (gp-branch) bad 8b6ecdb77f697a4897be2bfd0d5aef8730df3ebc is (gp-branch; 11.02. 15:18) bad => first bad commit 8f3e4c8625fbd67d2162b180dd9f6e4dd16940b0 is (gp-branch; 11.02. 11:58) good . . . ``` So it seems, that 8b6ecdb77f is the one commit, which introduced the issue. If you want me to make a recording between those two versions where one is good and the next is bad, I'll make it, but now it's a little bit late here, so I have to leave you for now. :) Addendum: Even if this was the first bad commit, doesn't mean that there are no other newer commits, which repeated and/or increased the issue.

Ankit Meel commented

2020-03-15 09:37:13 +01:00

Added subscriber: @BerbankGreen

n1729 commented

2020-03-16 09:44:43 +01:00

Added subscriber: @n1729

n1729 commented

2020-03-16 10:30:11 +01:00

I'm experiencing the same issue, too. My environment is as follows.

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.19

Blender Version
Broken: version: 2.83 (sub 9), branch: master, commit date: 2020-03-14 18:05, hash: a210b8297f

I'm experiencing the same issue, too. My environment is as follows. **System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.19 **Blender Version** Broken: version: 2.83 (sub 9), branch: master, commit date: 2020-03-14 18:05, hash: `a210b8297f`

n1729 commented

2020-03-17 00:38:33 +01:00

I builded and tested c971e812d5 and the earlier bf1b323b15.
As @antoniov mentioned, I confirmed that this issue begun from c971e812d5 at least in my environment.

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.19

Blender Version
Broken: version: 2.83 (sub 7), branch: test, commit date: 2020-03-10 03:47, hash: bf1b323b15

There is no issue.

Blender 2020-03-17 08-14-02.mp4

Blender Version
Broken: version: 2.83 (sub 7), branch: test2, commit date: 2020-03-10 03:47, hash: c971e812d5

Flickering happens.

Blender 2020-03-17 08-13-18.mp4

I builded and tested c971e812d5e2 and the earlier bf1b323b1544. As @antoniov mentioned, I confirmed that this issue begun from c971e812d5e2 at least in my environment. **System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.19 **Blender Version** Broken: version: 2.83 (sub 7), branch: test, commit date: 2020-03-10 03:47, hash: `bf1b323b15` There is no issue. [Blender 2020-03-17 08-14-02.mp4](https://archive.blender.org/developer/F8411087/Blender_2020-03-17_08-14-02.mp4) **Blender Version** Broken: version: 2.83 (sub 7), branch: test2, commit date: 2020-03-10 03:47, hash: `c971e812d5` Flickering happens. [Blender 2020-03-17 08-13-18.mp4](https://archive.blender.org/developer/F8411088/Blender_2020-03-17_08-13-18.mp4)

Antonio Vazquez commented

2020-03-18 16:09:36 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Antonio Vazquez commented

2020-03-18 16:09:36 +01:00

Only confirmed in Windows with NVIDIA cards.

Antonio Vazquez commented

2020-03-19 13:31:12 +01:00

@n1729 @ronsn I did a test to verify if it's related to ivec4 parameter.

Here P1305 you have a small patch for testing.

If you could compile and test to see if you have the problem still, we could be sure if the bug relates to that or not.

@n1729 @ronsn I did a test to verify if it's related to `ivec4` parameter. Here [P1305](https://archive.blender.org/developer/P1305.txt) you have a small patch for testing. If you could compile and test to see if you have the problem still, we could be sure if the bug relates to that or not.

ronsn commented

2020-03-19 16:12:46 +01:00

@antoniov With patch P1305 applied the fills are still flickering on my system**⁽¹⁾**.

Building Blender with your patch went successful:

make
...

[ 73%] Building C object source/blender/draw/CMakeFiles/bf_draw.dir/intern/draw_cache_impl_gpencil.c.o
[ 73%] Building C object source/blender/draw/CMakeFiles/bf_draw.dir/engines/gpencil/shaders/gpencil_common_lib.glsl.c.o
[ 73%] Building C object source/blender/draw/CMakeFiles/bf_draw.dir/engines/overlay/shaders/edit_gpencil_vert.glsl.c.o

...

[100%] Linking CXX executable ../../bin/blender
now run: "make install" to copy runtime files and scripts to 2.83
[100%] Built target blender
Install the project...
-- Install configuration: "Release"
-- Installing: /home/lynx/blender-git/build_linux/bin/./readme.html

edit build configuration with: /home/lynx/blender-git/build_linux/CMakeCache.txt run make again to rebuild.
Blender successfully built, run from: /home/lynx/blender-git/build_linux/bin/blender

–––––––––––
(1): System Information
Operating system: Linux-5.3.0-40-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 1660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.59

Blender Version
Broken: version: 2.83 (sub 10), branch: master (modified), commit date: 2020-03-19 14:26, hash: 2982c9ba0a

@antoniov With patch [P1305](https://archive.blender.org/developer/P1305.txt) applied the fills are still flickering on my system**⁽¹⁾**. Building Blender with your patch went successful: ``` make ... [ 73%] Building C object source/blender/draw/CMakeFiles/bf_draw.dir/intern/draw_cache_impl_gpencil.c.o [ 73%] Building C object source/blender/draw/CMakeFiles/bf_draw.dir/engines/gpencil/shaders/gpencil_common_lib.glsl.c.o [ 73%] Building C object source/blender/draw/CMakeFiles/bf_draw.dir/engines/overlay/shaders/edit_gpencil_vert.glsl.c.o ... [100%] Linking CXX executable ../../bin/blender now run: "make install" to copy runtime files and scripts to 2.83 [100%] Built target blender Install the project... -- Install configuration: "Release" -- Installing: /home/lynx/blender-git/build_linux/bin/./readme.html edit build configuration with: /home/lynx/blender-git/build_linux/CMakeCache.txt run make again to rebuild. Blender successfully built, run from: /home/lynx/blender-git/build_linux/bin/blender ``` ––––––––––– (1): **System Information** Operating system: Linux-5.3.0-40-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GTX 1660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.59 **Blender Version** Broken: version: 2.83 (sub 10), branch: master (modified), commit date: 2020-03-19 14:26, hash: `2982c9ba0a`

n1729 commented

2020-03-19 17:33:08 +01:00

Thank you, @antoniov

I tested P1305. The vec4 version seems to alleviate flickering pretty well, but even so flickering still sometimes happens.
I had never found any single flickering as of the point bf1b323b15, which is earlier than c971e812d5.

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.19

Before applying the patch: version: 2.83 (sub 9), branch: test3, commit date: 2020-03-18 10:12, hash: 12720d8b9b

Blender 2020-03-20 00-48-39.mp4

After applying the patch: version: 2.83 (sub 9), branch: test3, commit date: 2020-03-19 15:20, hash: 2f78389bbb
Please pay attention to the monkey's right ear.

Blender 2020-03-20 00-49-11.mp4

Thank you, @antoniov I tested [P1305](https://archive.blender.org/developer/P1305.txt). The vec4 version seems to alleviate flickering pretty well, but even so flickering still sometimes happens. I had never found any single flickering as of the point bf1b323b1544, which is earlier than c971e812d5e2. **System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.19 Before applying the patch: version: 2.83 (sub 9), branch: test3, commit date: 2020-03-18 10:12, hash: `12720d8b9b` [Blender 2020-03-20 00-48-39.mp4](https://archive.blender.org/developer/F8416046/Blender_2020-03-20_00-48-39.mp4) After applying the patch: version: 2.83 (sub 9), branch: test3, commit date: 2020-03-19 15:20, hash: `2f78389bbb` Please pay attention to the monkey's right ear. [Blender 2020-03-20 00-49-11.mp4](https://archive.blender.org/developer/F8416045/Blender_2020-03-20_00-49-11.mp4)

ronsn commented

2020-03-23 18:58:23 +01:00

@antoniov I wasn't sure if your patch P1305 made it better, but now I have a "better" opportunity to compare the current master branch version without and with your patch. And it seems that your patch made it better as @n1729 stated out.

I used the following blend file:
konfetti.blend

Here I also made a comparison screencast without and with your patch:
gp_fills_flickering_patch_P1305_comparison.mp4

@antoniov I wasn't sure if your patch [P1305](https://archive.blender.org/developer/P1305.txt) made it better, but now I have a "better" opportunity to compare the current master branch version without and with your patch. And it seems that your patch made it better as @n1729 stated out. I used the following blend file: [konfetti.blend](https://archive.blender.org/developer/F8425282/konfetti.blend) Here I also made a comparison screencast without and with your patch: [gp_fills_flickering_patch_P1305_comparison.mp4](https://archive.blender.org/developer/F8425288/gp_fills_flickering_patch_P1305_comparison.mp4)

Antonio Vazquez commented

2020-03-26 10:10:51 +01:00

Added subscriber: @brecht

Antonio Vazquez commented

2020-03-26 10:10:51 +01:00

@brecht We have been looking at the code and running debugs with RenderDoc a NVIDIA tools and it looks a NVDIA driver issue. Could you make a test in a NVIDIA machine to see if you can see what is going on.

Here you have a video inside NVIDIA tool and you can see the flickering when moving the mouse.

2020-03-25 16-37-42.mp4

@fclem and I were looking the code again and again and we are not able to find any mistake. This is a very important bug and we don't know how fix it.

@brecht We have been looking at the code and running debugs with RenderDoc a NVIDIA tools and it looks a NVDIA driver issue. Could you make a test in a NVIDIA machine to see if you can see what is going on. Here you have a video inside NVIDIA tool and you can see the flickering when moving the mouse. [2020-03-25 16-37-42.mp4](https://archive.blender.org/developer/F8428466/2020-03-25_16-37-42.mp4) @fclem and I were looking the code again and again and we are not able to find any mistake. This is a very important bug and we don't know how fix it.

heini commented

2020-03-26 10:13:35 +01:00

Added subscriber: @heini

Antonio Vazquez commented

2020-03-26 10:34:11 +01:00

Added subscriber: @Jeroen-Bakker

Antonio Vazquez commented

2020-03-26 10:34:11 +01:00

@Jeroen-Bakker Any idea here?

Scott Ramsay commented

2020-03-28 01:26:11 +01:00

Added subscriber: @smramsay

Dr.Toonhattan commented

2020-03-28 02:53:21 +01:00

Added subscriber: @Dr.Toonhattan

Evan Wilson commented

2020-03-29 14:49:08 +02:00

Added subscriber: @EAW

Evan Wilson commented

2020-03-29 14:49:08 +02:00

Just something I noticed, if it hasn’t already been by others, is that the border of the flickering area occurs where the vertices flip from being inside the fill in edit mode to outside and vice versa.

Brecht Van Lommel commented

2020-03-29 16:17:47 +02:00

@antoniov, I looked at this for a bit but also couldn't see the cause. Maybe it's a driver bug.

To pinpoint the cause this I guess you'd have to kind of bisect the change, changing the code incrementally to see which exact part of that commit caused the problem.

If you can't find a solution, an option is to use the new code only for Apple, or the old code only for NVIDIA.

@antoniov, I looked at this for a bit but also couldn't see the cause. Maybe it's a driver bug. To pinpoint the cause this I guess you'd have to kind of bisect the change, changing the code incrementally to see which exact part of that commit caused the problem. If you can't find a solution, an option is to use the new code only for Apple, or the old code only for NVIDIA.

blender-admin commented

2020-03-30 17:56:46 +02:00

This issue was referenced by 6428da84ed

This issue was referenced by 6428da84ed37534014f6c85b141af67af951813d

Clément Foucault commented

2020-03-30 17:58:17 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Clément Foucault closed this issue

2020-03-30 17:58:17 +02:00

Clément Foucault self-assigned this 2020-03-30 17:58:17 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPencil – Fills are Flickering #74663