New complex solidify algorithm handles poorly merging threshold of small geometry details. #75032
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#75032
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Using same file from #74195: bug_svg_solidify_03.blend
Notice how incrementally bigger and bigger chunks of the geometry get merged together.
Think there are two issues there:
Note: noticed while reviewing D7214.
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @mont29
the chain merging is a technical limitation that I also noticed during testing your file.
I would like to get a second opinion how to fix that, so I will explain here why that is the case and why merging is sooo important.
My algorithm sorts faces around an edge by angle. To do so it needs a normalised direction vector of the edge.
If vertices are really close normalization might fail or come out with very poor precision. Thats why merging is important.
Merging is then done edge by edge. So it would start in element order with the first edge and check if it should merge it and
then go over to the next one and so on. The merge will always prefer the vertex with the smaller index (I think there was a reason but I forgot...)
The problem arises if the next edge is the one that has the vertex that the previous edge is merged to, because then, that edge
needs to be collapsed as well and that can chain through infinitly many vertices.
The main ways to fix it that I can think of right now are the following:
after writing this I see merge to center as the way to go, but feel free to add an idea to the list.
After all keep in mind that the degenerate feature of solidify is not meant for dissolving, just to handle degenerate cases.
also... How do I add a field to
struct SolidifyModifierData
in DNA_modifier_types.h ?I feel like just making it longer would mess with things. Last time I used the padding (the char _pad- [x] is now a char _pad and my mode data is stored there instead). This time there is definitly not the space for an additional float value for the precision user input.
Added subscriber: @HooglyBoogly
It should be fine to make DNA structs longer. The DNA system / readfile can handle that fine.
Regarding DNA, yes, just add some new value, and for 32bits things (like floats or ints), group them by two to get 64bits (that means that if you only need one float, you need to add another
char _pad2- [x]
just after it).note that by default DNA will init that one to zero when loading a file from a version where it did not exist, so if you need a different default value you'll have to edit the versioning file (just look at surrounding code for examples of how to do it exactly).
Regarding merging, I indeed think that merging at the center of the edge is the best way to go.
This issue was referenced by
5cf7283342
Changed status from 'Confirmed' to: 'Resolved'