Crash: Divide By Zero with workbench depth of field when antialiasing disabled #75087

New Issue

Floatharr · 2020-03-25T22:01:06+01:00

Floatharr commented

2020-03-25 22:01:06 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.74

Blender Version
Broken: version: 2.83 (sub 10), branch: master, commit date: 2020-03-21 20:58, hash: 9e8afa8817
Broken: version: 2.83 (sub 9), branch: master, commit date: 2020-03-14 18:05, hash: a210b8297f
Worked: version: 2.83 (sub 7), branch: master, commit date: 2020-03-09 22:23, hash: fbe81db29a

Short description of error
Disabling antialiasing causes workbench depth of field to crash blender.

Exact steps for others to reproduce the error
With factory settings:

Set Viewport Anti-Aliasing to "No Antialiasing"
View -> Cameras -> Active Camera
Enable Depth of Field in Viewport Shading
Enable Camera Depth of Field in Active Camera Object Data Properties

c6jgCPksVI.mp4

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.74 **Blender Version** Broken: version: 2.83 (sub 10), branch: master, commit date: 2020-03-21 20:58, hash: `9e8afa8817` Broken: version: 2.83 (sub 9), branch: master, commit date: 2020-03-14 18:05, hash: `a210b8297f` Worked: version: 2.83 (sub 7), branch: master, commit date: 2020-03-09 22:23, hash: `fbe81db29a` **Short description of error** Disabling antialiasing causes workbench depth of field to crash blender. **Exact steps for others to reproduce the error** With factory settings: 1. Set Viewport Anti-Aliasing to "No Antialiasing" 2. View -> Cameras -> Active Camera 3. Enable Depth of Field in Viewport Shading 4. Enable Camera Depth of Field in Active Camera Object Data Properties [c6jgCPksVI.mp4](https://archive.blender.org/developer/F8428084/c6jgCPksVI.mp4)

Floatharr commented

2020-03-25 22:01:06 +01:00

Added subscriber: @Floatharr

Robert Guetzkow commented

2020-03-25 22:21:13 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-03-25 22:21:13 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2020-03-25 22:21:13 +01:00

In float offset = wpd->taa_sample / wpd->taa_sample_len; the taa_sample_len is zero.

workbench_dof_cache_init(WORKBENCH_Data * vedata) Line 329	C
workbench_cache_init(void * ved) Line 96	C
drw_engines_cache_init() Line 963	C
DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) Line 1468	C
DRW_draw_view(const bContext * C) Line 1400	C
view3d_draw_view(const bContext * C, ARegion * region) Line 1603	C
view3d_main_region_draw(const bContext * C, ARegion * region) Line 1628	C
ED_region_do_draw(bContext * C, ARegion * region) Line 539	C
wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 669	C
wm_draw_window(bContext * C, wmWindow * win) Line 795	C
wm_draw_update(bContext * C) Line 997	C
WM_main(bContext * C) Line 454	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 526	C

In `float offset = wpd->taa_sample / wpd->taa_sample_len;` the `taa_sample_len` is zero. ``` workbench_dof_cache_init(WORKBENCH_Data * vedata) Line 329 C workbench_cache_init(void * ved) Line 96 C drw_engines_cache_init() Line 963 C DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) Line 1468 C DRW_draw_view(const bContext * C) Line 1400 C view3d_draw_view(const bContext * C, ARegion * region) Line 1603 C view3d_main_region_draw(const bContext * C, ARegion * region) Line 1628 C ED_region_do_draw(bContext * C, ARegion * region) Line 539 C wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 669 C wm_draw_window(bContext * C, wmWindow * win) Line 795 C wm_draw_update(bContext * C) Line 997 C WM_main(bContext * C) Line 454 C main(int argc, const unsigned char * * UNUSED_argv_c) Line 526 C ```

Brecht Van Lommel commented

2020-03-25 22:41:19 +01:00

Added subscribers: @fclem, @brecht

Brecht Van Lommel commented

2020-03-25 22:41:19 +01:00

@rjg, for a bug to be confirmed, it must also be tagged with the relevent module project, otherwise it's not fully triaged.

If it's high priority or likely caused by a recent change, CC the relevant developer as well.

@rjg, for a bug to be confirmed, it must also be tagged with the relevent module project, otherwise it's not fully triaged. If it's high priority or likely caused by a recent change, CC the relevant developer as well.

Robert Guetzkow commented

2020-03-25 22:53:52 +01:00

@brecht That was unintentional, I somehow forgot to tag the project.

The change was introduced by @fclem 's workbench refactor c476c36e40.

@brecht That was unintentional, I somehow forgot to tag the project. The change was introduced by @fclem 's workbench refactor c476c36e400883d929a7149def8dcb6ad6157a86.

blender-admin commented

2020-03-26 16:03:37 +01:00

This issue was referenced by a0437c3f73

This issue was referenced by a0437c3f730f14be83f8e6cb20432b3775ffd03f

Clément Foucault commented

2020-03-26 16:04:07 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Clément Foucault closed this issue

2020-03-26 16:04:07 +01:00

Clément Foucault self-assigned this 2020-03-26 16:04:07 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash: Divide By Zero with workbench depth of field when antialiasing disabled #75087