Adaptive sampling artifacts #75388

Closed
opened 2020-04-04 20:50:26 +02:00 by Jonathan Dent · 15 comments

Just rebuilt Blender from scratch this morning. Upon rendering with adaptive sampling (both CPU and GPU), there is bad artifacting that resembles salt and pepper noise. This does not occur with non-adaptive rendering (CPU and GPU)

Steps to reproduce:

Open new file, select 'Cycles' as the render engine and enable Adaptive sampling, then render.

image.png

Git Revision: e455536943

Just rebuilt Blender from scratch this morning. Upon rendering with adaptive sampling (both CPU and GPU), there is bad artifacting that resembles salt and pepper noise. This does not occur with non-adaptive rendering (CPU and GPU) Steps to reproduce: Open new file, select 'Cycles' as the render engine and enable Adaptive sampling, then render. ![image.png](https://archive.blender.org/developer/F8448538/image.png) Git Revision: e455536943a862334a765fdef7edfd16b2e9b5b1
Author

Added subscriber: @jdent02

Added subscriber: @jdent02

#75411 was marked as duplicate of this issue

#75411 was marked as duplicate of this issue

#75396 was marked as duplicate of this issue

#75396 was marked as duplicate of this issue
Author

image.png

This is with the adaptive threshold set to .001

![image.png](https://archive.blender.org/developer/F8448547/image.png) This is with the adaptive threshold set to .001
Member

Added subscribers: @brecht, @lichtwerk

Added subscribers: @brecht, @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Caused by 82a8da0ec3.

CC @brecht

Caused by 82a8da0ec3. CC @brecht
Member

Added subscribers: @ronsn, @EAW

Added subscribers: @ronsn, @EAW
Member

Added subscriber: @Jewls

Added subscriber: @Jewls

Added subscriber: @JasonClarke

Added subscriber: @JasonClarke
Member

Added subscriber: @Alaska

Added subscriber: @Alaska
Member

Just thought I'd add to this. Using build 505a19ed75 on Linux I experience this issue. However, I've noticed it affect's many other passes than just the just the beauty pass. Here's a list:

Affected Passes:
Combined (standard render)
Normal
UV
AO
Emission
Environment
Mist Pass
Diffuse Colour
Glossy Colour
Transmission Colour
Volume Direct
Volume Indirect
Debug Sample Count

Passes with no issues as far as I can tell:
Depth
Vector
Shadow
Diffuse Direct
Diffuse Indirect
Glossy Direct
Glossy Indirect
Transmission Indirect
Noisy Image
Denoising Normal
Denoising Albedo
Cryptomatte

Luckily for us, this means that we can use the "Noisy Image" pass in a compositor if we still want our image with adaptive sampling until a patch is out.

These are the passes I'm unsure about:
Object and Material ID
Transmission Direct
Denoising Depth
Denosing Clean
Render time

Just thought I'd add to this. Using build 505a19ed75b2 on Linux I experience this issue. However, I've noticed it affect's many other passes than just the just the beauty pass. Here's a list: **Affected Passes:** Combined (standard render) Normal UV AO Emission Environment Mist Pass Diffuse Colour Glossy Colour Transmission Colour Volume Direct Volume Indirect Debug Sample Count **Passes with no issues as far as I can tell:** Depth Vector Shadow Diffuse Direct Diffuse Indirect Glossy Direct Glossy Indirect Transmission Indirect Noisy Image Denoising Normal Denoising Albedo Cryptomatte Luckily for us, this means that we can use the "Noisy Image" pass in a compositor if we still want our image with adaptive sampling until a patch is out. **These are the passes I'm unsure about:** Object and Material ID Transmission Direct Denoising Depth Denosing Clean Render time

This issue was referenced by blender/cycles@0c170f7dae

This issue was referenced by blender/cycles@0c170f7daebf6a5168511ec16dbc763416f61423

This issue was referenced by e05552f7c4

This issue was referenced by e05552f7c4ac27faa510048e8c010e4323acb569

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Brecht Van Lommel self-assigned this 2020-04-06 23:24:18 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#75388
No description provided.