Crash: Sculpt Layer brush + Stroke Method "Anchored" makes Blender crash #75743

New Issue

TheRedWaxPolice · 2020-04-15T04:57:19+02:00

TheRedWaxPolice commented

2020-04-15 04:57:19 +02:00

System Information
Operating system: Win 10

Blender Version
Broken: blender-2.83- 04f006ea9e-windows64
Worked: blender-2.83- 85de07e64c-windows64

Short description of error
The new Layer brush with the Stroke Method "Anchored" makes Blender crash...

Exact steps for others to reproduce the error

Launch Blender
Go to File/New/Sculpting
Choose the Layer brush (L)
Choose the Stroke Method: Anchored
Perform a brush stroke on the model
Crash

**System Information** Operating system: Win 10 **Blender Version** Broken: blender-2.83- 04f006ea9e-windows64 Worked: blender-2.83- 85de07e64c-windows64 **Short description of error** The new Layer brush with the Stroke Method "Anchored" makes Blender crash... **Exact steps for others to reproduce the error** - Launch Blender - Go to File/New/Sculpting - Choose the Layer brush (L) - Choose the Stroke Method: Anchored - Perform a brush stroke on the model - Crash

TheRedWaxPolice commented

2020-04-15 04:57:19 +02:00

Added subscriber: @TheRedWaxPolice

blender-admin commented

2020-04-15 04:57:19 +02:00

#76300 was marked as duplicate of this issue

blender-admin commented

2020-04-15 04:57:19 +02:00

#75830 was marked as duplicate of this issue

Ankit Meel commented

2020-04-15 11:51:13 +02:00

Added subscriber: @ankitm

Ankit Meel commented

2020-04-15 11:51:13 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Ankit Meel commented

2020-04-15 11:51:13 +02:00

My bad, I missed the stroke method step.
~~Cannot redo on 51e73e9956~~
~~can you test the version I said? I'm checking on 04f00~~

My bad, I missed the stroke method step. ~~Cannot redo on 51e73e9956~~ ~~can you test the version I said? I'm checking on 04f00~~

TheRedWaxPolice commented

2020-04-15 15:36:24 +02:00

@ankitm Hi. Why you added (rB) to that number in the description? That's the hash, as seen on the splash screen:
Anyway, I just downloaded the current latest master to test: and it still crashes. See: 2020-04-15_14-30-50.mp4

@ankitm Hi. Why you added (rB) to that number in the description? That's the hash, as seen on the splash screen: ![image.png](https://archive.blender.org/developer/F8474501/image.png) Anyway, I just downloaded the current [latest master ](https://builder.blender.org/download/) to test: ![image.png](https://archive.blender.org/developer/F8474511/image.png) and it still crashes. See: [2020-04-15_14-30-50.mp4](https://archive.blender.org/developer/F8474528/2020-04-15_14-30-50.mp4)

Ankit Meel commented

2020-04-15 15:47:20 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Ankit Meel commented

2020-04-15 15:47:20 +02:00

Added subscriber: @PabloDobarro

Ankit Meel commented

2020-04-15 15:47:20 +02:00

caused by : 47f46637be
CC: @PabloDobarro

@TheRedWaxPolice Adding rB helps with clicking on it & seeing the date and differential of the commit.

caused by : 47f46637be CC: @PabloDobarro @TheRedWaxPolice Adding rB helps with clicking on it & seeing the date and differential of the commit.

blender-admin commented

2020-04-15 20:49:53 +02:00

This issue was referenced by e6fab27d6a

This issue was referenced by e6fab27d6a3476a08cadb7ff4ecbd467a1c0db74

Ankit Meel commented

2020-04-17 15:08:10 +02:00

Added subscriber: @rpserge

Robert Guetzkow commented

2020-04-18 15:34:06 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-04-18 15:34:06 +02:00

When ss->layer_base is NULL, use_persistent_base is false, hence disp_factor = &ss->cache->layer_displacement_factor[vi]; is used. However, layer_displacement_factor is NULL as well.

In do_layer_brush the memory for ss->cache->layer_displacement_factor is only allocated when ss->cache->mirror_symmetry_pass == 0 && ss->cache->radial_symmetry_pass == 0 && ss->cache->first_time. The value of first_time is set to False in sculpt_stroke_update_step after the first execution.

do_layer_brush_task_cb_ex(void * userdata, const int n, const TaskParallelTLS * tls) Line 4116	C
BKE_pbvh_parallel_range(const int start, const int stop, void * userdata, void(*)(void *, const int, const TaskParallelTLS *) func, const PBVHParallelSettings * settings) Line 147	C++
do_layer_brush(Sculpt * sd, Object * ob, PBVHNode * * nodes, int totnode) Line 4176	C
do_brush_action(Sculpt * sd, Object * ob, Brush * brush, UnifiedPaintSettings * ups) Line 5371	C
do_tiled(Sculpt * sd, Object * ob, Brush * brush, UnifiedPaintSettings * ups, void(*)(Sculpt *, Object *, Brush *, UnifiedPaintSettings *) action) Line 5760	C
do_symmetrical_brush_actions(Sculpt * sd, Object * ob, void(*)(Sculpt *, Object *, Brush *, UnifiedPaintSettings *) action, UnifiedPaintSettings * ups) Line 5839	C
sculpt_stroke_update_step(bContext * C, PaintStroke * UNUSED_stroke, PointerRNA * itemptr) Line 7061	C
paint_brush_stroke_add_step(bContext * C, wmOperator * op, const float * mouse_in, float pressure) Line 623	C
paint_stroke_modal(bContext * C, wmOperator * op, const wmEvent * event) Line 1496	C
wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2006	C
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2788	C
wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2836	C
wm_event_do_handlers(bContext * C) Line 3231	C
WM_main(bContext * C) Line 453	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 526	C

When `ss->layer_base` is `NULL`, `use_persistent_base` is `false`, hence `disp_factor = &ss->cache->layer_displacement_factor[vi];` is used. However, `layer_displacement_factor` is `NULL` as well. In `do_layer_brush` the memory for `ss->cache->layer_displacement_factor` is only allocated when `ss->cache->mirror_symmetry_pass == 0 && ss->cache->radial_symmetry_pass == 0 && ss->cache->first_time`. The value of `first_time` is set to `False` in `sculpt_stroke_update_step` after the first execution. ``` do_layer_brush_task_cb_ex(void * userdata, const int n, const TaskParallelTLS * tls) Line 4116 C BKE_pbvh_parallel_range(const int start, const int stop, void * userdata, void(*)(void *, const int, const TaskParallelTLS *) func, const PBVHParallelSettings * settings) Line 147 C++ do_layer_brush(Sculpt * sd, Object * ob, PBVHNode * * nodes, int totnode) Line 4176 C do_brush_action(Sculpt * sd, Object * ob, Brush * brush, UnifiedPaintSettings * ups) Line 5371 C do_tiled(Sculpt * sd, Object * ob, Brush * brush, UnifiedPaintSettings * ups, void(*)(Sculpt *, Object *, Brush *, UnifiedPaintSettings *) action) Line 5760 C do_symmetrical_brush_actions(Sculpt * sd, Object * ob, void(*)(Sculpt *, Object *, Brush *, UnifiedPaintSettings *) action, UnifiedPaintSettings * ups) Line 5839 C sculpt_stroke_update_step(bContext * C, PaintStroke * UNUSED_stroke, PointerRNA * itemptr) Line 7061 C paint_brush_stroke_add_step(bContext * C, wmOperator * op, const float * mouse_in, float pressure) Line 623 C paint_stroke_modal(bContext * C, wmOperator * op, const wmEvent * event) Line 1496 C wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Line 2006 C wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2788 C wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2836 C wm_event_do_handlers(bContext * C) Line 3231 C WM_main(bContext * C) Line 453 C main(int argc, const unsigned char * * UNUSED_argv_c) Line 526 C ```

Brecht Van Lommel commented

2020-05-01 17:42:21 +02:00

Added subscriber: @JulianPerez

Pablo Dobarro commented

2020-05-05 17:15:24 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Pablo Dobarro closed this issue

2020-05-05 17:15:24 +02:00

Pablo Dobarro self-assigned this 2020-05-05 17:15:24 +02:00

Thomas Dinges added this to the 2.83 LTS milestone 2023-02-08 16:38:05 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash: Sculpt Layer brush + Stroke Method "Anchored" makes Blender crash #75743