Persistent Base Layer Brush doesnt work first time and after Undo #75797

New Issue

Matthias Pieroth · 2020-04-16T19:31:39+02:00

Matthias Pieroth commented

2020-04-16 19:31:39 +02:00

System Information
Operating system: Windows 10

Blender Version
2.83 master and 2.90 master
Commit: 47f46637be

Short description of error
When setting a persistent base for the new layer sculpting brush, then sculpt onto a mesh and undo, the persistent layer is deleted with the undo and the same happens when setting the persistent base the first time.

Exact steps for others to reproduce the error

Add a UV sphere and remesh in sculpt mode so that you can use the layer brush
Enable Persistent for the brush and press Set persistent base button
Sculpt with layer brush onto the mesh

sculpt a second time onto the mesh on a different area and then over the area where using the layer brush the first time:

It's not "merging the layer" correctly

Undo, set persistent base again and then sculpt

Then sculpt on a different area and the layers are merged:

After undo the sculptings so that we have a sphere again and then sculpt with layer brush, the persistent base is again lost:

**System Information** Operating system: Windows 10 **Blender Version** 2.83 master and 2.90 master Commit: 47f46637be1bef9672ede0ab6795a7e9ea97fc6a **Short description of error** When setting a persistent base for the new layer sculpting brush, then sculpt onto a mesh and undo, the persistent layer is deleted with the undo and the same happens when setting the persistent base the first time. **Exact steps for others to reproduce the error** 1. Add a UV sphere and remesh in sculpt mode so that you can use the layer brush 2. Enable **Persistent** for the brush and press **Set persistent base** button 3. Sculpt with layer brush onto the mesh ![image.png](https://archive.blender.org/developer/F8477183/image.png) 4. sculpt a second time onto the mesh on a different area and then over the area where using the layer brush the first time: **It's not "merging the layer" correctly** ![image.png](https://archive.blender.org/developer/F8477181/image.png) 5. Undo, set persistent base again and then sculpt ![image.png](https://archive.blender.org/developer/F8477185/image.png) 6. Then sculpt on a different area and the layers are merged: ![image.png](https://archive.blender.org/developer/F8477187/image.png) 7. After undo the sculptings so that we have a sphere again and then sculpt with layer brush, the persistent base is again lost: ![image.png](https://archive.blender.org/developer/F8477191/image.png)

Matthias Pieroth commented

2020-04-16 19:31:39 +02:00

Added subscriber: @Jayanam

Pablo Dobarro self-assigned this 2020-04-16 19:40:37 +02:00

Matthias Pieroth commented

2020-04-16 20:29:55 +02:00

@PabloDobarro : It seems to be due to remesh. Try this

Voxel Remesh
Set Persistent base
Sculpt the layer like described in the issue, then it happens, layers are not merged.

When You Set Persistent Base 2 times (2 times pressing the button after remesh) it doesnt happen, the layers are merged correctly.

@PabloDobarro : It seems to be due to remesh. Try this 1. Voxel Remesh 2. Set Persistent base 3. Sculpt the layer like described in the issue, then it happens, layers are not merged. When You Set Persistent Base 2 times (2 times pressing the button after remesh) it doesnt happen, the layers are merged correctly.

Ankit Meel commented

2020-04-18 17:43:31 +02:00

Added subscriber: @ankitm

Ankit Meel commented

2020-04-18 17:43:31 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Ankit Meel commented

2020-04-18 17:43:31 +02:00

confirmed due to the claim.

Antti Teittinen commented

2020-04-26 04:02:53 +02:00

Added subscriber: @funksy

Pablo Dobarro commented

2020-05-14 01:33:18 +02:00

I'm moving this to know issues for now because the proper fix will require a better design to store an mesh states like D6594. The issue is that the persistent layer info is freed with the PBVH to be sure that the current info matches the current sculpt geometry, so an PBVH rebuild deletes the persistent layer. The PBVH rebuilds with operations that change geomety like remeshing (it makes sense to delete the persistent layer in this case) but it also rebuilds in some other situation when it should not be needed, like changing mesh properties, certain undo steps or saving the file. Maybe we can fix this issue just by investigating all the not needed PBVH rebuilds that may happen (which should also be fixed to avoid performance problems), but I still think that the proper design for this will require mesh state storage management.

I'm moving this to know issues for now because the proper fix will require a better design to store an mesh states like [D6594](https://archive.blender.org/developer/D6594). The issue is that the persistent layer info is freed with the PBVH to be sure that the current info matches the current sculpt geometry, so an PBVH rebuild deletes the persistent layer. The PBVH rebuilds with operations that change geomety like remeshing (it makes sense to delete the persistent layer in this case) but it also rebuilds in some other situation when it should not be needed, like changing mesh properties, certain undo steps or saving the file. Maybe we can fix this issue just by investigating all the not needed PBVH rebuilds that may happen (which should also be fixed to avoid performance problems), but I still think that the proper design for this will require mesh state storage management.

s12a commented

2020-07-09 16:02:09 +02:00

Added subscriber: @s12a

s12a commented

2020-07-09 16:08:44 +02:00

I can confirm it happening on Blender 2.90 31bc76e. The Set Persistent Base button must be initially pressed twice in quick succession for the Persistent option to properly start working. Tested on the default sphere after starting Blender with the Sculpting workspace. I did not have to remesh the sphere.

I can confirm it happening on Blender 2.90 31bc76e. The *Set Persistent Base* button must be initially pressed twice in quick succession for the *Persistent* option to properly start working. Tested on the default sphere after starting Blender with the *Sculpting* workspace. I did not have to remesh the sphere.

Russell commented

2021-11-21 05:38:35 +01:00

Added subscriber: @Russ1642

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Persistent Base Layer Brush doesnt work first time and after Undo #75797