FCurves are only marked invalid after they have been shown in the UI #75926

Open
opened 2020-04-20 12:18:49 +02:00 by Sybren A. Stüvel · 2 comments

Blender Versions:
Broken in: all recent up to current master (0e7871f9c3). This is a long-standing issue.

Short Description:
Not all erroneous curves are shown when "Show Errors" is selected in the dope sheet.

Explanation:
FCurves can target an RNA path or an array index that is not valid in the current blend file. This includes things like animation data on bones that don't exist. There are legitimate reasons for such data to exist, for example when an Action is used by various compatible but slightly different armatures.

FCurves are marked as invalid when they are drawn in the channel list (FCURVE_DISABLED, set by getname_anim_fcurve() in anim_ipo_utils.c). As a result, when their name is not shown, for example when they are in a collapsed section of the channel list, their "invalid" status is not updated. As a result, using the "Show Errors" option in the Dopesheet will not show all errors.

Here is an example. Both groups "ORG-spine.002" and "ORG-spine.003" contain invalid channels.

image.png

image.png

Top: When all groups are collapsed in the graph editor, the dopesheet shows no errors at all.
Bottom: When a group is opened, and its channels listed in the graph editor, the dopesheet does show those channels. However, it still does not show the errors from the still-collapsed group.

#75926-example.blend

**Blender Versions:** Broken in: all recent up to current master (0e7871f9c3). This is a long-standing issue. **Short Description:** Not all erroneous curves are shown when "Show Errors" is selected in the dope sheet. **Explanation:** FCurves can target an RNA path or an array index that is not valid in the current blend file. This includes things like animation data on bones that don't exist. There are legitimate reasons for such data to exist, for example when an Action is used by various compatible but slightly different armatures. FCurves are marked as invalid when they are drawn in the channel list (`FCURVE_DISABLED`, set by `getname_anim_fcurve()` in [anim_ipo_utils.c](https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/animation/anim_ipo_utils.c)). As a result, when their name is not shown, for example when they are in a collapsed section of the channel list, their "invalid" status is not updated. As a result, using the "Show Errors" option in the Dopesheet will not show all errors. Here is an example. Both groups "ORG-spine.002" and "ORG-spine.003" contain invalid channels. ![image.png](https://archive.blender.org/developer/F8484958/image.png) ![image.png](https://archive.blender.org/developer/F8484960/image.png) **Top:** When all groups are collapsed in the graph editor, the dopesheet shows no errors at all. **Bottom:** When a group is opened, and its channels listed in the graph editor, the dopesheet does show those channels. However, it still does not show the errors from the still-collapsed group. [#75926-example.blend](https://archive.blender.org/developer/F8484965/T75926-example.blend)
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author
Member

Added subscribers: @dr.sybren, @zanqdo

Added subscribers: @dr.sybren, @zanqdo
Philipp Oeser removed the
Interest
Animation & Rigging
label 2023-02-09 14:36:14 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#75926
No description provided.