Shortcut Underline in menu under wrong letter or unclear #76152

New Issue

Johannes Kollmer · 2020-04-27T15:27:31+02:00

Johannes Kollmer commented

2020-04-27 15:27:31 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.97

Blender Version
Broken: version: 2.83 (sub 15), branch: master, commit date: 2020-04-26 22:51, hash: d0d16eb7d3
Worked: ?

Short description of error
In menus the letter which can be pressed to call a menu item is usually underlined. Sometimes the wrong letter is underlined or at least it is not clear which letter is underlined.
I think it is when the letter "i" is underlined. The underline starts exactly under the pixel of the "i" but continues into the next letter. I guess it is because the "i" is such a narrow letter.

Exact steps for others to reproduce the error

Select Object
Enter Edit mode
Hit "x" for delete menu
Look at the menu entry for "dissolve Edges and "dissolve Faces".
The shortcut for "dissolve Edges" is "i" and the shortcut for "dissolve Faces" is "s" but they both look allomost identical.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.97 **Blender Version** Broken: version: 2.83 (sub 15), branch: master, commit date: 2020-04-26 22:51, hash: `d0d16eb7d3` Worked: ? **Short description of error** In menus the letter which can be pressed to call a menu item is usually underlined. Sometimes the wrong letter is underlined or at least it is not clear which letter is underlined. I think it is when the letter "i" is underlined. The underline starts exactly under the pixel of the "i" but continues into the next letter. I guess it is because the "i" is such a narrow letter. **Exact steps for others to reproduce the error** 1. Select Object 2. Enter Edit mode 3. Hit "x" for delete menu 4. Look at the menu entry for "dissolve Edges and "dissolve Faces". 5. The shortcut for "dissolve Edges" is "i" and the shortcut for "dissolve Faces" is "s" but they both look allomost identical. ![underlinedLetterInMenu.png](https://archive.blender.org/developer/F8497541/underlinedLetterInMenu.png)

Johannes Kollmer commented

2020-04-27 15:27:31 +02:00

Added subscriber: @Lumpengnom-3

Harley Acheson commented

2020-04-28 02:42:43 +02:00

Added subscriber: @Harley

Harley Acheson commented

2020-04-28 02:42:43 +02:00

Yes, it can look a bit wonky at times and might be worth improving. We literally draw an underscore ("_") character at that character position (widget_draw_text() in interface_widgets.c). This means it is always the same width, so a constant weight, but doesn't always look as good as it could.

A nicer width would be the character width but with a minimum so an underlined 'I' isn't too narrow. Then centered of course.

The vertical position of underlines is not always trivial to guess though because of how different fonts can be. Our font renderer FreeType does provide this information (both underline position and underline thickness) somewhere in a font metrics structure in typography-specific units.

Yes, it can look a bit wonky at times and might be worth improving. We literally draw an underscore ("_") character at that character position (widget_draw_text() in interface_widgets.c). This means it is always the same width, so a constant weight, but doesn't always look as good as it could. A nicer width would be the character width but with a *minimum* so an underlined 'I' isn't too narrow. Then centered of course. The vertical position of underlines is not always trivial to guess though because of how different fonts can be. Our font renderer FreeType does provide this information (both underline position and underline thickness) somewhere in a font metrics structure in typography-specific units.

blender-admin commented

2020-04-28 05:30:59 +02:00

This issue was referenced by ef1187387b

This issue was referenced by ef1187387bda6ede146a366042e82890bc157127

Campbell Barton commented

2020-04-28 05:50:12 +02:00

Changed status from 'Needs Triage' to: 'Resolved'

Campbell Barton closed this issue

2020-04-28 05:50:12 +02:00

Campbell Barton self-assigned this 2020-04-28 05:50:12 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Shortcut Underline in menu under wrong letter or unclear #76152