Object disappared and glichted when switching between normal view and quad views #76216

New Issue

Le Giang · 2020-04-29T09:15:53+02:00

Le Giang commented

2020-04-29 09:15:53 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: Radeon (TM) RX 470 Graphics ATI Technologies Inc. 4.5.13587 Core Profile Context 20.4.1 26.20.15029.20013

Blender Version
Broken: version: 2.83 (sub 15), branch: master, commit date: 2020-04-28 20:40, hash: 05274ca829
Worked: 2.82a

Short description of error
Object disappared when switching between normal view and quad views, doing this repeatedly can cause:

selection outline always draws
sometimes geometry disappears
sometimes other overlays disappear [grid, lights, camera, ...]
sometimes geometry draws as if in xray

Object glichted sometimes when switching between normal view and quad views in the view port if viewport aa set to 32

Exact steps for others to reproduce the error
Object disappared

Object glichted

Debug logs
Object disappared
blender_debug_output.txt
blender_system_info.txt

Object glichted
blender_debug_output.txt
blender_system_info.txt

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: Radeon (TM) RX 470 Graphics ATI Technologies Inc. 4.5.13587 Core Profile Context 20.4.1 26.20.15029.20013 **Blender Version** Broken: version: 2.83 (sub 15), branch: master, commit date: 2020-04-28 20:40, hash: `05274ca829` Worked: 2.82a **Short description of error** Object disappared when switching between normal view and quad views, doing this repeatedly can cause: - selection outline always draws - sometimes geometry disappears - sometimes other overlays disappear [grid, lights, camera, ...] - sometimes geometry draws as if in xray Object glichted sometimes when switching between normal view and quad views in the view port if viewport aa set to 32 **Exact steps for others to reproduce the error** Object disappared ![bug_report_3_1.gif](https://archive.blender.org/developer/F8500638/bug_report_3_1.gif) Object glichted ![bug_report_3_2.gif](https://archive.blender.org/developer/F8500670/bug_report_3_2.gif) **Debug logs** Object disappared [blender_debug_output.txt](https://archive.blender.org/developer/F8501090/blender_debug_output.txt) [blender_system_info.txt](https://archive.blender.org/developer/F8501091/blender_system_info.txt) Object glichted [blender_debug_output.txt](https://archive.blender.org/developer/F8501092/blender_debug_output.txt) [blender_system_info.txt](https://archive.blender.org/developer/F8501093/blender_system_info.txt)

Le Giang commented

2020-04-29 09:15:53 +02:00

Added subscriber: @jangst.1024

Ankit Meel commented

2020-04-29 09:26:32 +02:00

Added subscriber: @ankitm

Ankit Meel commented

2020-04-29 09:26:32 +02:00

20.4.1

There's a 20.4.2 available. https://www.amd.com/en/support/graphics/radeon-400-series/radeon-rx-400-series/radeon-rx-470

> 20.4.1 There's a 20.4.2 available. https://www.amd.com/en/support/graphics/radeon-400-series/radeon-rx-400-series/radeon-rx-470

Le Giang commented

2020-04-29 10:17:16 +02:00

In #76216#919862, @ankitm wrote:

20.4.1

There's a 20.4.2 available. https://www.amd.com/en/support/graphics/radeon-400-series/radeon-rx-400-series/radeon-rx-470

it's still happens in the lastest driver

> In #76216#919862, @ankitm wrote: >> 20.4.1 > There's a 20.4.2 available. https://www.amd.com/en/support/graphics/radeon-400-series/radeon-rx-400-series/radeon-rx-470 it's still happens in the lastest driver

Ankit Meel commented

2020-04-29 14:15:54 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Ankit Meel commented

2020-04-29 14:15:54 +02:00

Please run Blender_debug_gpu.cmd, get the glitch & upload the two files it mentions.

Le Giang commented

2020-04-29 15:04:37 +02:00

In #76216#920072, @ankitm wrote:
Please run Blender_debug_gpu.cmd, get the glitch & upload the two files it mentions.

i attached the debug file in the task

> In #76216#920072, @ankitm wrote: > Please run Blender_debug_gpu.cmd, get the glitch & upload the two files it mentions. i attached the debug file in the task

Ankit Meel commented

2020-04-29 15:22:02 +02:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Philipp Oeser commented

2020-04-30 13:07:08 +02:00

Added subscribers: @fclem, @lichtwerk

Philipp Oeser commented

2020-04-30 13:07:08 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-04-30 13:07:08 +02:00

Can confirm.

Caused by c476c36e40

Might need a kick to wpd->view_updated = true (similar to 133bf05b18, a6dd22d431, ed44bb902d, 02f7a6b2bd ...)

CC @fclem

Can confirm. Caused by c476c36e40 Might need a kick to `wpd->view_updated = true` (similar to 133bf05b18, a6dd22d431, ed44bb902d, 02f7a6b2bd ...) CC @fclem

Philipp Oeser commented

2020-05-01 10:39:32 +02:00

What I mean is:
P1363: T76216_snippet



diff --git a/source/blender/draw/engines/workbench/workbench_data.c b/source/blender/draw/engines/workbench/workbench_data.c
index 2e8119fca2f..c71676d24b1 100644
--- a/source/blender/draw/engines/workbench/workbench_data.c
+++ b/source/blender/draw/engines/workbench/workbench_data.c
@@ -214,6 +214,13 @@ void workbench_private_data_init(WORKBENCH_PrivateData *wpd)
     rv3d->rflag &= ~RV3D_GPULIGHT_UPDATE;
   }
 
+  /* FIXME: This reproduce old behavior when workbench was separated in 2 engines.
+   * But this is a workaround for a missing update tagging. */
+  if ((rv3d != NULL) && (rv3d->viewlock_quad & RV3D_VIEWLOCK_INIT)) {
+    wpd->view_updated = true;
+    rv3d->viewlock_quad &= ~RV3D_VIEWLOCK_INIT;
+  }
+
   if (!v3d || (v3d->shading.type == OB_RENDER && BKE_scene_uses_blender_workbench(scene))) {
     /* FIXME: This reproduce old behavior when workbench was separated in 2 engines.
      * But this is a workaround for a missing update tagging from operators. */

(but of course, we shouldnt be messing with RV3D_VIEWLOCK_INIT like that...)

What I mean is: [P1363: T76216_snippet](https://archive.blender.org/developer/P1363.txt) ``` diff --git a/source/blender/draw/engines/workbench/workbench_data.c b/source/blender/draw/engines/workbench/workbench_data.c index 2e8119fca2f..c71676d24b1 100644 --- a/source/blender/draw/engines/workbench/workbench_data.c +++ b/source/blender/draw/engines/workbench/workbench_data.c @@ -214,6 +214,13 @@ void workbench_private_data_init(WORKBENCH_PrivateData *wpd) rv3d->rflag &= ~RV3D_GPULIGHT_UPDATE; } + /* FIXME: This reproduce old behavior when workbench was separated in 2 engines. + * But this is a workaround for a missing update tagging. */ + if ((rv3d != NULL) && (rv3d->viewlock_quad & RV3D_VIEWLOCK_INIT)) { + wpd->view_updated = true; + rv3d->viewlock_quad &= ~RV3D_VIEWLOCK_INIT; + } + if (!v3d || (v3d->shading.type == OB_RENDER && BKE_scene_uses_blender_workbench(scene))) { /* FIXME: This reproduce old behavior when workbench was separated in 2 engines. * But this is a workaround for a missing update tagging from operators. */ ``` (but of course, we shouldnt be messing with RV3D_VIEWLOCK_INIT like that...)

Jeroen Bakker commented

2020-05-08 09:45:09 +02:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2020-05-08 09:45:09 +02:00

Seems like 2 tickets in one. The glitch has been reported already so I assume this ticket is about the tagging...

I wasn't able to reproduce the quad view tagging issue on latest build. @lichtwerk do think this is a platform specific problem? If so I can try building this configuration. Just wanna check before spending much time building the configuration.

Tested myself on Linux AMD Vega64 and Windows Intel

Seems like 2 tickets in one. The glitch has been reported already so I assume this ticket is about the tagging... I wasn't able to reproduce the quad view tagging issue on latest build. @lichtwerk do think this is a platform specific problem? If so I can try building this configuration. Just wanna check before spending much time building the configuration. Tested myself on Linux AMD Vega64 and Windows Intel

Philipp Oeser commented

2020-05-08 10:54:04 +02:00

In #76216#926675, @Jeroen-Bakker wrote:
Seems like 2 tickets in one. The glitch has been reported already so I assume this ticket is about the tagging...

Mind sharing which the other report is?

I wasn't able to reproduce the quad view tagging issue on latest build. @lichtwerk do think this is a platform specific problem? If so I can try building this configuration. Just wanna check before spending much time building the configuration.

Cannot tell (I only have access to this one machine...) And I still have it on
System Information
Operating system: Linux-5.5.13-200.fc31.x86_64-x86_64-with-fedora-31-Thirty_One 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.64
version: 2.90 (sub 0), branch: master, commit date: 2020-05-08 03:43, hash: b4d50d3f07

> In #76216#926675, @Jeroen-Bakker wrote: > Seems like 2 tickets in one. The glitch has been reported already so I assume this ticket is about the tagging... Mind sharing which the other report is? > I wasn't able to reproduce the quad view tagging issue on latest build. @lichtwerk do think this is a platform specific problem? If so I can try building this configuration. Just wanna check before spending much time building the configuration. Cannot tell (I only have access to this one machine...) And I still have it on **System Information** Operating system: Linux-5.5.13-200.fc31.x86_64-x86_64-with-fedora-31-Thirty_One 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.64 version: 2.90 (sub 0), branch: master, commit date: 2020-05-08 03:43, hash: `b4d50d3f07`

Jeroen Bakker commented

2020-05-08 11:07:00 +02:00

@lichtwerk, seem that other tickets are for Intel and NVidia. perhaps we just split these tickets.