Compiler Error C1061 due to too many nested if/else in MANTA_main.cpp #76276

New Issue

Nikhil Shringarpurey · 2020-04-30T20:25:32+02:00

2020-04-30 20:25:32 +02:00

This bug was introduced by commit 21485e94. As a result, Blender can no longer be compiled on Windows after that commit.

When compiling in Windows (using Visual Studio 2017 or 2019), error C1061 results:

M:\BlenderSource\blender\intern\mantaflow\intern\MANTA_main.cpp(1003,11): fatal error C1061: compiler limit: blocks nested too deeply

This is due to the commit above adding more if/else clauses than 128 which exceeds the hard compiler limit for MSBuild. Also, this is a really inelegant block of string tests, and probably could use a cleanup/refactor anyway.

This bug was introduced by commit 21485e94. As a result, Blender can no longer be compiled on Windows after that commit. When compiling in Windows (using Visual Studio 2017 or 2019), error C1061 results: ``` M:\BlenderSource\blender\intern\mantaflow\intern\MANTA_main.cpp(1003,11): fatal error C1061: compiler limit: blocks nested too deeply ``` This is due to the commit above adding more if/else clauses than 128 which exceeds the hard compiler limit for MSBuild. Also, this is a really inelegant block of string tests, and probably could use a cleanup/refactor anyway.

Nikhil Shringarpurey commented

2020-04-30 20:25:32 +02:00

Added subscriber: @Nikhil.Net

Eitan Traurig commented

2020-04-30 20:27:59 +02:00

Added subscriber: @EitanSomething

Eitan Traurig commented

2020-04-30 20:27:59 +02:00

Can you post this on https://devtalk.blender.org.

Nikhil Shringarpurey commented

2020-04-30 20:30:38 +02:00

Roger - doing it now!

Nikhil Shringarpurey commented

2020-04-30 20:35:36 +02:00

Posted here: https://devtalk.blender.org/t/new-windows-compiler-error-introduced-by-mantaflow-change/12929

Ankit Meel commented

2020-04-30 20:37:09 +02:00

Added subscribers: @sebbas, @ankitm

Ankit Meel commented

2020-04-30 20:37:09 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Ankit Meel commented

2020-04-30 20:37:09 +02:00

It has been brought to @sebbas' attention.

blender-admin commented

2020-04-30 20:54:25 +02:00

This issue was referenced by 713ad9d971

This issue was referenced by 713ad9d9715a570627e762b16fda110476e3ba2b

Sebastián Barschkis commented

2020-04-30 20:55:21 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sebastián Barschkis closed this issue

2020-04-30 20:55:21 +02:00

Sebastián Barschkis self-assigned this 2020-04-30 20:55:21 +02:00

Nikhil Shringarpurey commented

2020-04-30 20:56:33 +02:00

This comment was removed by @Nikhil.Net

*This comment was removed by @Nikhil.Net*

Nikhil Shringarpurey commented

2020-04-30 21:56:20 +02:00

@sebbas I finished the code changes that would convert the long chain of if statements into a switch, which I think would be faster to execute. Since you had to remove the else statements, that means each if is getting evaluated per call to the function. Let me know if you'd like me to submit a pull request for you to review, or if there's a better way you want me to send for your review.

Also, feel free to tell me to take a hike if this is not worth doing - this is my first potential code submission and I am more than happy to fade to the background and submit at a later time.

@sebbas I finished the code changes that would convert the long chain of if statements into a switch, which I think would be faster to execute. Since you had to remove the else statements, that means each if is getting evaluated per call to the function. Let me know if you'd like me to submit a pull request for you to review, or if there's a better way you want me to send for your review. Also, feel free to tell me to take a hike if this is not worth doing - this is my first potential code submission and I am more than happy to fade to the background and submit at a later time.

Sebastián Barschkis commented

2020-04-30 21:56:43 +02:00

Added subscriber: @LazyDodo

Sebastián Barschkis commented

2020-04-30 21:56:43 +02:00

@Nikhil.Net Yes, if you have a patch that would certainly be helpful.
@LazyDodo Or did you already come up with a refactor?

@Nikhil.Net Yes, if you have a patch that would certainly be helpful. @LazyDodo Or did you already come up with a refactor?

Nikhil Shringarpurey commented

2020-04-30 22:01:55 +02:00

So, I do have a tested/working patch that would allow potentially unlimited values going forward with no need of nested if/else, but I regret to say I am a bit of a noob at submitting it. I'm reading thru the developer docs on it right now to get the process down.

Sebastián Barschkis commented

2020-04-30 22:14:29 +02:00

Ok, great. Instead of using arcanist (the tool to submit patches on phabricator) you can also upload the git diff output (can be done through "Submit Code" on the frontpage ). I can review it and commit on your behalf.

Ok, great. Instead of using arcanist (the tool to submit patches on phabricator) you can also upload the `git diff` output (can be done through "Submit Code" on the [frontpage ](https://developer.blender.org)). I can review it and commit on your behalf.

Ray molenkamp commented

2020-04-30 22:34:38 +02:00

i did have a refactor but i trashed it after i saw you already had a committed a fix

it pretty much turned

  if (varName == "USING_DISSOLVE")
    ss << (mmd->domain->flags & FLUID_DOMAIN_USE_DISSOLVE ? "True" : "False");
  else if (varName == "SOLVER_DIM")
    ss << mmd->domain->solver_res;
  etcetc

into

  if (varName == "USING_DISSOLVE")
   return (mmd->domain->flags & FLUID_DOMAIN_USE_DISSOLVE ? "True" : "False");
  if (varName == "SOLVER_DIM")
    return std::to_string(mmd->domain->solver_res);
  etcetc

i theoretically could see small perf increase since it's not doing all kinds of bogus string compares if the result is already known, but depending a bit on how often this is called, unsure if it will be a measurable

i did have a refactor but i trashed it after i saw you already had a committed a fix it pretty much turned ``` if (varName == "USING_DISSOLVE") ss << (mmd->domain->flags & FLUID_DOMAIN_USE_DISSOLVE ? "True" : "False"); else if (varName == "SOLVER_DIM") ss << mmd->domain->solver_res; etcetc ``` into ``` if (varName == "USING_DISSOLVE") return (mmd->domain->flags & FLUID_DOMAIN_USE_DISSOLVE ? "True" : "False"); if (varName == "SOLVER_DIM") return std::to_string(mmd->domain->solver_res); etcetc ``` i theoretically could see small perf increase since it's not doing all kinds of bogus string compares if the result is already known, but depending a bit on how often this is called, unsure if it will be a measurable

Nikhil Shringarpurey commented

2020-04-30 22:47:31 +02:00

@sebbas I have created the following diff and set you as a reviewer (I think I did that right): https://developer.blender.org/D7581

Thanks for feedback, and looking forward to your thoughts.

@sebbas I have created the following diff and set you as a reviewer (I think I did that right): https://developer.blender.org/D7581 Thanks for feedback, and looking forward to your thoughts.

Erick Tukuniata commented

2020-05-01 16:06:51 +02:00

Added subscriber: @ErickNyanduKabongo

Erick Tukuniata commented

2020-05-01 16:06:51 +02:00

Hello guys,

@LazyDodo Is this the same problem that i m having or should i start another thread in Devtalk?
Here is the full log in Pasteall > https://pasteall.org/im58

Thanks in advance for your help :)

Hello guys, @LazyDodo Is this the same problem that i m having or should i start another thread in Devtalk? Here is the full log in Pasteall > https://pasteall.org/im58 Thanks in advance for your help :)

Sebastián Barschkis commented

2020-05-01 16:09:22 +02:00

@ErickNyanduKabongo That's a different issue :)

Ray molenkamp commented

2020-05-01 16:10:33 +02:00

also already fixed.

Erick Tukuniata commented

2020-05-01 16:15:41 +02:00

Thanks :)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Compiler Error C1061 due to too many nested if/else in MANTA_main.cpp #76276