blender/blender

Linked collection with smoke simulation cached doesn't work #76401

New Issue

Closed

opened 2020-05-04 14:23:48 +02:00 by casimir perez · 10 comments

casimir perez commented

2020-05-04 14:23:48 +02:00

System Information
Operating system: Windows 10
Graphics card: RTX 2070 laptop

Blender Version
Broken: 2.82
Worked: IDK

Short description of error
Linked collection with smoke doesn't seems to load the cache properly or something.

Exact steps for others to reproduce the error

Create a scene with a quick effect smoke,
Save the file,
Bake the simulation.
Save the file again,
File -> New -> General
File -> Link the collection of the another file
The domain doesn't load the cache

**System Information** Operating system: Windows 10 Graphics card: RTX 2070 laptop **Blender Version** Broken: 2.82 Worked: IDK **Short description of error** Linked collection with smoke doesn't seems to load the cache properly or something. **Exact steps for others to reproduce the error** - Create a scene with a quick effect smoke, - Save the file, - Bake the simulation. - Save the file again, - File -> New -> General - File -> Link the collection of the another file The domain doesn't load the cache

casimir perez commented

2020-05-04 14:23:48 +02:00

Author

Added subscriber: @casimirp

Added subscriber: @casimirp

Germano Cavalcante commented

2020-05-05 14:14:12 +02:00

Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2020-05-05 14:16:36 +02:00

Member

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-05-05 14:16:36 +02:00

Member

@casimirp, I can confirm by linking the collection of another file but not when link the collection in another scene. So I edited the description.

@casimirp, I can confirm by linking the collection of another file but not when link the collection in another scene. So I edited the description.

Philipp Oeser removed the

Nodes & Physics

label 2023-02-10 08:46:49 +01:00

Lukas Tönne commented

2024-06-20 12:11:19 +02:00

Member

It looks like the fluid sim is loading the cache correctly, but the instancing code is not drawing/rendering the data. I'm not familiar with that code though.

It looks like the fluid sim is loading the cache correctly, but the instancing code is not drawing/rendering the data. I'm not familiar with that code though.

Lukas Tönne commented

2024-07-15 10:53:20 +02:00

Member

Had a closer look again: This appears to be a deliberate "feature" in the drawing code. The fluid sim cache is loaded correctly, but the drawing code explicitly disables drawing of volume data for instanced geometry. I do not know whether that's a design decision (less viewport clutter?), a technical limitation (duplicate smoke caches break perhaps?), or a simple oversight.

@fclem Do you know anything about this?

The !from_dupli here and below disables volume drawing:

		source/blender/draw/engines/overlay/overlay_extra.cc
		Line 1612 in 970ec097e3
	
				  const bool draw_volume = !from_dupli &&

Simply removing the flag does not fix it, there are probably other places checking this condition and/or technical reasons that smoke overlay cannot be shown for instances.

Had a closer look again: This appears to be a deliberate "feature" in the drawing code. The fluid sim cache is loaded correctly, but the drawing code explicitly disables drawing of volume data for instanced geometry. I do not know whether that's a design decision (less viewport clutter?), a technical limitation (duplicate smoke caches break perhaps?), or a simple oversight. @fclem Do you know anything about this? The `!from_dupli` here and below disables volume drawing: https://projects.blender.org/blender/blender/src/commit/970ec097e382d28d24923b5970f085591784b31b/source/blender/draw/engines/overlay/overlay_extra.cc#L1612 Simply removing the flag does not fix it, there are probably other places checking this condition and/or technical reasons that smoke overlay cannot be shown for instances.

Clément Foucault commented

2024-07-15 10:59:40 +02:00

Member

@LukasTonne This code is only for overlays. Which I think is wanted (we don't want the instanced objects to show data overlays). As to why it doesn't render by the render engine, that is a totally different question.

@LukasTonne This code is only for overlays. Which I think is wanted (we don't want the instanced objects to show data overlays). As to why it doesn't render by the render engine, that is a totally different question.

Lukas Tönne commented

2024-07-15 11:20:26 +02:00

Member

@fclem Ah sorry, i got that wrong. But looks like the workbench engine (and presumably others) also has a check like this to disable fluid drawing for instances:

		source/blender/draw/engines/workbench/workbench_engine.cc
		Line 130 in 970ec097e3
	
				    if (!(ob->base_flag & BASE_FROM_DUPLI)) {

I've traced it back to this ancient commit. It doesn't give any reasoning, not sure if it can be called a bug or not.
7a693626d6 (diff-def1a4647cacc16a16e0a5aa8ddfc7c032b35339)

@fclem Ah sorry, i got that wrong. But looks like the workbench engine (and presumably others) also has a check like this to disable fluid drawing for instances: https://projects.blender.org/blender/blender/src/commit/970ec097e382d28d24923b5970f085591784b31b/source/blender/draw/engines/workbench/workbench_engine.cc#L130 I've traced it back to this ancient commit. It doesn't give any reasoning, not sure if it can be called a bug or not. https://projects.blender.org/blender/blender/commit/7a693626d63a52acd12e80209b634711154a2f9d#diff-def1a4647cacc16a16e0a5aa8ddfc7c032b35339

Clément Foucault commented

2024-07-15 11:54:51 +02:00

Member

I have no idea then. Might just be legacy behavior. It might break older files badly if we change this behavior. The best way to instanciate fluid sim is through the volume object I think.

I have no idea then. Might just be legacy behavior. It might break older files badly if we change this behavior. The best way to instanciate fluid sim is through the volume object I think.

Lukas Tönne commented

2024-07-15 12:00:15 +02:00

Member

Ok, will consider it a feature then. At least it's neither a nodes nor a physics bug.

Ok, will consider it a feature then. At least it's neither a nodes nor a physics bug.

Lukas Tönne closed this issue

2024-07-15 12:00:21 +02:00

Blender Bot added

and removed

labels 2024-07-15 12:00:24 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#76401

No description provided.