Graph Editor: Fcurve extrapolation visibility #76472
Closed
opened 2020-05-06 12:15:25 +02:00 by Stanislav Ovcharov
·
31 comments
No Branch/Tag Specified
main
blender-v3.6-release
universal-scene-description
temp-sculpt-dyntopo
blender-v3.3-release
asset-browser-frontend-split
brush-assets-project
asset-shelf
anim/armature-drawing-refactor-3
temp-sculpt-dyntopo-hive-alloc
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-projects-basics
blender-v2.93-release
temp-sculpt-attr-api
realtime-clock
sculpt-dev
gpencil-next
bevelv2
microfacet_hair
xr-dev
principled-v2
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels
This issue affects/is about backward or forward compatibility
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Apply labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
This issue affects/is about backward or forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
10 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#76472
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
Tweak option to toggle off visibility of extrapolated f-curves.
Best place for 'Show extrapolation' command with on/off checkbox in the graph editor menu - View.
The option ‘Show extrapolation” is ON
Graph editor behavior is as usual. The option is ON by default.
The option ‘Show extrapolation” is OFF:
Then:
If the extrapolation part of the curves are shown they should be drawn a bit different (lower opacity or dotted) whether show_extrapolation option On or Off.
Single keys. They should be shown just as single keyframes in the graph.
The option ‘Show extrapolation” is Off. doesn't show extrapolated curves at all, whether it is a cycle, a linear extrapolation or a constant.
Examples:
And this are examples for possible improvements on next possible upgrades:
Constant extrapolation:
Added subscribers: @StanislavOvcharov, @dr.sybren, @LucianoMunoz
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @Oskar3d
A small suggestion. I think it would be useful if the extrapolation part of the curves is a drawn a bit different.(lower opacity, dotted, a bit tinner etc.) It gives a bit more information, so you know there are no keyframes prior or following what you see.

what oscar says would be highly appreciated.
Do you mean to use it with Linear and Cycle extrapolation types only when extrapolation is off?
only when the visibility of the extra is on, in anytype, to easily distinguish between the "live curve" and the generated one
So this thing should be used everywhere/everytime, with this new extrapolation option ON and OFF, shouldn't it? Not to replace new option?
Added subscriber: @antoine.grasset
Added subscriber: @RedMser
@StanislavOvcharov I agree that this would be nice. To make it possible to just implement it without getting more disucssions, can you pick the one you think is best and update the description & screenshots for this?
Once that's done, I think it's fine to get this implemented. @StanislavOvcharov do you have any idea how long it'll take you? Would Blender 2.92 be a reasonable target (so implemented, reviewed, and merged before 25 November)?
I think this all needs to be much simpler.
On: shows extrapolated curves.
Off. doesnt show extrapolated curves at all, wether it is a cycle, a linear extrapolation or a constant.
The whole idea is to be able to get rid of the extra drawing in the graph editor that makes it harder to view.
Wether we want theeming options for when the extrapolated curves are on I think its secondary (could be a slider for opacity).
Added subscriber: @1D_Inc
I think that information about surrounding extrapolated animation that allow to distinguish cycled animations types is important for editing.
I don't mind that about such simplifying if it speeds up implementation but what if you have e.g. cycles for some f-curves? you have to remember that you have got these cycles somewhere on your curves or toggle show_extrapolation on and off back and forth to check it. Described in the task variant allows you to toggle show_extrapolation once and forget about it and do you work in a more calm way
So it was chosen to implement first the simplest way, just on \ off.
On: shows extrapolated curves.
Off. doesn't show extrapolated curves at all, whether it is a cycle, a linear extrapolation or a constant.
Added subscriber: @wbmoss_dev
I'll see if I can finish a patch for the simple approach . The upgrades appear non-trivial as I'm not sure how to properly determine the fcurve extents when multiple fmodifiers exists and how they interact with eachother (cycles modifier, limits modifier, restricted ranges, etc).
Changed status from 'Confirmed' to: 'Resolved'
This comment was removed by @LucianoMunoz
Cool! but it's not resolved yet, isn't it?)
no he just started :)
but you closed it as resolved)
interesting, I didnt!, and i tried deleting that and i can only mark as resolved or invalid... can you gimme a hand here @dr.sybren ?
Changed status from 'Resolved' to: 'Confirmed'
When the design work is finished, and implementation can start, either one of these two should happen:
I think the 2nd option is the most suitable here, as it's not a huge amount of work that needs a separate task for tracking it.
The design description has this as 2nd sentence:
I don't see a motivation for this, though. Why is this the best spot? What makes this preferred over just having a user preference that sets this?
Is the description of this design task up to date with what's being implemented in {D10442}? If not, please @StanislavOvcharov or @wbmoss_dev update it so that any reviewers know how the code should behave.
Well it looks logical enough for me to place it here..

I would choose the option 1 because it is ready for master. And I would leave it even as it is. Looch is right when said that you should know \ remember all your fcurve cycles or linear extrapolation if exist. So there is no big need for further tweaks but I don't mind about it.
So I would edit and close it if you accept.
Ok, so it's a personal choice. That's fine, but it's better when it's actually been discussed & decided upon by more people in the module. The placement of the option also has implications as to where the option is stored, and how global it is.
An alternative would be to have this as a user preference. That has an impact on how teams of animators look at each others' files.
Not if there are still questions about the design.
I don't understand. Option 1 is "close this design task, create a new TODO task for the actual implementation". You can't leave this task as it is AND close it and create a new one.
I believe it should go in the view menu as it is an option that you'd often change, I'd rather it be off by default because just by having it off it improves readability in the graph editor and I'd turn it on just when I "NEED" to see the extrapolation which is how I normally do it in at work all the time, I only turn it on in rare occasions, because i need the graph editor to display as minimal and clear information as it can (its already a spaghetti mess, i don't want more stuff cluttering it)
Also this might mean a bit of a performance improvement by drawing less curves by default, but I dont know how true this las phrase is, i'm just speculating.
This issue was referenced by
dcd7dacc4f
Changed status from 'Confirmed' to: 'Resolved'