Confusing undo steps limit behavior #76642

Closed
opened 2020-05-11 12:22:52 +02:00 by Sergey Sharybin · 6 comments

System Information
Operating system: Linux-5.6.0-1-amd64-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.82

Blender Version
Broken: version: 2.90 (sub 0), branch: master, commit date: 2020-05-11 09:45, hash: 672a0af081
Worked: Was always somewhat confusing, even in 2.79

Short description of error

Limiting undo steps have an unexpected behavior, especially when mixing object/edit mode: it will allow to undo more steps than configured. For example, with 2 steps configured in the settings, it is possible to undo 3 steps in edit mode.

On top of that the last step seems to undo everything, bringing file to the opened state. Not sure what is the motivation behind this, but it feels confusing at least and might as well be dangerous.

Was actually pointed out by Max Dmitrichenko (@maxim_d33). Tried to dig into the code, but didn't really find any answers there.

Exact steps for others to reproduce the error

  • Open blender
  • Configure 2 undo steps in the preferences
  • Go to default cube's edit mode
  • Move all vertices 5 times
  • Start hitting undo: is it possible to undo 3 movement operations. Undoing one more time kicks out of edit mode, seemingly returning to the state when file was open.
**System Information** Operating system: Linux-5.6.0-1-amd64-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.82 **Blender Version** Broken: version: 2.90 (sub 0), branch: master, commit date: 2020-05-11 09:45, hash: `672a0af081` Worked: Was always somewhat confusing, even in 2.79 **Short description of error** Limiting undo steps have an unexpected behavior, especially when mixing object/edit mode: it will allow to undo more steps than configured. For example, with 2 steps configured in the settings, it is possible to undo 3 steps in edit mode. On top of that the last step seems to undo everything, bringing file to the opened state. Not sure what is the motivation behind this, but it feels confusing at least and might as well be dangerous. Was actually pointed out by Max Dmitrichenko (@maxim_d33). Tried to dig into the code, but didn't really find any answers there. **Exact steps for others to reproduce the error** - Open blender - Configure 2 undo steps in the preferences - Go to default cube's edit mode - Move all vertices 5 times - Start hitting undo: is it possible to undo 3 movement operations. Undoing one more time kicks out of edit mode, seemingly returning to the state when file was open.
Author
Owner

Added subscribers: @maxim_d33, @Sergey

Added subscribers: @maxim_d33, @Sergey

#73180 was marked as duplicate of this issue

#73180 was marked as duplicate of this issue

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

This issue was referenced by 815855b91b

This issue was referenced by 815855b91b9525e98894bcc61f6bafb6e205c86f

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Campbell Barton self-assigned this 2020-05-11 14:23:17 +02:00

Added subscribers: @Rengyr, @mont29, @mano-wii, @ideasman42

Added subscribers: @Rengyr, @mont29, @mano-wii, @ideasman42
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#76642
No description provided.