Grease Pencil Behavior changes Brush when going in and out of Drawing mode #76851

Closed
opened 2020-05-18 08:47:47 +02:00 by Piotr Nikov · 9 comments

System Information
Operating system: MacOs 10.15.4
Graphics card: AMD Radeon Pro 5500M 8 GB

Blender Version
Broken: 2.90 5c5a638b57 & 2.83 e5ace51295
Worked: 2.82a and 2.83 8956e9e5f6 (2020-05-11 19:18) - Unable to test other versions to pin point the exact version it broke.

Short description of error
Going in and out of drawing mode (to edit of object for example) changes brush to default Pencil as opposed to last brush used. Which is annoying because you constantly need to change it back when going back to Drawing mode.
Exact steps for others to reproduce the error
. Grease Pencil Drawing mode: Choose Ink Pen (Pencil being the default). Draw a Stroke.
. Go in Edit mode.
. Go back to Draw mode: the Brush is back to Pencil...

**System Information** Operating system: MacOs 10.15.4 Graphics card: AMD Radeon Pro 5500M 8 GB **Blender Version** Broken: 2.90 5c5a638b571a & 2.83 e5ace51295b9 Worked: 2.82a and 2.83 8956e9e5f6 (2020-05-11 19:18) - Unable to test other versions to pin point the exact version it broke. **Short description of error** Going in and out of drawing mode (to edit of object for example) changes brush to default Pencil as opposed to last brush used. Which is annoying because you constantly need to change it back when going back to Drawing mode. **Exact steps for others to reproduce the error** . Grease Pencil Drawing mode: Choose Ink Pen (Pencil being the default). Draw a Stroke. . Go in Edit mode. . Go back to Draw mode: the Brush is back to Pencil...
Author

Added subscriber: @Pyer

Added subscriber: @Pyer
Member

Added subscribers: @antoniov, @Alaska

Added subscribers: @antoniov, @Alaska
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

I've tested a few versions of Blender on Linux and here's what I've found out.
2.82a - No issues. As would be expected if this issue was caused by a recent patch to Blender 2.83/2.90.
2.83 8956e9e5f6 (2020-05-11 19:18) - No issues. This version is a week old. So it may of been in a more recent patch.
2.83 e5ace51295 (2020-05-15 17:29) - Issue is present. As per the report.
2.90 eaf7d36d66 (2020-05-15 19:12) - Issue is present. As to be expected.
2.90 5c5a638b57(2020-05-17 18:22) - Issue is present. As to be expected.

Based on this, we can assume that between the 11th of May and the 15th of May there was a patch (helpful for people bisecting the issue this helps - Sorry, I've had trouble with bisecting bugs. I will leave bisecting to someone else until I figure things out).

If I was to take a guess, e585257063 is the cause for the issue. Not 100% sure as I haven't bisected the version and don't understand the code. @antoniov What's your thoughts about this?

I've tested a few versions of Blender on Linux and here's what I've found out. 2.82a - No issues. As would be expected if this issue was caused by a recent patch to Blender 2.83/2.90. 2.83 `8956e9e5f6` (2020-05-11 19:18) - No issues. This version is a week old. So it may of been in a more recent patch. 2.83 `e5ace51295` (2020-05-15 17:29) - Issue is present. As per the report. 2.90 `eaf7d36d66` (2020-05-15 19:12) - Issue is present. As to be expected. 2.90 `5c5a638b57`(2020-05-17 18:22) - Issue is present. As to be expected. Based on this, we can assume that between the 11th of May and the 15th of May there was a patch (helpful for people bisecting the issue this helps - Sorry, I've had trouble with bisecting bugs. I will leave bisecting to someone else until I figure things out). If I was to take a guess, e585257063 is the cause for the issue. Not 100% sure as I haven't bisected the version and don't understand the code. @antoniov What's your thoughts about this?
Antonio Vazquez was assigned by Dalai Felinto 2020-05-18 12:59:46 +02:00

Yes, the bug is in that commit..I missed check the old brush.

Yes, the bug is in that commit..I missed check the old brush.

This issue was referenced by 0d57ab611c

This issue was referenced by 0d57ab611c643d75600ac961cdb807b95146c716

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Member

Thank you @antoniov

Thank you @antoniov
Author

That was very fast! Thanks so much!!

That was very fast! Thanks so much!!
Thomas Dinges added this to the 2.83 LTS milestone 2023-02-08 16:35:48 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#76851
No description provided.