Context menu for button does not display shortcuts with default value of properties #77839

New Issue

Yevgeny Makarov · 2020-06-13T19:24:30+02:00

Yevgeny Makarov commented

2020-06-13 19:24:30 +02:00

System Information
Operating system: Darwin-19.4.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.8.24

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-05 22:39, hash: b74cc23dc4
Worked: never

Short description of error
The context menu for button does not display some keyboard shortcuts, e.g. for "Insert Keyframe" or "Remove Driver".
Relates to the default value of properties.

**System Information** Operating system: Darwin-19.4.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.8.24 **Blender Version** Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-05 22:39, hash: `b74cc23dc4` Worked: never **Short description of error** The context menu for button does not display some keyboard shortcuts, e.g. for "Insert Keyframe" or "Remove Driver". Relates to the default value of properties. ![context_menu_for_button_shortcut_1.jpg](https://archive.blender.org/developer/F8616113/context_menu_for_button_shortcut_1.jpg) ![context_menu_for_button_shortcut_2.jpg](https://archive.blender.org/developer/F8616114/context_menu_for_button_shortcut_2.jpg)

Yevgeny Makarov commented

2020-06-13 19:24:30 +02:00

Added subscriber: @jenkm

Yevgeny Makarov commented

2020-06-14 00:08:14 +02:00

For example, if there are menu items:

lang=py
layout.operator("view3d.localview", text="Toggle Local View").frame_selected = False
layout.operator("view3d.localview", text="Toggle Local View (Frame Selected)").frame_selected = True

These hotkeys will be displayed in the menu:

lang=py
("view3d.localview", {"type": 'SLASH', "value": 'PRESS'},
 {"properties": [("frame_selected", False)]}),
("view3d.localview", {"type": 'SLASH', "value": 'PRESS', "alt": True},
 {"properties": [("frame_selected", True)]}),

But this one won't be displayed:

lang=py
("view3d.localview", {"type": 'SLASH', "value": 'PRESS'}, None),

For example, if there are menu items: ``` lang=py layout.operator("view3d.localview", text="Toggle Local View").frame_selected = False layout.operator("view3d.localview", text="Toggle Local View (Frame Selected)").frame_selected = True ``` These hotkeys will be displayed in the menu: ``` lang=py ("view3d.localview", {"type": 'SLASH', "value": 'PRESS'}, {"properties": [("frame_selected", False)]}), ("view3d.localview", {"type": 'SLASH', "value": 'PRESS', "alt": True}, {"properties": [("frame_selected", True)]}), ``` But this one won't be displayed: ``` lang=py ("view3d.localview", {"type": 'SLASH', "value": 'PRESS'}, None), ```

Germano Cavalcante commented

2020-06-16 16:13:32 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-06-16 16:13:32 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Germano Cavalcante commented

2020-06-16 16:13:32 +02:00

Thansk for the report but I don't understand what the bug is here.
Not all operators have shortcuts by default.

This report does not contain all the requested information, which is required for us to investigate the issue.
It's missing:

Exact steps to reproduce the bug.

*Guideline for making a good bug report: https:*wiki.blender.org/wiki/Process/Bug_Reports //

Thansk for the report but I don't understand what the bug is here. Not all operators have shortcuts by default. This report does not contain all the requested information, which is required for us to investigate the issue. It's missing: - Exact steps to reproduce the bug. ---- *Guideline for making a good bug report: https:*wiki.blender.org/wiki/Process/Bug_Reports //

Yevgeny Makarov commented

2020-06-16 16:35:02 +02:00

These are default shortcuts.

anim.keyframe_insert_button
anim.keyframe_delete_button
anim.keyframe_clear_button
anim.driver_button_remove
anim.driver_button_remove
anim.keyingset_button_add

They work but are not displayed in the button context menu:

If you explicitly set the parameter "All" to "True" (which is the same as the default value), the shortcuts will be displayed correctly:

These are default shortcuts. `anim.keyframe_insert_button` `anim.keyframe_delete_button` `anim.keyframe_clear_button` `anim.driver_button_remove` `anim.driver_button_remove` `anim.keyingset_button_add` They work but are not displayed in the button context menu: ![context_menu_for_button_shortcut_1.jpg](https://archive.blender.org/developer/F8616113/context_menu_for_button_shortcut_1.jpg) If you explicitly set the parameter "All" to "True" (which is the same as the default value), the shortcuts will be displayed correctly: ![context_menu_for_button_shortcut_2.jpg](https://archive.blender.org/developer/F8616114/context_menu_for_button_shortcut_2.jpg)

Germano Cavalcante commented

2020-06-16 17:20:01 +02:00

This is not really a bug. The operator on the shortcut has different properties than the button, see interface_context_menu.c$579 . (In the button the "all" property is set).
This is a property that can be changed in the Redo panel of some editors.

But it seems reasonable in this case to edit the default keymap to match those buttons.

diff --git a/release/scripts/presets/keyconfig/keymap_data/blender_default.py b/release/scripts/presets/keyconfig/keymap_data/blender_default.py
index bbbe520441c..1f5613c86bb 100644
--- a/release/scripts/presets/keyconfig/keymap_data/blender_default.py
+++ b/release/scripts/presets/keyconfig/keymap_data/blender_default.py
@@ -695,9 +695,12 @@ def km_user_interface(_params):
         ("ui.copy_data_path_button", {"type": 'C', "value": 'PRESS', "shift": True, "ctrl": True, "alt": True},
          {"properties": [("full_path", True)]}),
         # Keyframes and drivers
-        ("anim.keyframe_insert_button", {"type": 'I', "value": 'PRESS'}, None),
-        ("anim.keyframe_delete_button", {"type": 'I', "value": 'PRESS', "alt": True}, None),
-        ("anim.keyframe_clear_button", {"type": 'I', "value": 'PRESS', "shift": True, "alt": True}, None),
+        ("anim.keyframe_insert_button", {"type": 'I', "value": 'PRESS'},
+         {"properties": [("all", True)]}),
+        ("anim.keyframe_delete_button", {"type": 'I', "value": 'PRESS', "alt": True},
+         {"properties": [("all", True)]}),
+        ("anim.keyframe_clear_button", {"type": 'I', "value": 'PRESS', "shift": True, "alt": True},
+         {"properties": [("all", True)]}),
         ("anim.driver_button_add", {"type": 'D', "value": 'PRESS', "ctrl": True}, None),
         ("anim.driver_button_remove", {"type": 'D', "value": 'PRESS', "ctrl": True, "alt": True}, None),
         ("anim.keyingset_button_add", {"type": 'K', "value": 'PRESS'}, None),

This is something for the Animation team to decide.

This is not really a bug. The operator on the shortcut has different properties than the button, see [interface_context_menu.c$579 ](https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_context_menu.c$579). (In the button the `"all"` property is set). This is a property that can be changed in the Redo panel of some editors. But it seems reasonable in this case to edit the default keymap to match those buttons. ``` diff --git a/release/scripts/presets/keyconfig/keymap_data/blender_default.py b/release/scripts/presets/keyconfig/keymap_data/blender_default.py index bbbe520441c..1f5613c86bb 100644 --- a/release/scripts/presets/keyconfig/keymap_data/blender_default.py +++ b/release/scripts/presets/keyconfig/keymap_data/blender_default.py @@ -695,9 +695,12 @@ def km_user_interface(_params): ("ui.copy_data_path_button", {"type": 'C', "value": 'PRESS', "shift": True, "ctrl": True, "alt": True}, {"properties": [("full_path", True)]}), # Keyframes and drivers - ("anim.keyframe_insert_button", {"type": 'I', "value": 'PRESS'}, None), - ("anim.keyframe_delete_button", {"type": 'I', "value": 'PRESS', "alt": True}, None), - ("anim.keyframe_clear_button", {"type": 'I', "value": 'PRESS', "shift": True, "alt": True}, None), + ("anim.keyframe_insert_button", {"type": 'I', "value": 'PRESS'}, + {"properties": [("all", True)]}), + ("anim.keyframe_delete_button", {"type": 'I', "value": 'PRESS', "alt": True}, + {"properties": [("all", True)]}), + ("anim.keyframe_clear_button", {"type": 'I', "value": 'PRESS', "shift": True, "alt": True}, + {"properties": [("all", True)]}), ("anim.driver_button_add", {"type": 'D', "value": 'PRESS', "ctrl": True}, None), ("anim.driver_button_remove", {"type": 'D', "value": 'PRESS', "ctrl": True, "alt": True}, None), ("anim.keyingset_button_add", {"type": 'K', "value": 'PRESS'}, None), ``` This is something for the `Animation` team to decide.

Germano Cavalcante commented

2020-06-16 17:20:54 +02:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Sybren A. Stüvel commented

2020-06-16 17:55:07 +02:00

Added subscribers: @JulianEisel, @dr.sybren

Sybren A. Stüvel commented

2020-06-16 17:55:07 +02:00

I know pretty much nothing about keymaps. What does {"properties": [("all", True)]} do, and how is it different from None? @JulianEisel can you maybe shed some light on this?

I know pretty much nothing about keymaps. What does `{"properties": [("all", True)]}` do, and how is it different from `None`? @JulianEisel can you maybe shed some light on this?

Germano Cavalcante commented

2020-06-16 18:12:18 +02:00

As I understand it, None in this field means that no property value is set for the operator of that keyitem.
This means that the last property that is defined will remain the next time you call the operator via the shortcut.
(Some properties can be changed in fields such as the operator's Redo Panel).

But taking a closer look, those operators don't even have Redo Panel. So I don't think there will be any changes in the user's point of view.
If this is the case then there is no problem applying this change just to display the shortcut in the context menu.

(It is not a bug. It's just a small visual inconvenience).

As I understand it, `None` in this field means that no property value is set for the operator of that keyitem. This means that the last property that is defined will remain the next time you call the operator via the shortcut. (Some properties can be changed in fields such as the operator's Redo Panel). But taking a closer look, those operators don't even have Redo Panel. So I don't think there will be any changes in the user's point of view. If this is the case then there is no problem applying this change just to display the shortcut in the context menu. (It is not a bug. It's just a small visual inconvenience).

blender-admin commented

2020-06-17 21:21:23 +02:00

This issue was referenced by a874cec02b

This issue was referenced by a874cec02bbacb27602168328041773f69b6c121

Germano Cavalcante commented

2020-06-17 21:31:04 +02:00

Changed status from 'Needs Triage' to: 'Resolved'

Germano Cavalcante closed this issue

2020-06-17 21:31:04 +02:00

Germano Cavalcante self-assigned this 2020-06-17 21:31:04 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Context menu for button does not display shortcuts with default value of properties #77839