Blender 2.83 OSL microfacet closure not recognized #77915

Closed
opened 2020-06-16 15:47:51 +02:00 by Oded Erell · 5 comments

System Information
Operating system:
Windows 10 64bit
Graphics card:
Nvidia Gtx1070

Blender Version
Broken: 2.83
Worked: 2.82

Short description of error
OSL microfacet closure not recognized.
The shaders compile withour error,
But when rendering the microfacet closure returns 0,
And an error is reported in the system console:
Closure ‘microfacet’ is not supported by the current renderer

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).
This OSL code renders black and outputs the error:

surface testGGX
(
	color refColor = color(1.0,0.5,0.0),
	output closure color bsdf = 0
)
{
	bsdf = microfacet ("ggx", N, (0,0,1), 0.1, 0.1, 0, 0) * refColor;
}

Note:
I did a comparison of the OSL stdosl.h and oslutil.h source files with the ones in 2.82 and there are many differences.
Copying these 2 files from Blender 2.82 to 2.83 seem to fix the problem.
It also should be noted that .oso files compiled using previous versions do render properly.
Only .oso files compiled with 2.83 have the problem.

Thanks!
Oded

**System Information** Operating system: Windows 10 64bit Graphics card: Nvidia Gtx1070 **Blender Version** Broken: 2.83 Worked: 2.82 **Short description of error** OSL microfacet closure not recognized. The shaders compile withour error, But when rendering the microfacet closure returns 0, And an error is reported in the system console: Closure ‘microfacet’ is not supported by the current renderer **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). This OSL code renders black and outputs the error: ``` surface testGGX ( color refColor = color(1.0,0.5,0.0), output closure color bsdf = 0 ) { bsdf = microfacet ("ggx", N, (0,0,1), 0.1, 0.1, 0, 0) * refColor; } ``` Note: I did a comparison of the OSL stdosl.h and oslutil.h source files with the ones in 2.82 and there are many differences. Copying these 2 files from Blender 2.82 to 2.83 seem to fix the problem. It also should be noted that .oso files compiled using previous versions do render properly. Only .oso files compiled with 2.83 have the problem. Thanks! Oded
Author

Added subscriber: @Oded_Erell

Added subscriber: @Oded_Erell

This issue was referenced by 465d5c018e

This issue was referenced by 465d5c018ee0267cfff8648599a4ad543ab216a7

This issue was referenced by blender/cycles@3746a6adb9

This issue was referenced by blender/cycles@3746a6adb95039e2bee234bc19eac53f4f90aa72

This issue was referenced by 25b8dedfb4

This issue was referenced by 25b8dedfb4856a5573311ee309bbef3c96830d09

Changed status from 'Needs Triage' to: 'Resolved'

Changed status from 'Needs Triage' to: 'Resolved'
Brecht Van Lommel self-assigned this 2020-06-17 14:09:52 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#77915
No description provided.