Enable/disable logger from Info Editor #78223

New Issue

Mateusz Grzeliński · 2020-06-24T21:09:07+02:00

2020-06-24 21:09:07 +02:00

Status: Task has been abandoned. This feature is only nice to have, but there is no clean solution to implement or it requires a lot of changes in code

Description
Currently loggers can be enables/disables only via regex in command line arguments. Exposing them in list like menu will make life easier.

Design:

List borrowed from UV map menu:
Desired behaviour:
user can filter visible loggers per info editorEngineer plan:**
Currently:
loggers are enabled/diasabled only based on regex (see clg_ctx_filter_check) active loggers are stored in CLogContext (ctx->types)
** loggers are dynamic, and lazy evaluated, that is why it is not possible to know list all known loggers

Work plan

I need feedback how to:

- convert regex based exclude filter to flag-like mask
- list all possigle loggers in static (precompiled) way
- connect list of loggers with UI list

**Status:** Task has been abandoned. This feature is only nice to have, but there is no clean solution to implement or it requires a lot of changes in code **Description** Currently loggers can be enables/disables only via regex in command line arguments. Exposing them in list like menu will make life easier. **Design:** * List borrowed from UV map menu: ![obraz.png](https://archive.blender.org/developer/F8640923/obraz.png) * Desired behaviour: **user can filter visible loggers per info editor**Engineer plan:** * Currently: **loggers are enabled/diasabled only based on regex (see `clg_ctx_filter_check`)** active loggers are stored in `CLogContext` (`ctx->types`) ** loggers are dynamic, and lazy evaluated, that is why it is not possible to know list all known loggers **Work plan** I need feedback how to: - - [ ] convert regex based exclude filter to flag-like mask - - [ ] list all possigle loggers in static (precompiled) way - - [ ] connect list of loggers with UI list

Mateusz Grzeliński self-assigned this 2020-06-24 21:09:07 +02:00

Mateusz Grzeliński commented

2020-06-24 21:09:07 +02:00

Added subscribers: @grzelins, @mont29

Mateusz Grzeliński commented

2020-07-24 12:29:20 +02:00

Added subscriber: @ideasman42

Mateusz Grzeliński commented

2020-07-24 12:29:20 +02:00

Listing all possible loggers is problematic.
The obvious solution to this is some kind of register/unregister mechanism. Unfortunately all of loggers are defined as static CLG_LogRef LOG = {"bke.anim_sys"}; what makes it very convienient to use, but impossible to register dynamically. If we want to keep the curent paradigm od logging, I can see 2 solutions:

preprocess codebase and gather all usagas of CLG_LogRef and create static list of loggers (similar to makesdna)
manually create list of loggers, something like this: static CLG_LogRef loggers- [ ] = {{.identifier = "bke.anim_sys", .doc_str = "usefull doc"}};. The usage would look similar to: static CLG_LogRef *LOG = CLG_get("bke.anim_sys");

@ideasman42 can I have your thoughts on this? Both solutions are not ideal, I already talked to @mont29

Listing all possible loggers is problematic. The obvious solution to this is some kind of register/unregister mechanism. Unfortunately all of loggers are defined as `static CLG_LogRef LOG = {"bke.anim_sys"};` what makes it very convienient to use, but impossible to register dynamically. If we want to keep the curent paradigm od logging, I can see 2 solutions: 1) preprocess codebase and gather all usagas of `CLG_LogRef` and create static list of loggers (similar to `makesdna`) 2) manually create list of loggers, something like this: `static CLG_LogRef loggers- [ ] = {{.identifier = "bke.anim_sys", .doc_str = "usefull doc"}};`. The usage would look similar to: `static CLG_LogRef *LOG = CLG_get("bke.anim_sys");` @ideasman42 can I have your thoughts on this? Both solutions are not ideal, I already talked to @mont29

Philipp Oeser commented

2021-09-21 16:27:09 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-09-21 16:27:09 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-09-21 16:27:10 +02:00

Same as #80072 (Create python API for CLOG), this needs a decision if this should confirmed/on the roadmap or not.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Enable/disable logger from Info Editor #78223