Crash with Assign Shortcut (if operator_context = EXEC_DEFAULT) #78346

Closed
opened 2020-06-27 09:56:01 +02:00 by Yevgeny Makarov · 6 comments

System Information
Operating system: Darwin-19.4.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.8.24

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-18 19:05, hash: b89898cbd3
Broken: 2.81a, 2.82a, 2.83.0

Short description of error
Crash when assign "A" shortcut (not other keys) using the "Assign Shortcut" on some menu items.

Exact steps for others to reproduce the error

  • Object Mode > Object Menu > "Delete" or "Delete Global"
  • right click > "Assign Shortcut"
  • press "A" key (not others)
  • again, right click > "Assign Shortcut"
  • crash

You may notice that these menus do not display the shortcut. #60887

It has something to do with the layout.operator_context = 'EXEC_DEFAULT'.

Other menu items in the EXEC_DEFAULT will also be crash with this steps
and not display the assigned shortcut.

**System Information** Operating system: Darwin-19.4.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.8.24 **Blender Version** Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-18 19:05, hash: `b89898cbd3` Broken: 2.81a, 2.82a, 2.83.0 **Short description of error** Crash when assign "A" shortcut (not other keys) using the "Assign Shortcut" on some menu items. **Exact steps for others to reproduce the error** - Object Mode > Object Menu > "Delete" or "Delete Global" - right click > "Assign Shortcut" - press "A" key (**not others**) - **again**, right click > "Assign Shortcut" - crash You may notice that these menus do not display the shortcut. #60887 It has something to do with the `layout.operator_context = 'EXEC_DEFAULT'`. Other menu items in the `EXEC_DEFAULT` will also be crash with this steps and not display the assigned shortcut.
Author
Member

Added subscriber: @jenkm

Added subscriber: @jenkm

Added subscriber: @iss

Added subscriber: @iss

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Exception thrown: read access violation. kmi was nullptr.

>	blender.exe!WM_keymap_item_map_type_get(const wmKeyMapItem * kmi) Line 205	C

 	blender.exe!rna_wmKeyMapItem_map_type_get(PointerRNA * ptr) Line 876	C
 	blender.exe!rna_KeyMapItem_type_itemf(bContext * UNUSED_C, PointerRNA * ptr, PropertyRNA * UNUSED_prop, bool * UNUSED_r_free) Line 938	C
 	blender.exe!RNA_property_enum_items_ex(bContext * C, PointerRNA * ptr, PropertyRNA * prop, const bool use_static, const EnumPropertyItem * * r_item, int * r_totitem, bool * r_free) Line 1612	C
 	blender.exe!RNA_property_enum_items(bContext * C, PointerRNA * ptr, PropertyRNA * prop, const EnumPropertyItem * * r_item, int * r_totitem, bool * r_free) Line 1644	C
 	blender.exe!RNA_property_enum_items_gettexted(bContext * C, PointerRNA * ptr, PropertyRNA * prop, const EnumPropertyItem * * r_item, int * r_totitem, bool * r_free) Line 1713	C
 	blender.exe!ui_item_rna_size(uiLayout * layout, const unsigned char * name, int icon, PointerRNA * ptr, PropertyRNA * prop, int index, bool icon_only, bool compact, int * r_w, int * r_h) Line 1815	C
 	blender.exe!uiItemFullR(uiLayout * layout, PointerRNA * ptr, PropertyRNA * prop, int index, int value, int flag, const unsigned char * name, int icon) Line 2106	C
 	blender.exe!uiItemR(uiLayout * layout, PointerRNA * ptr, const unsigned char * propname, int flag, const unsigned char * name, int icon) Line 2394	C
 	blender.exe!menu_add_shortcut(bContext * C, ARegion * region, void * arg) Line 269	C
 	blender.exe!ui_popup_block_refresh(bContext * C, uiPopupBlockHandle * handle, ARegion * butregion, uiBut * but) Line 595	C
 	blender.exe!ui_popup_block_create(bContext * C, ARegion * butregion, uiBut * but, uiBlock *(*)(bContext *, ARegion *, void *) create_func, uiBlock *(*)(bContext *, uiPopupBlockHandle *, void *) handle_create_func, void * arg, void(*)(void *) arg_free) Line 832	C
 	blender.exe!UI_popup_block_ex(bContext * C, uiBlock *(*)(bContext *, ARegion *, void *) func, void(*)(bContext *, void *, int) popup_func, void(*)(bContext *, void *) cancel_func, void * arg, wmOperator * op) Line 630	C
 	blender.exe!popup_add_shortcut_func(bContext * C, void * arg1, void * UNUSED_arg2) Line 336	C
 	blender.exe!ui_apply_but_funcs_after(bContext * C) Line 921	C
 	blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Line 10898	C
 	blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Line 622	C
 	blender.exe!wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2743	C
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2854	C
 	blender.exe!wm_event_do_handlers(bContext * C) Line 3283	C
 	blender.exe!WM_main(bContext * C) Line 478	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 534	C
 	[External Code]	

`Exception thrown: read access violation. kmi was nullptr.` ``` > blender.exe!WM_keymap_item_map_type_get(const wmKeyMapItem * kmi) Line 205 C blender.exe!rna_wmKeyMapItem_map_type_get(PointerRNA * ptr) Line 876 C blender.exe!rna_KeyMapItem_type_itemf(bContext * UNUSED_C, PointerRNA * ptr, PropertyRNA * UNUSED_prop, bool * UNUSED_r_free) Line 938 C blender.exe!RNA_property_enum_items_ex(bContext * C, PointerRNA * ptr, PropertyRNA * prop, const bool use_static, const EnumPropertyItem * * r_item, int * r_totitem, bool * r_free) Line 1612 C blender.exe!RNA_property_enum_items(bContext * C, PointerRNA * ptr, PropertyRNA * prop, const EnumPropertyItem * * r_item, int * r_totitem, bool * r_free) Line 1644 C blender.exe!RNA_property_enum_items_gettexted(bContext * C, PointerRNA * ptr, PropertyRNA * prop, const EnumPropertyItem * * r_item, int * r_totitem, bool * r_free) Line 1713 C blender.exe!ui_item_rna_size(uiLayout * layout, const unsigned char * name, int icon, PointerRNA * ptr, PropertyRNA * prop, int index, bool icon_only, bool compact, int * r_w, int * r_h) Line 1815 C blender.exe!uiItemFullR(uiLayout * layout, PointerRNA * ptr, PropertyRNA * prop, int index, int value, int flag, const unsigned char * name, int icon) Line 2106 C blender.exe!uiItemR(uiLayout * layout, PointerRNA * ptr, const unsigned char * propname, int flag, const unsigned char * name, int icon) Line 2394 C blender.exe!menu_add_shortcut(bContext * C, ARegion * region, void * arg) Line 269 C blender.exe!ui_popup_block_refresh(bContext * C, uiPopupBlockHandle * handle, ARegion * butregion, uiBut * but) Line 595 C blender.exe!ui_popup_block_create(bContext * C, ARegion * butregion, uiBut * but, uiBlock *(*)(bContext *, ARegion *, void *) create_func, uiBlock *(*)(bContext *, uiPopupBlockHandle *, void *) handle_create_func, void * arg, void(*)(void *) arg_free) Line 832 C blender.exe!UI_popup_block_ex(bContext * C, uiBlock *(*)(bContext *, ARegion *, void *) func, void(*)(bContext *, void *, int) popup_func, void(*)(bContext *, void *) cancel_func, void * arg, wmOperator * op) Line 630 C blender.exe!popup_add_shortcut_func(bContext * C, void * arg1, void * UNUSED_arg2) Line 336 C blender.exe!ui_apply_but_funcs_after(bContext * C) Line 921 C blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Line 10898 C blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Line 622 C blender.exe!wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2743 C blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2854 C blender.exe!wm_event_do_handlers(bContext * C) Line 3283 C blender.exe!WM_main(bContext * C) Line 478 C blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 534 C [External Code] ```

This issue was referenced by 10590b0500

This issue was referenced by 10590b0500c95d124d00f95e5eefbc7107e3ba5e
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Julian Eisel self-assigned this 2020-08-03 18:26:36 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#78346
No description provided.