Switching Curve Shapekeys in Edit Mode go haywire if relative to one another #78701

New Issue

Sven Hollesen · 2020-07-07T12:55:06+02:00

Sven Hollesen commented

2020-07-07 12:55:06 +02:00

System Information
Operating system:
Linux

Blender Version
Broken in 2.79 onwards
Worked in 2.78

Possibly caused by
6f1493f68f
5e1d4714fe

Short description of error
Shapekeys on curves do not reset properly when switching between them in edit mode, and one shapekey is relative to another.

Exact steps for others to reproduce the error
Select the circle and enter edit mode. Repeatedly switch between shapekeys 'Key 1' and 'Key 2' while staying in edit mode. 'Key 2' will change over time from just this.
bug_report_shapekeys_curve.blend

How to reproduce the scene
Create a Curve object. Add Basis, Key 1, Key 2 shapekeys. Set 'Key 2' relative to 'Key 1'. Select 'Key 1' and translate/scale it.

**System Information** Operating system: Linux **Blender Version** Broken in 2.79 onwards Worked in 2.78 Possibly caused by 6f1493f68f 5e1d4714fe **Short description of error** Shapekeys on curves do not reset properly when switching between them in edit mode, and one shapekey is relative to another. **Exact steps for others to reproduce the error** Select the circle and enter edit mode. Repeatedly switch between shapekeys 'Key 1' and 'Key 2' while staying in edit mode. 'Key 2' will change over time from just this. [bug_report_shapekeys_curve.blend](https://archive.blender.org/developer/F8675243/bug_report_shapekeys_curve.blend) **How to reproduce the scene** Create a Curve object. Add Basis, Key 1, Key 2 shapekeys. Set 'Key 2' relative to 'Key 1'. Select 'Key 1' and translate/scale it.

Sven Hollesen commented

2020-07-07 12:55:06 +02:00

Added subscriber: @kiriri-1

blender-admin commented

2020-07-07 12:55:06 +02:00

#81322 was marked as duplicate of this issue

Philipp Oeser commented

2020-07-07 14:22:27 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-07-07 14:22:27 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-07-07 14:22:27 +02:00

Can confirm, this dates back to 2.79 even.

Philipp Oeser commented

2020-07-08 11:41:44 +02:00

Added subscriber: @mont29

Philipp Oeser commented

2020-07-08 11:41:44 +02:00

Probably related to
6f1493f68f
5e1d4714fe

rna_Object_active_shape_update also calls ED_curve_editnurb_load / calc_shapeKeys, that might cause the unwanted sideeffects?
(not sure if it should restore to editcurve in that case? -- had a quick try, without luck though.)

@mont29 might be more familiar here?

Probably related to 6f1493f68f 5e1d4714fe `rna_Object_active_shape_update` also calls `ED_curve_editnurb_load` / `calc_shapeKeys`, that might cause the unwanted sideeffects? (not sure if it should restore to editcurve in that case? -- had a quick try, without luck though.) @mont29 might be more familiar here?

Sven Hollesen commented

2020-07-08 13:02:55 +02:00

The cause is indeed in calc_shapeKeys . Another related bug : Modifying 'Key 1' if 'Key 2' is related to 'Key 1' and 'Key 3' is related to 'Key2' will not modify 'Key 3' at all, unless 'Key 2' has been selected after 'Key 1'.
There's a fundamental design flaw in the first part of calc_shapeKeys, where it only checks directly related keys for updates. I don't want to open a new report for this, since it's the same code that's causing it.

The cause is indeed in calc_shapeKeys . Another related bug : Modifying 'Key 1' if 'Key 2' is related to 'Key 1' and 'Key 3' is related to 'Key2' will not modify 'Key 3' at all, unless 'Key 2' has been selected after 'Key 1'. There's a fundamental design flaw in the first part of calc_shapeKeys, where it only checks directly related keys for updates. I don't want to open a new report for this, since it's the same code that's causing it.

Sven Hollesen commented

2020-07-08 19:59:20 +02:00

I have a fix for the transitivity problem I mentioned today.
Still don't understand what's causing the initial issue though.
I can provide a patch if the initial issue gets solved.

I have a fix for the transitivity problem I mentioned today. Still don't understand what's causing the initial issue though. I can provide a patch if the initial issue gets solved.

Sven Hollesen self-assigned this 2020-07-10 20:15:55 +02:00

Sven Hollesen commented

2020-07-10 20:15:55 +02:00

This issue is a bottleneck for our current project. I'm rewriting calc_shapeKeys from the ground up and have a working prototype. I don't think a simple fix would cut it.

Philipp Oeser commented

2020-07-10 20:56:06 +02:00

In #78701#976971, @kiriri-1 wrote:
This issue is a bottleneck for our current project. I'm rewriting calc_shapeKeys from the ground up and have a working prototype. I don't think a simple fix would cut it.

That is great to hear [the fact that you have working version - not so that you ran into this issue in the first place].
If you think you can share, please post a diff.

> In #78701#976971, @kiriri-1 wrote: > This issue is a bottleneck for our current project. I'm rewriting calc_shapeKeys from the ground up and have a working prototype. I don't think a simple fix would cut it. That is great to hear [the fact that you have working version - not so that you ran into this issue in the first place]. If you think you can share, please post a diff.

Philipp Oeser commented

2020-09-30 12:03:41 +02:00

Added subscriber: @NKO

Sven Hollesen commented

2021-02-01 14:29:37 +01:00

curve_haywire_fix.diff
Some relevant code comments claim issues with animation if the changes in this patch were to be applied. I assume something like animall point animation was meant, but could not replicate any issues. Any idea who wrote those?

[curve_haywire_fix.diff](https://archive.blender.org/developer/F9607728/curve_haywire_fix.diff) Some relevant code comments claim issues with animation if the changes in this patch were to be applied. I assume something like animall point animation was meant, but could not replicate any issues. Any idea who wrote those?

Mysteryem commented

2022-01-16 18:17:17 +01:00

Added subscriber: @Mysteryem-2

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Switching Curve Shapekeys in Edit Mode go haywire if relative to one another #78701