The sensitivity of 3D view navigation depends on Line Width preference #79787

New Issue

Yevgeny Makarov · 2020-08-14T19:08:35+02:00

Yevgeny Makarov commented

2020-08-14 19:08:35 +02:00

Blender Version
Broken: version: 2.91.0 Alpha

Short description of error
The sensitivity of 3D view navigation depends on the ui_line_width user preference.
Caused by using U.pixelsize in the 'view3d_edit.c', (must be U.dpi_fac as I understand it).

Especially noticeable when rotating the 3D view.

**Blender Version** Broken: version: 2.91.0 Alpha **Short description of error** The sensitivity of 3D view navigation depends on the `ui_line_width` user preference. Caused by using `U.pixelsize` in the 'view3d_edit.c', (must be `U.dpi_fac` as I understand it). Especially noticeable when rotating the 3D view.

Yevgeny Makarov commented

2020-08-14 19:08:35 +02:00

Added subscriber: @jenkm

Richard Antalik commented

2020-08-18 02:22:12 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2020-08-18 02:44:06 +02:00

Added subscribers: @JulianEisel, @ideasman42, @iss

Richard Antalik commented

2020-08-18 02:44:06 +02:00

Changed status from 'Confirmed' to: 'Archived'

Richard Antalik closed this issue

2020-08-18 02:44:06 +02:00

Richard Antalik self-assigned this 2020-08-18 02:44:06 +02:00

Richard Antalik commented

2020-08-18 02:44:06 +02:00

Now thinking about this a bit more I am not sure if this is bug really. U.pixelsize is to compensate line visibility in high resolution screens. See e82b7f1527
So movement of 1 inch on 100 DPI screen should behave the same as 1 inch movement on 200 DPI screen with U.pixelsize of 2.

I was comparing just how movement in pixel translates to rotation and confirmed on that basis. So question is if this should be based rather on U.dpi_fac or perhaps largest of those two.

So unless @ideasman42 or @JulianEisel don't think this should be changed, I will close this, because it is working as designed.

Now thinking about this a bit more I am not sure if this is bug really. `U.pixelsize` is to compensate line visibility in high resolution screens. See e82b7f1527 So movement of 1 inch on 100 DPI screen should behave the same as 1 inch movement on 200 DPI screen with `U.pixelsize` of 2. I was comparing just how movement in pixel translates to rotation and confirmed on that basis. So question is if this should be based rather on `U.dpi_fac` or perhaps largest of those two. So unless @ideasman42 or @JulianEisel don't think this should be changed, I will close this, because it is working as designed.

blender-admin commented

2020-08-18 03:23:34 +02:00

This issue was referenced by 6978635622

This issue was referenced by 6978635622cc77a559a3f888945d840e2e80a52d

Campbell Barton commented

2020-08-18 04:24:17 +02:00

Changed status from 'Archived' to: 'Resolved'

Campbell Barton commented

2020-08-18 04:40:38 +02:00

Thanks @iss for looking into this. The line width setting impacting the pixelsize means we shouldn't use it for scaling cursor motion.

Committed fixes 6978635622 & d1057890c4.

There are some other areas this should be changed, such as editmesh_bevel.c: pixels_per_inch = U.dpi * U.pixelsize; & ED_view3d_pixel_size use, however these changes aren't so straightforward.

Thanks @iss for looking into this. The line width setting impacting the pixelsize means we shouldn't use it for scaling cursor motion. Committed fixes 6978635622 & d1057890c4. There are some other areas this should be changed, such as `editmesh_bevel.c: pixels_per_inch = U.dpi * U.pixelsize;` & `ED_view3d_pixel_size` use, however these changes aren't so straightforward.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

The sensitivity of 3D view navigation depends on Line Width preference #79787