Mask Editing: Adding mask curve points (CTRL+LMB) doesn't work around certain points #80064

New Issue

Sacha Goedegebure · 2020-08-24T05:44:52+02:00

Sacha Goedegebure commented

2020-08-24 05:44:52 +02:00

System Information
Operating system: Windows-10-10.0.17134-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.92

Blender Version
Broken: version: 2.83.5, branch: master, commit date: 2020-08-19 06:07, hash: c2b144df39
Worked: blender-2.81-cfb6ffd48f77-windows64

Short description of error
The action of adding mask curve points with CTRL+LMB doesn't work on specific points on the default square mask and default circle mask.

Exact steps for others to reproduce the error

Open attached .blend file (with default square and circle mask).
Select any of the indicated mask points.
Try to use CTRL+LMB on the masks to add curve points. This won't work around the indicated mask points.

adding_curvepoints_bug.blend

**System Information** Operating system: Windows-10-10.0.17134-SP0 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.92 **Blender Version** Broken: version: 2.83.5, branch: master, commit date: 2020-08-19 06:07, hash: `c2b144df39` Worked: blender-2.81-cfb6ffd48f77-windows64 **Short description of error** The action of adding mask curve points with CTRL+LMB doesn't work on specific points on the default square mask and default circle mask. **Exact steps for others to reproduce the error** - Open attached .blend file (with default square and circle mask). - Select any of the indicated mask points. - Try to use CTRL+LMB on the masks to add curve points. This won't work around the indicated mask points. [adding_curvepoints_bug.blend](https://archive.blender.org/developer/F8807570/adding_curvepoints_bug.blend)

Sacha Goedegebure commented

2020-08-24 05:44:52 +02:00

Added subscriber: @SachaGoedegebure

Germano Cavalcante commented

2020-08-25 22:01:05 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2020-08-25 22:02:52 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-08-25 22:02:52 +02:00

Thanks for the report.
In fact it used to work in version 2.81

Thanks for the report. In fact it used to work in version 2.81

Germano Cavalcante commented

2020-08-27 21:37:04 +02:00

Added subscriber: @Sergey

Germano Cavalcante commented

2020-08-27 21:37:04 +02:00

Problem introduced in 9fac6765c8
This change seems to solve the problem:

diff --git a/source/blender/editors/mask/mask_add.c b/source/blender/editors/mask/mask_add.c
index 3dc6227434e..162264e8cdb 100644
--- a/source/blender/editors/mask/mask_add.c
+++ b/source/blender/editors/mask/mask_add.c
@@ -463,7 +463,7 @@ static int add_vertex_handle_cyclic_at_point(bContext *C,
 
   if (spline->flag & MASK_SPLINE_CYCLIC) {
     /* No cycling toggle needed, we've got nothing meaningful to do in this operator. */
-    return OPERATOR_CANCELLED;
+    return OPERATOR_PASS_THROUGH;
   }
 
   float co_pixel[2];

@Sergey, mind taking a look? (I'm not sure what that commit does).

Problem introduced in 9fac6765c8 This change seems to solve the problem: ``` diff --git a/source/blender/editors/mask/mask_add.c b/source/blender/editors/mask/mask_add.c index 3dc6227434e..162264e8cdb 100644 --- a/source/blender/editors/mask/mask_add.c +++ b/source/blender/editors/mask/mask_add.c @@ -463,7 +463,7 @@ static int add_vertex_handle_cyclic_at_point(bContext *C, if (spline->flag & MASK_SPLINE_CYCLIC) { /* No cycling toggle needed, we've got nothing meaningful to do in this operator. */ - return OPERATOR_CANCELLED; + return OPERATOR_PASS_THROUGH; } float co_pixel[2]; ``` @Sergey, mind taking a look? (I'm not sure what that commit does).

Sergey Sharybin commented

2020-08-28 09:28:36 +02:00

Update the comment above the changed line to something like:

The spline is already cyclic, so there is no need to handle anything here.
Return PASS_THROUGH so that it's possible to add vertices close to the endpoints of the cyclic spline.

and the fix will be complete.

Update the comment above the changed line to something like: ``` The spline is already cyclic, so there is no need to handle anything here. Return PASS_THROUGH so that it's possible to add vertices close to the endpoints of the cyclic spline. ``` and the fix will be complete.

blender-admin commented

2020-08-28 16:50:21 +02:00

This issue was referenced by 5086bdfe0b

This issue was referenced by 5086bdfe0bb69c8841b81f5f867acd5626038622

Germano Cavalcante commented

2020-08-28 16:50:55 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Germano Cavalcante closed this issue

2020-08-28 16:50:55 +02:00

Germano Cavalcante self-assigned this 2020-08-28 16:50:55 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Mask Editing: Adding mask curve points (CTRL+LMB) doesn't work around certain points #80064