Sequencer crash on float images when OCIO GLSL shader can't be used #80193

New Issue

Sergey Sharybin · 2020-08-28T16:36:43+02:00

Sergey Sharybin commented

2020-08-28 16:36:43 +02:00

System Information
Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits
Graphics card: Intel(R) Iris(TM) Plus Graphics 655 Intel Inc. 4.1 INTEL-14.7.8

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: Unknown Unknown, hash: 7b2fe4c9ec
Worked: Anything prior to faeaf53255

Short description of error

Crash or corrupted display when enabling Convert to Float on sequencer's strip, or when adding EXR float image.

Exact steps for others to reproduce the error

Add image strip to the VSE
Enable Convert to Float in Adjust -> Color in the side panel.

Adding float image (EXR) will likely crash immediately.

Caused by removed format and data type specification in the faeaf53255.
It ie easy to restore the proper format for the display buffer, but after that it is rendering with the wrong color space (presumably due to GPU_framebuffer_bind_no_srgb).

The same missing format/data type specification for fallback is missing in 2.90. The case when Blender is built without OpenColorIO could probably be ignored. But it is not impossible OCIOImpl::setupGLSLDraw returns false, so perhaps the fix is to be applied to both master and 2.90.

P.S. The cache_handle is to be released AFTER the display buffer is used, but that is a separate problem.
P.P.S. This is an unlikely event when this code runs, but if the fix is trivial is still good to apply it to 2.90 branch.

**System Information** Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits Graphics card: Intel(R) Iris(TM) Plus Graphics 655 Intel Inc. 4.1 INTEL-14.7.8 **Blender Version** Broken: version: 2.91.0 Alpha, branch: master, commit date: Unknown Unknown, hash: 7b2fe4c9ec Worked: Anything prior to faeaf53255 **Short description of error** Crash or corrupted display when enabling `Convert to Float` on sequencer's strip, or when adding EXR float image. **Exact steps for others to reproduce the error** 1. Add image strip to the VSE 2. Enable `Convert to Float` in Adjust -> Color in the side panel. Adding float image (EXR) will likely crash immediately. Caused by removed format and data type specification in the faeaf53255. It ie easy to restore the proper format for the display buffer, but after that it is rendering with the wrong color space (presumably due to `GPU_framebuffer_bind_no_srgb`). The same missing format/data type specification for fallback is missing in 2.90. The case when Blender is built without OpenColorIO could probably be ignored. But it is not impossible `OCIOImpl::setupGLSLDraw` returns false, so perhaps the fix is to be applied to both master and 2.90. P.S. The `cache_handle` is to be released AFTER the display buffer is used, but that is a separate problem. P.P.S. This is an unlikely event when this code runs, but if the fix is trivial is still good to apply it to 2.90 branch.

Sergey Sharybin commented

2020-08-28 16:36:43 +02:00

Added subscriber: @Sergey

Dalai Felinto commented

2020-08-28 16:43:33 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2020-08-28 16:43:33 +02:00

I don't think it is high priority to be honest (aka not a show stopper). Building without OCIO is not likely, and if OCIOImpl::setupGLSLDraw returns false we can blame on bad image, so ok-ish to crash in 2.90?

Unless the patch is available and simple.

I don't think it is high priority to be honest (aka not a show stopper). Building without OCIO is not likely, and if `OCIOImpl::setupGLSLDraw` returns false we can blame on bad image, so ok-ish to crash in 2.90? Unless the patch is available and simple.

Brecht Van Lommel commented

2020-08-28 16:47:34 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2020-08-28 16:47:34 +02:00

Agree this is not a showstopper for 2.90, as far as I know it's not something users would encounter in practice with official builds.

Sergey Sharybin changed title from ~~Sequencer crash on float buffers when OCIO is disabled~~ to Sequencer crash on float images when OCIO GLSL shader can't be used

2020-08-28 16:50:15 +02:00

Clément Foucault self-assigned this 2020-08-30 15:47:27 +02:00

Philipp Oeser commented

2020-09-11 11:40:42 +02:00

Added subscriber: @lichtwerk