Deps: potrace 1.16 #80818

New Issue

Ray molenkamp · 2020-09-15T21:21:17+02:00

Ray molenkamp commented

2020-09-15 21:21:17 +02:00

potrace was taken on as an additional library (D8662 / #79877) the svn libs and install_deps will need to be updated for all platforms

Update cmake builder ( 2eec6ec793)
Windows ( rBL62486 )
Mac (rBL62487)
Linux - cmake builder (rBL62488)
Linux - install deps c5c22d1ce1

potrace was taken on as an additional library ([D8662](https://archive.blender.org/developer/D8662) / #79877) the svn libs and install_deps will need to be updated for all platforms - [x] Update cmake builder ( 2eec6ec793) - [x] Windows ( rBL62486 ) - [x] Mac (rBL62487) - [x] Linux - cmake builder (rBL62488) - [x] Linux - install deps c5c22d1ce1

Ray molenkamp commented

2020-09-15 21:21:18 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Ray molenkamp commented

2020-09-15 21:21:18 +02:00

Added subscriber: @LazyDodo

blender-admin commented

2020-09-16 18:34:05 +02:00

This issue was referenced by None@62487

blender-admin commented

2020-09-17 11:17:09 +02:00

This issue was referenced by None@62488

Brecht Van Lommel commented

2020-09-17 12:59:45 +02:00

Added subscribers: @sebbas, @brecht

Brecht Van Lommel commented

2020-09-17 12:59:45 +02:00

@sebbas, there is no code yet to find the potrace library in platform_apple.cmake, probably can just be straight copied from platform_unix.cmake.

@sebbas, there is no code yet to find the potrace library in `platform_apple.cmake`, probably can just be straight copied from `platform_unix.cmake`.

Sebastián Barschkis commented

2020-09-17 13:18:20 +02:00

Ah ok, will add. But just to clarify: platform_unix.cmake is not covering macOS then (?)

I assumed that since we have flags like UNIX AND NOT APPLE that macOS would be "included" under "unix" too.

Ah ok, will add. But just to clarify: `platform_unix.cmake` is not covering macOS then (?) I assumed that since we have flags like `UNIX AND NOT APPLE` that macOS would be "included" under "unix" too.

Ray molenkamp commented

2020-09-17 15:46:20 +02:00

The platform files on the blender side are included like this

if(UNIX AND NOT APPLE)
  include(platform_unix)
elseif(WIN32)
  include(platform_win32)
elseif(APPLE)
  include(platform_apple)
endif()```

so they are exclusive to the platform, for mac the unix one is not used, and hence there are no `APPLE`  checks in `platform_unix.cmake` 

Things are different on the deps_builder side (ie `buid_files/build_environment`) where we go out of our way to make all platforms share as much as possible and only when a certain platform needs an exception you can find platform specific checks scattered where they are most needed.

The platform files on the blender side are included like this ``` if(UNIX AND NOT APPLE) include(platform_unix) elseif(WIN32) include(platform_win32) elseif(APPLE) include(platform_apple) endif()``` so they are exclusive to the platform, for mac the unix one is not used, and hence there are no `APPLE` checks in `platform_unix.cmake` Things are different on the deps_builder side (ie `buid_files/build_environment`) where we go out of our way to make all platforms share as much as possible and only when a certain platform needs an exception you can find platform specific checks scattered where they are most needed.

Sebastián Barschkis commented

2020-09-17 15:51:36 +02:00

I see, makes sense. Thanks @LazyDodo!