Design: New Graph Editor Key Manipulation Operators #81836
Closed
opened 2020-10-19 12:15:10 +02:00 by Christoph Lendenfeld
·
36 comments
No Branch/Tag Specified
main
tmp-usd-python-mtl
blender-v3.6-release
temp-sculpt-dyntopo
asset-browser-frontend-split
temp-sculpt-dyntopo-hive-alloc
node-group-operators
brush-assets-project
asset-shelf
blender-v2.93-release
blender-v3.3-release
universal-scene-description
temp-sculpt-attr-api
blender-v3.5-release
realtime-clock
sculpt-dev
gpencil-next
bevelv2
microfacet_hair
blender-projects-basics
principled-v2
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Apply labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
Eevee & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest/Import
Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
Eevee & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest/Import
Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
19 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#81836
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
This is the design task for #81785
Builds
Linux: https://blender.community/c/graphicall/6qbbbc/
Windows: https://blender.community/c/graphicall/7qbbbc/
Big picture:
Blender already has the pose sliding tools, that allow you to interactively create breakdowns in Pose mode.
It uses a modal operator and the cursor to interactively set the pose. Using the same interaction, we could add similar functionality to the graph editor to manipulate multiple keyframes.
Here is how it works:
graph_editor_slider_tools.mp4
UI
Operators will be in a submenu in within "Key"

For quicker access they are in a pie menu

However this poses the question of how this would work when more operators get added.
What hotkey should be used? I've temporarily set it as
ALT + SHIFT + S
Use the new slider representation from D9054

This makes it possible to quickly reach 0% or 100% because it's capped.
Overshoot can be enabled at the press of a button
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @ChrisLend
Added subscriber: @dr.sybren
Functionality-wise, the video looks nice, indeed.
Can you make a screenshot of what such a pie menu would look like? You can modify any pie menu (for example
GRAPH_MT_key_snap
inspace_graph.py
) so that it just has the appropriate labels. That's enough for a screenshot.I think that operators should be added based on their function, and not on whether or not they use this manipulation method. That may open up a different categorisation, with a pie menu for every category.
Maybe you can update this task's description so that it's clearer how it relates to its child tasks. Now this task and #81785 (Implementation: Modal Key Manipulation Operators) have almost identical titles.
Added subscriber: @LucianoMunoz
Would love it if anyone could build a Windows version .... wink wink
Added subscriber: @HazyHops
DUDE this is AMAZING. Most of these work exactly how I initial figured! Thanks for getting that Windows version up! :D
(Having never posted on a design task, let me know if formatting and such is wrong and I can adjust accordingly)
You may or may not know some of these already?
Seemingly any non-flat bezier tangents have issues when modified by any slider. Specifically the left-side handles stay still.
Smooth Slider: Not sure how the specifics are working but it but on the Smooth slider, going over 100% overshoots the value change of any individual key. Would love to hear other's thoughts on it, but since negative values "un-smooth", I would expect a positive overshoot on Smooth to have the same effect as running multiple 100% smooth actions instead overshooting? (lemme know if you need a vid/image lol)
Sensitivity: Slider representation will fix current value adjusting so I look forward to that, but allowing SHIFT for micro adjustments, (and CTRL/something for larger (significant overshoot) adjustments) would make the slider even more powerful.
thanks for the feedback
formatting is good ;)
Added subscriber: @acorn
Mac version would be very useful.
Added subscriber: @ErickNyanduKabongo
Added subscriber: @jwvdronkelaar
Added subscriber: @FinbarrORiordan
Added subscriber: @Jaye.Antoni_Whyldz
this needs to be here v2.90
This issue was referenced by
9797b95f61
Added subscriber: @JasonSchleifer
Super cool! In terms of hotkeys, since animators are already used to Shift+E to go to pose mode while in the 3D viewport, would it be possible to use something similar like ctrl+shift+e or something like that? Then it'll feel like an extension of the tool they're used to, just with more awesome power. :)
I agree wish Jason here, i feel maybe the main one or the last one you use from the piemenu can be put in shift e, and shift alt e or shift control ee could be used to get the pie menu with all the options
Shift+E would be ideal to keep it consistent, but that hotkey is currently used by "Set Keyframe Extrapolation"
To be fair I think that's not used heavily but we should discuss it at the next meeting.
Either move the pose sliding tools to something else than Shift+E that is available in the graph editor
Or move the "Set Keyframe Extrapolation" thingy to something else
As long as it's consistent I don't mind
3.0 might be a good version to swap things around anyway
I've been inclined to try to think how to do a better version of that menu (set keyframe extrapolation) to be able to use it to add any sort of curve modifier to all the curves selected.
I'd agree that we could move it away from shift e for consitency and come up with a new solution for that.
Added subscriber: @ChristiaanMoleman
Added subscriber: @AndyCuccaro
Added subscriber: @L0Lock
Added subscriber: @Robonnet
Added subscriber: @KevinCBurke
This comment was removed by @KevinCBurke
I was using it incorrectly at first, but after switching to Blend to Neighbor, I got the right behavior. This feature in incredible, @ChrisLend !!
Added subscriber: @hahnzhu
Added subscriber: @razed
Can something like sample undershoot? Might be nice for quick cleanup :)
Could you explain what you mean? Maybe even an example for how it would be used
Sorry for taking so long to get back to you, I was thinking something like the decimate feature but it would try to keep the original bezier shape as best it possibly could. If this comes off as feature request-y, I apologize and ignore me :). I was thinking it could be an extension of the sample operator (to undershoot) but It might just be unrelated functionality.
Added subscriber: @SteffenD
@ChrisLend is stepping down from this work, as other things in his life take priority. As such, I'll take it off the "Short Term Tasks" list for now.