Library-Override Not able to edit Keyframe value in sidebar panel in graph-editor #81965

New Issue

Ali Najafi · 2020-10-22T17:09:20+02:00

Ali Najafi commented

2020-10-22 17:09:20 +02:00

System Information
Operating system: Linux-5.9.1-1-MANJARO-x86_64-with-arch-Manjaro-Linux 64 Bits
Graphics card: AMD Radeon (TM) R9 390 Series (HAWAII, DRM 3.39.0, 5.9.1-1-MANJARO, LLVM 10.0.1) X.Org 4.6 (Core Profile) Mesa 20.1.8

Blender Version
Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-21 22:57, hash: b0f34eee30
also broken on blender 2.83.7 and 2.9

Short description of error
IDK if this is a bug or not, key-frame in Graph-Editor is not editable in sidebar and values are grayed out.

Exact steps for others to reproduce the error

link a collection/character/object
object > relation > make library override
animate
try to change a keyframe's value in graph-editor's sidebar Fcruve > active keyframe.
open the linked_override.blend file, try to change the selected key's value in graph editor's sidebar

graph_key.zip

**System Information** Operating system: Linux-5.9.1-1-MANJARO-x86_64-with-arch-Manjaro-Linux 64 Bits Graphics card: AMD Radeon (TM) R9 390 Series (HAWAII, DRM 3.39.0, 5.9.1-1-MANJARO, LLVM 10.0.1) X.Org 4.6 (Core Profile) Mesa 20.1.8 **Blender Version** Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-21 22:57, hash: `b0f34eee30` also broken on blender 2.83.7 and 2.9 **Short description of error** IDK if this is a bug or not, key-frame in Graph-Editor is not editable in sidebar and values are grayed out. **Exact steps for others to reproduce the error** 1. link a collection/character/object 2. object > relation > make library override 3. animate 4. try to change a keyframe's value in graph-editor's sidebar Fcruve > active keyframe. open the linked_override.blend file, try to change the selected key's value in graph editor's sidebar ![bug.png](https://archive.blender.org/developer/F9036148/bug.png) [graph_key.zip](https://archive.blender.org/developer/F9036144/graph_key.zip)

Ali Najafi commented

2020-10-22 17:09:20 +02:00

Added subscriber: @shylon

Richard Antalik commented

2020-10-23 19:49:19 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Bastien Montagne commented

2020-10-26 17:29:46 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2020-10-26 17:29:46 +01:00

Issue here is that for some reasons (?) this editor uses the animated ID as root of rna paths of these keyframes properties, when it should use the current Action data-block instead.

This is more of an issue for #animation_rigging and/or #user_interface projects really.

Issue here is that for some reasons (?) this editor uses the animated ID as root of rna paths of these keyframes properties, when it should use the current Action data-block instead. This is more of an issue for #animation_rigging and/or #user_interface projects really.

Luciano Muñoz Sessarego commented

2020-11-27 12:44:47 +01:00

Added subscriber: @LucianoMunoz

Luciano Muñoz Sessarego commented

2020-11-27 12:44:47 +01:00

Its not a bug, its just not obvious, you have to go into the rig (original file) and make the option available in the custom property

See the image where it says "is library overridable"

Since this breaks old rigs to work with 2.91 and on, maybe that option should be default on for creation of custom props and let the user turn off the ones he doesn't want to be editable in the linked rigs.

Or maybe blender should look at the file and if there is no "is library overridable" option stored assume its a yes.

Its not a bug, its just not obvious, you have to go into the rig (original file) and make the option available in the custom property See the image where it says "is library overridable" ![2020-11-25 11_25_17-Settings.png](https://archive.blender.org/developer/F9389393/2020-11-25_11_25_17-Settings.png) Since this breaks old rigs to work with 2.91 and on, maybe that option should be default on for creation of custom props and let the user turn off the ones he doesn't want to be editable in the linked rigs. Or maybe blender should look at the file and if there is no "is library overridable" option stored assume its a yes.

Sybren A. Stüvel commented

2020-11-27 12:53:54 +01:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2020-11-27 12:53:54 +01:00

In #81965#1063081, @LucianoMunoz wrote:
Since this breaks old rigs to work with 2.91 and on, maybe that option should be default on for creation of custom props and let the user turn off the ones he doesn't want to be editable in the linked rigs.

I suspect that the option is off by default for efficiency. The library overrides system has to do a lot of comparisons, and having "overridable=off" by default helps to reduce the work.

In #81965#1041921, @mont29 wrote:
Issue here is that for some reasons (?) this editor uses the animated ID as root of rna paths of these keyframes properties, when it should use the current Action data-block instead.

Can you give us some more info? I don't quite follow what you're trying to say.

> In #81965#1063081, @LucianoMunoz wrote: > Since this breaks old rigs to work with 2.91 and on, maybe that option should be default on for creation of custom props and let the user turn off the ones he doesn't want to be editable in the linked rigs. I suspect that the option is off by default for efficiency. The library overrides system has to do a lot of comparisons, and having "overridable=off" by default helps to reduce the work. > In #81965#1041921, @mont29 wrote: > Issue here is that for some reasons (?) this editor uses the animated ID as root of rna paths of these keyframes properties, when it should use the current Action data-block instead. Can you give us some more info? I don't quite follow what you're trying to say.

Luciano Muñoz Sessarego commented

2020-11-27 12:58:36 +01:00

@dr.sybren what about: "blender could look at the property and if there is no "is library overridable" option stored assume its a yes." ?, or "blender could look at the version of the rig file on load and say this is pre 2.91 hence all custom props should be overridable" .

For instance, this makes currently any rig even rain rig unusable with library overrides in 2.91.

@dr.sybren what about: "blender could look at the property and if there is no "is library overridable" option stored assume its a yes." ?, or "blender could look at the version of the rig file on load and say this is pre 2.91 hence all custom props should be overridable" . For instance, this makes currently any rig even rain rig unusable with library overrides in 2.91.

Sybren A. Stüvel commented

2020-11-27 14:09:31 +01:00

I'd rather wait for @mont29's feedback, because I have a feeling that his suggestion would fix things without adding such overhead.

Bastien Montagne commented

2020-11-27 15:40:44 +01:00

RNA path generated for those F-Curve properties uses the ID affected by the animation, not the ID owning the F-Curve (which should be the Action in typical cases).

graph_buttons.c:372, graph_panel_key_properties():

    RNA_id_pointer_create(ale->id, &id_ptr);

... should rather use something like

    RNA_id_pointer_create(ale->fcurve_owner_id, &id_ptr);

... I think (not tested at all though).

RNA path generated for those F-Curve properties uses the ID affected by the animation, not the ID owning the F-Curve (which should be the Action in typical cases). `graph_buttons.c:372`, `graph_panel_key_properties()`: ``` RNA_id_pointer_create(ale->id, &id_ptr); ``` ... should rather use something like ``` RNA_id_pointer_create(ale->fcurve_owner_id, &id_ptr); ``` ... I think (not tested at all though).

Luciano Muñoz Sessarego commented

2020-11-30 11:21:53 +01:00

What would be the next step? anything i can further do to help?

Ivan Cappiello commented

2021-01-12 10:29:38 +01:00

Added subscriber: @icappiello

Ivan Cappiello commented

2021-01-12 10:50:16 +01:00

In #81965#1063081, @LucianoMunoz wrote:
Its not a bug, its just not obvious, you have to go into the rig (original file) and make the option available in the custom property

@dr.sybren @LucianoMunoz while this seems to be a real limitation or a bug to me. In the example @LucianoMunoz can toggle the "is library overridable" option because he's using a custom property, but in my simple test - where i have a linked geometry, create the library override and animated just transform channel - this cannot be done by toggling that option. The resulting overridden object will have f-curve values and handles grayed out in the sidebar.

graph_issue.zip

> In #81965#1063081, @LucianoMunoz wrote: > Its not a bug, its just not obvious, you have to go into the rig (original file) and make the option available in the custom property > @dr.sybren @LucianoMunoz while this seems to be a real limitation or a bug to me. In the example @LucianoMunoz can toggle the "is library overridable" option because he's using a custom property, but in my simple test - where i have a linked geometry, create the library override and animated just transform channel - this cannot be done by toggling that option. The resulting overridden object will have f-curve values and handles grayed out in the sidebar. [graph_issue.zip](https://archive.blender.org/developer/F9560892/graph_issue.zip)

Sybren A. Stüvel commented

2021-01-12 13:53:07 +01:00

In #81965#1063289, @mont29 wrote:
RNA path generated for those F-Curve properties uses the ID affected by the animation, not the ID owning the F-Curve (which should be the Action in typical cases).

graph_buttons.c:372, graph_panel_key_properties():
    RNA_id_pointer_create(ale->id, &id_ptr);
... should rather use something like
    RNA_id_pointer_create(ale->fcurve_owner_id, &id_ptr);

This exact example wouldn't work (this code really needs to work with ale->id), but the call to RNA_pointer_create() in the line above that certainly has that mistake. I've applied that in D10091.

> In #81965#1063289, @mont29 wrote: > RNA path generated for those F-Curve properties uses the ID affected by the animation, not the ID owning the F-Curve (which should be the Action in typical cases). > > `graph_buttons.c:372`, `graph_panel_key_properties()`: > ``` > RNA_id_pointer_create(ale->id, &id_ptr); > ``` > ... should rather use something like > ``` > RNA_id_pointer_create(ale->fcurve_owner_id, &id_ptr); > ``` This exact example wouldn't work (this code really needs to work with `ale->id`), but the call to `RNA_pointer_create()` in the line above that certainly has that mistake. I've applied that in [D10091](https://archive.blender.org/developer/D10091).

blender-admin commented

2021-01-12 15:43:42 +01:00

This issue was referenced by c3b68fa7b1

This issue was referenced by c3b68fa7b1cafa6c4e4b73830597582606082b6d

Sybren A. Stüvel commented

2021-01-12 15:48:48 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2021-01-12 15:48:48 +01:00

Sybren A. Stüvel self-assigned this 2021-01-12 15:48:48 +01:00

Thomas Dinges added this to the 2.92 milestone 2023-02-08 16:16:03 +01:00

Alvarodlfm referenced this issue