Ratio displayed with a % sign in the Decimate Keyframes Adjust Last Operation panel. #82070

New Issue

RealName · 2020-10-25T19:12:20+01:00

RealName commented

2020-10-25 19:12:20 +01:00

Blender Version
Broken: Since it's introduction in 2.82 to current master.
The issue even appears in the release notes demo video.

Short description of error
Small bug, more of an inconsistency. The percentage goes from 0 to 1, which is decimal and not percentage, yet shows a % symbol.

This isn't how percentages work. Half way should be 50%, not 0.500%; 100%, not 1.000%. Of course the percentage symbol could just be removed and it'd be correct to have 0.5 and 1 as half and full.

This specific case is in decimating keyframes 'Remove' slider in the f-curve modifier, though maybe it happens everywhere else and I only just noticed.

Exact steps for others to reproduce the error
Open the following file:
#82070 Ratio has percent sign.blend
In the graph editor, open the menu Key->Decimate (Ratio)
Confirm the operation with left mouse click.
Look at the Adjust Last Operation Panel.

**Blender Version** Broken: Since it's introduction in 2.82 to current master. The issue even appears in the release notes demo video. ![Decimate_Fcurve_Demo.jpg](https://archive.blender.org/developer/F9091320/Decimate_Fcurve_Demo.jpg) **Short description of error** Small bug, more of an inconsistency. The percentage goes from 0 to 1, which is decimal and not percentage, yet shows a % symbol. ![image.png](https://archive.blender.org/developer/F9089927/image.png) This isn't how percentages work. Half way should be 50%, not 0.500%; 100%, not 1.000%. Of course the percentage symbol could just be removed and it'd be correct to have 0.5 and 1 as half and full. ![image.png](https://archive.blender.org/developer/F9090043/image.png) This specific case is in decimating keyframes 'Remove' slider in the f-curve modifier, though maybe it happens everywhere else and I only just noticed. **Exact steps for others to reproduce the error** Open the following file: [#82070 Ratio has percent sign.blend](https://archive.blender.org/developer/F9091346/T82070_Ratio_has_percent_sign.blend) In the graph editor, open the menu `Key->Decimate (Ratio)` Confirm the operation with left mouse click. Look at the Adjust Last Operation Panel.

RealName commented

2020-10-25 19:12:20 +01:00

Added subscriber: @Nickname6498156

Berk Elyesa Yıldırım commented

2020-10-25 19:27:21 +01:00

Added subscriber: @Beryesa

Evan Wilson commented

2020-10-25 20:22:46 +01:00

Added subscriber: @EAW

Evan Wilson commented

2020-10-25 20:22:46 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Evan Wilson commented

2020-10-25 20:22:46 +01:00

Confirmed in 2.82a, 2.83, current master & 2.90

It is correctly displayed in the header.
decimate_draw_status_header

Confirmed in 2.82a, 2.83, current master & 2.90 ![#82070.png](https://archive.blender.org/developer/F9090870/T82070.png) It is correctly displayed in the header. [decimate_draw_status_header](https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_graph/graph_edit.c$1437) ![T82070_Header_correct.png](https://archive.blender.org/developer/F9090873/T82070_Header_correct.png)

Evan Wilson changed title from ~~0.5% is not half, should be 50%~~ to Ratio displayed with a % sign in the Decimate Keyframes Adjust Last Operation panel.

2020-10-25 21:01:32 +01:00

Evan Wilson commented

2020-10-25 21:02:20 +01:00

Added subscriber: @ZedDB

Evan Wilson commented

2020-10-25 21:02:21 +01:00

@ZedDB Tagging you here since you implemented this feature.

Erik Abrahamsson commented

2020-10-25 21:21:06 +01:00

Added subscriber: @erik85

Erik Abrahamsson commented

2020-10-25 21:21:06 +01:00

"remove_ratio" should be a RNA_def_float to remove the % sign, or keep it as a RNA_def_float_percentage and change the max value to 100 and change the execution code I guess.

RNA_def_float_percentage is used wrongly in two other places in the code: pose slide and gpencil interpolate.

"remove_ratio" should be a **RNA_def_float** to remove the % sign, or keep it as a **RNA_def_float_percentage** and change the max value to 100 and change the execution code I guess. **RNA_def_float_percentage** is used wrongly in two other places in the code: pose slide and gpencil interpolate.

Hans Goudey commented

2020-10-25 22:27:15 +01:00

Added subscriber: @HooglyBoogly