Overlay setting "Fade Inactive Geometry" does not work with instance collections. #82155

New Issue

Christoph · 2020-10-27T16:38:58+01:00

Christoph commented

2020-10-27 16:38:58 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 452.06

Blender Version
Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-26 17:29, hash: edf4378c44
Worked: (newest version of Blender that worked as expected)

Short description of error
Overlay setting "Fade Inactive Geometry" does not work with instance collections. Instance Collections are allways 100% visible.

Exact steps for others to reproduce the error
Make a scene with an object and add an instance collection of an object. Go to editmode and actovate "Fade Inactive Geometry". The Instance collections does not fade.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce RTX 2070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 452.06 **Blender Version** Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-26 17:29, hash: `edf4378c44` Worked: (newest version of Blender that worked as expected) **Short description of error** Overlay setting "Fade Inactive Geometry" does not work with instance collections. Instance Collections are allways 100% visible. **Exact steps for others to reproduce the error** Make a scene with an object and add an instance collection of an object. Go to editmode and actovate "Fade Inactive Geometry". The Instance collections does not fade.

Christoph commented

2020-10-27 16:38:58 +01:00

Added subscriber: @ChrisGraz

blender-admin commented

2020-10-27 16:38:58 +01:00

#88133 was marked as duplicate of this issue

blender-admin commented

2020-10-27 16:38:58 +01:00

#83472 was marked as duplicate of this issue

Philipp Oeser commented

2020-10-27 17:59:23 +01:00

Added subscribers: @PabloDobarro, @fclem, @lichtwerk

Philipp Oeser commented

2020-10-27 17:59:23 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-10-27 17:59:23 +01:00

Can confirm, but this looks like it has been coded on purpose to begin with? ea6cd1c8f0

https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/overlay/overlay_engine.c$279

@PabloDobarro , @fclem : any reason why this was in there? D9363 seems to work, no?

Can confirm, but this looks like it has been coded on purpose to begin with? ea6cd1c8f0 https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/overlay/overlay_engine.c$279 @PabloDobarro , @fclem : any reason why this was in there? [D9363](https://archive.blender.org/developer/D9363) seems to work, no?

Philipp Oeser commented

2020-10-27 18:00:55 +01:00

Ha, classic duplicated efforts :)

Pablo Dobarro commented

2020-10-27 18:02:43 +01:00

I think this was proposed to fade the instances of the active object when it is being edited. In that case, the correct fix would be to fade those instances and all other instances of other objects.

In that case, I would expect the fix to be a version that works of:

  if (ob->data == active_object->data && ob->base_flag & BASE_FROM_DUPLI) {
     return false;
  }

I think this was proposed to fade the instances of the active object when it is being edited. In that case, the correct fix would be to fade those instances and all other instances of other objects. In that case, I would expect the fix to be a version that works of: ``` if (ob->data == active_object->data && ob->base_flag & BASE_FROM_DUPLI) { return false; } ```

Philipp Oeser commented

2020-12-07 12:48:54 +01:00

Added subscriber: @item412