Knife tool draws huge vertices (it draws verts with glPointSize is not initialized) #82164

New Issue

Jose Conseco · 2020-10-27T18:59:12+01:00

Jose Conseco commented

2020-10-27 18:59:12 +01:00

System Information
Operating system: Linux-5.8.16-2-MANJARO-x86_64-with-arch-Manjaro-Linux 64 Bits
Graphics card: GeForce GTX 1660 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100

Blender Version
Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-26 17:29, hash: edf4378c44
Worked: 2.90

Short description of error
When I draw something with bgl and use:

bgl.glPointSize(41) #to default 1

The build-in knife tool UI is affected (knife draws huge vertices):

Exact steps for others to reproduce the error
Run script from attached blend file
Then run knife tool - it vertices higlight will be huge

import bpy
import gpu
import bgl
from gpu_extras.batch import batch_for_shader

coords = [(1, 1, 1), (-2, 0, 0), (-2, -1, 3), (0, 1, 1)]
shader = gpu.shader.from_builtin('3D_UNIFORM_COLOR')
batch = batch_for_shader(shader, 'LINES', {"pos": coords})


def draw():
    shader.bind()
    shader.uniform_float("color", (1, 1, 0, 1))
    batch.draw(shader)
    bgl.glPointSize(41) #default 1 


bpy.types.SpaceView3D.draw_handler_add(draw, (), 'WINDOW', 'POST_VIEW')

KnifeVErtSizeBug.blend

**System Information** Operating system: Linux-5.8.16-2-MANJARO-x86_64-with-arch-Manjaro-Linux 64 Bits Graphics card: GeForce GTX 1660 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100 **Blender Version** Broken: version: 2.91.0 Beta, branch: master, commit date: 2020-10-26 17:29, hash: `edf4378c44` Worked: 2.90 **Short description of error** When I draw something with bgl and use: ``` bgl.glPointSize(41) #to default 1 ``` The build-in knife tool UI is affected (knife draws huge vertices): ![image.png](https://archive.blender.org/developer/F9112513/image.png) **Exact steps for others to reproduce the error** Run script from attached blend file Then run knife tool - it vertices higlight will be huge ``` import bpy import gpu import bgl from gpu_extras.batch import batch_for_shader coords = [(1, 1, 1), (-2, 0, 0), (-2, -1, 3), (0, 1, 1)] shader = gpu.shader.from_builtin('3D_UNIFORM_COLOR') batch = batch_for_shader(shader, 'LINES', {"pos": coords}) def draw(): shader.bind() shader.uniform_float("color", (1, 1, 0, 1)) batch.draw(shader) bgl.glPointSize(41) #default 1 bpy.types.SpaceView3D.draw_handler_add(draw, (), 'WINDOW', 'POST_VIEW') ``` [KnifeVErtSizeBug.blend](https://archive.blender.org/developer/F9112523/KnifeVErtSizeBug.blend)

Jose Conseco commented

2020-10-27 18:59:12 +01:00

Added subscriber: @JoseConseco

Jose Conseco commented

2020-10-27 19:13:22 +01:00

BTW. maybe it is related to: https://developer.blender.org/D8728

Philipp Oeser commented

2020-10-28 09:47:05 +01:00

Added subscribers: @mano-wii, @lichtwerk

Philipp Oeser commented

2020-10-28 09:47:05 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-10-28 09:47:05 +01:00

@mano-wii: assume D8728: Knife: Use specialized shader for drawing points would resolve this, too, so do you have plans to finish that up?

@mano-wii: assume [D8728: Knife: Use specialized shader for drawing points](https://archive.blender.org/developer/D8728) would resolve this, too, so do you have plans to finish that up?

Germano Cavalcante commented

2020-10-28 16:37:01 +01:00

It would solve, but the problem is more internal.
The knife tool shows only a side effect of the real problem.

The real problem is known and should be resolved before the final release.

It would solve, but the problem is more internal. The knife tool shows only a side effect of the real problem. The real problem is known and should be resolved before the final release.

Jacques Lucke commented

2020-11-05 15:48:18 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2020-11-05 15:48:18 +01:00

I'll set the priority to high, because you said this should be solved before the release.

Dalai Felinto commented

2020-11-05 17:45:29 +01:00

Added subscribers: @fclem, @dfelinto

Germano Cavalcante was assigned by Dalai Felinto

2020-11-05 17:45:29 +01:00

Dalai Felinto commented

2020-11-05 17:45:29 +01:00

@mano-wii but what is the "real problem"? And who is planning to tackle it? (assigning it to you, assuming it is in your agenda).

That said I would hardly consider this a bug, specially not a high priority one. The script should change the point size back to the default after using it. @fclem thoughts?

@mano-wii but what is the "real problem"? And who is planning to tackle it? (assigning it to you, assuming it is in your agenda). That said I would hardly consider this a bug, specially not a high priority one. The script should change the point size back to the default after using it. @fclem thoughts?

Jose Conseco commented

2020-11-05 19:19:26 +01:00

The probem is if I reset point size to 1, then knife tool vert size will be to small (should be around 3-5 px by default?) It like the knife tool does not initialize point size correctly for itself.

blender-admin commented

2020-11-05 21:14:09 +01:00

This issue was referenced by 1b9d9cb1ed

This issue was referenced by 1b9d9cb1ed7019e05b11cc480aef75a10e952957

Germano Cavalcante commented

2020-11-05 22:37:38 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Germano Cavalcante closed this issue

2020-11-05 22:37:38 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Knife tool draws huge vertices (it draws verts with glPointSize is not initialized) #82164