Color Management Use Curves do not update when UV Editor is presented #82460

New Issue

Alex · 2020-11-06T12:47:35+01:00

Alex commented

2020-11-06 12:47:35 +01:00

System Information
Intel Core 2 Quad, 8 Gb RAM, NVidia GeForce GTX 960 2GB
Windows 7 x64

Blender Version
Broken: 2.91 Beta 02677ec4e0
Worked: 2.90.1, 2.91
Caused by 4212b6528a

Short description of error
Color Management Use Curves doesn't update properly if you open UV or Image Editor alongside the main 3D Viewport. Curve itself is working but only if you right click on it after making changes.
Just in case, I was testing this on a fresh localized version of Blender so I'm 100% sure it's not caused by an addon or any setting.

Exact steps for others to reproduce the error

Open Blender and change Timeline Editor on the bottom to UV Editor
Switch to Rendered shading and enable Use Curves in Render Properties - Color Management.
Add a point to a curve and move it around, release the mouse and nothing will happen. Right click on a curve and 3D View will be updated.
Switch bottom editor back to Timeline and move the curve point again – 3d View will be updated when you'll release the mouse.

**System Information** Intel Core 2 Quad, 8 Gb RAM, NVidia GeForce GTX 960 2GB Windows 7 x64 **Blender Version** Broken: 2.91 Beta 02677ec4e0fa Worked: 2.90.1, 2.91 Caused by 4212b6528a **Short description of error** Color Management Use Curves doesn't update properly if you open UV or Image Editor alongside the main 3D Viewport. Curve itself is working but only if you right click on it after making changes. Just in case, I was testing this on a fresh localized version of Blender so I'm 100% sure it's not caused by an addon or any setting. **Exact steps for others to reproduce the error** 1. Open Blender and change Timeline Editor on the bottom to UV Editor 2. Switch to Rendered shading and enable Use Curves in Render Properties - Color Management. 3. Add a point to a curve and move it around, release the mouse and nothing will happen. Right click on a curve and 3D View will be updated. 4. Switch bottom editor back to Timeline and move the curve point again – 3d View will be updated when you'll release the mouse.

Alex commented

2020-11-06 12:47:35 +01:00

Added subscriber: @SpectreFirst

Robert Guetzkow commented

2020-11-06 13:23:08 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-11-06 13:23:08 +01:00

~~I can reproduce this in Blender 2.91 02677ec4e0, current master works fine. A build of 2.91 1c653a0315 works fine as well, the issue was introduced somewhere in between.~~

Edit: The commit hashes where this worked correctly may not be accurate as I had trouble reliable reproducing the issue (see comments below).

~~I can reproduce this in Blender 2.91 02677ec4e0, current master works fine. A build of 2.91 1c653a0315 works fine as well, the issue was introduced somewhere in between.~~ Edit: The commit hashes where this worked correctly may not be accurate as I had trouble reliable reproducing the issue (see comments below).

Robert Guetzkow commented

2020-11-06 13:27:57 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2020-11-06 13:27:57 +01:00

I will try to bisect this. I'll tag this as Render & Cycles for now since this module includes color management.

Robert Guetzkow commented

2020-11-06 14:26:59 +01:00

Strange, I must have done something different the first time around, because I currently can't reproduce it anymore. Will investigate further.

Robert Guetzkow commented

2020-11-06 14:27:18 +01:00

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'

Robert Guetzkow commented

2020-11-06 14:36:09 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Needs User Info'

Robert Guetzkow commented

2020-11-06 14:36:09 +01:00

We must have both performed some additional action that is not explicitly mentioned in your step by step instructions or it's not quite deterministic. Could you please check if you can find anything missing that is required to reproduce this? I've tried various approaches but wasn't able to.

Alex commented

2020-11-06 17:44:23 +01:00

@rjg I have double-checked both latest 2.91 and 2.92 and in both cases it is 100% reproducible with the steps described above - open Blender, switch Timeline to UV Editor, switch to Rendered view, enable Use Curves and try changing it, in fact, right now I was able to reproduce even worse situation when curves don't work at all until you switch UV Editor to something else. Are you sure you have UV Editor instead of Timeline? I have also tried to launch via shortcut with blender.exe -d and it works the same.

Edit: I was able to reproduce the case when my steps don't work by setting Render Result into an editor - with Render Result in place it seems to be working but if you remove it and leave UV Editor blank it will stop working again.

@rjg I have double-checked both latest 2.91 and 2.92 and in both cases it is 100% reproducible with the steps described above - open Blender, switch Timeline to UV Editor, switch to Rendered view, enable Use Curves and try changing it, in fact, right now I was able to reproduce even worse situation when curves don't work at all until you switch UV Editor to something else. Are you sure you have UV Editor instead of Timeline? I have also tried to launch via shortcut with blender.exe -d and it works the same. Edit: I was able to reproduce the case when my steps don't work by setting Render Result into an editor - with Render Result in place it seems to be working but if you remove it and leave UV Editor blank it will stop working again. ![UseCurvesBug.JPG](https://archive.blender.org/developer/F9219819/UseCurvesBug.JPG) ![UseCurvesNoBug.JPG](https://archive.blender.org/developer/F9219821/UseCurvesNoBug.JPG)

Robert Guetzkow commented

2020-11-06 17:58:12 +01:00

I could reproduce this once more in 02677ec4e0, but it's apparently it's random when it actually occurs. I can't reproduce it reliably.

I could reproduce this once more in 02677ec4e0, but it's apparently it's random when it actually occurs. I can't reproduce it reliably.

Alex commented

2020-11-06 18:38:26 +01:00

Honestly I don't know what else to provide because on my end it's 100% reproducible - every time I remove everything from UV Editor, Use Curves just stops working, it affects both new scenes and my working files the same exact way. I can provide my test scene but it's literally a default blender scene with UV Editor and Use Curves enabled. You can try to load my file, switch to Rendered viewport shading and try to move the dot within Use Curves field, on my end 3D View will not update every single time both on 2.91 and 2.92.
UseCurvesBug.blend

Honestly I don't know what else to provide because on my end it's 100% reproducible - every time I remove everything from UV Editor, Use Curves just stops working, it affects both new scenes and my working files the same exact way. I can provide my test scene but it's literally a default blender scene with UV Editor and Use Curves enabled. You can try to load my file, switch to Rendered viewport shading and try to move the dot within Use Curves field, on my end 3D View will not update every single time both on 2.91 and 2.92. [UseCurvesBug.blend](https://archive.blender.org/developer/F9220221/UseCurvesBug.blend)

Robert Guetzkow commented

2020-11-06 19:16:00 +01:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Robert Guetzkow commented

2020-11-07 00:42:34 +01:00

Even with your file I can only get it to happen occasionally, which makes debugging and bisecting a challenge. Perhaps another developer can reproduce it as reliable as you do, on their system.

Philipp Oeser commented

2020-11-09 18:43:26 +01:00

Added subscribers: @Jeroen-Bakker, @lichtwerk

Philipp Oeser commented

2020-11-09 18:43:26 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Philipp Oeser commented

2020-11-09 18:43:26 +01:00

Can confirm.

Caused by 4212b6528a

CC @Jeroen-Bakker

Can confirm. Caused by 4212b6528a CC @Jeroen-Bakker

Jeroen Bakker was assigned by Philipp Oeser

2020-11-10 09:16:47 +01:00

Jeroen Bakker commented

2020-11-10 11:42:41 +01:00

Seems like a missing tag. Will check on it.

Jeroen Bakker was unassigned by Philipp Oeser

2020-11-13 16:36:25 +01:00

Philipp Oeser self-assigned this 2020-11-13 16:36:25 +01:00

Philipp Oeser commented

2020-11-13 16:36:25 +01:00

Been investigating a bit and here are my findings:

updateGLSLCurveMapping compares cacheIDs and in certain scenarios, these are the same when they should not.

whenever we have multiple viewports that are colormanaged with curvemappings this goes right (cacheIDs are different)
for example, this also goes right when the ImageEditor displays a Render Result or a Compositor Viewer
but it goes wrong when the Image Editor displays any other Image (or no Image at all)
it also goes right if there are multiple Image Editors [and one of them displays a Render Result e.g]

Now why is this so?

For comparison, a pointer address is used.

update_glsl_display_processor frees the curve_mapping, see BKE_curvemapping_free(global_glsl_state.curve_mapping)
similar, update_glsl_display_processor creates a new curvemapping, see BKE_curvemapping_copy(view_settings->curve_mapping)
now for the situation that a viewport with curvemapping and a viewport without curvemapping is present and you make changes to the curvemapping the following happens:
- curve_mapping_settings->cache_id is set once [to the memory address of curvemapping before change]
- change happens
- viewport 1 frees curvemapping
- viewport 2 duplicates using BKE_curvemapping_copy, but this one gets the same address like before the change :/
- this means we have different data on the same address with the same cacheID...

There should be a way to avoid this

Been investigating a bit and here are my findings: `updateGLSLCurveMapping` compares cacheIDs and in certain scenarios, these are the same when they should not. - whenever we have multiple viewports that are colormanaged with curvemappings this goes right (cacheIDs are different) - for example, this also goes right when the ImageEditor displays a Render Result or a Compositor Viewer - but it goes wrong when the Image Editor displays any other Image (or no Image at all) - it also goes right if there are multiple Image Editors [and one of them displays a Render Result e.g] Now why is this so? For comparison, a pointer address is used. - `update_glsl_display_processor` frees the curve_mapping, see BKE_curvemapping_free(global_glsl_state.curve_mapping) - similar, `update_glsl_display_processor` creates a new curvemapping, see BKE_curvemapping_copy(view_settings->curve_mapping) - now for the situation that a viewport with curvemapping and a viewport without curvemapping is present and you make changes to the curvemapping the following happens: - curve_mapping_settings->cache_id is set once [to the memory address of curvemapping before change] - change happens - viewport 1 frees curvemapping - viewport 2 duplicates using BKE_curvemapping_copy, but this one gets the same address like before the change :/ - this means we have different data on the same address with the same cacheID... There should be a way to avoid this

Philipp Oeser commented

2020-11-13 17:27:59 +01:00

note: this is exactly where it fails (in the scenario described above, reallocation wont give a new address):

    /* We're using curve mapping's address as a cache ID,
     * so we need to make sure re-allocation gives new address here.
     * We do this by allocating new curve mapping before freeing old one. */

note: this is exactly where it fails (in the scenario described above, reallocation wont give a new address): ``` /* We're using curve mapping's address as a cache ID, * so we need to make sure re-allocation gives new address here. * We do this by allocating new curve mapping before freeing old one. */ ```

Jeroen Bakker commented

2020-11-13 18:40:07 +01:00

Thanks for looking into this. I would rather use a hash for this. Basing this out of a memory pointer isn’t deterministic.

blender-admin commented

2020-11-13 22:09:37 +01:00

This issue was referenced by 7db42b8f2a

This issue was referenced by 7db42b8f2a8cdec5067f2fe73082bd5d806a5e42

Philipp Oeser commented

2020-11-16 12:55:13 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2020-11-16 12:55:13 +01:00

Thomas Dinges added this to the 2.91 milestone 2023-02-08 16:20:08 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Color Management Use Curves do not update when UV Editor is presented #82460